[Bug 41377] New: Windows 10 DISM failed to find the resources

https://bugs.winehq.org/show_bug.cgi?id=41377

Bug ID: 41377
           Summary: Windows 10 DISM failed to find the resources
           Product: Wine
           Version: 1.9.19
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 55726
  --> https://bugs.winehq.org/attachment.cgi?id=55726
wine dism.exe

Steps to reproduce:
- visit
https://developer.microsoft.com/en-us/windows/hardware/windows-assessment-de...
and download version for Windows 10 1607
- in terminal:
$ export WINEARCH=win32 WINEPREFIX=$HOME/.wine32
$ winetricks -q dotnet452 wininet
$ winecfg # set Windows version to 10
$ wine adksetup.exe /features OptionId.DeploymentTools
$ cd $WINEPREFIX/drive_c/Program\ Files/Windows\ Kits/10/Assessment\ and\
Deployment\ Kit/Deployment\ Tools/x86/DISM
$ wine dism.exe

Expected output:
https://static.amido.com/wp-content/uploads/2016/02/05094332/DISM-BHelp.png

[Bug 41377] Windows 10 DISM failed to find the resources

https://bugs.winehq.org/show_bug.cgi?id=41377

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |41315

[Bug 41377] Windows 10 DISM failed to find the resources

https://bugs.winehq.org/show_bug.cgi?id=41377

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|41315                       |

[Bug 41377] Windows 10 DISM failed to find the resources

https://bugs.winehq.org/show_bug.cgi?id=41377

--- Comment #1 from [e-mail] ---
Needs to use this patch first: https://bugs.winehq.org/show_bug.cgi?id=41315
http://source.winehq.org/git/wine.git/commit/e6e8ed47e6d6d245e4bbda13691eb71...

[Bug 41377] Windows 10 DISM failed to find the resources

https://bugs.winehq.org/show_bug.cgi?id=41377

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |41315

[Bug 41377] Windows 10 DISM failed to find the resources

https://bugs.winehq.org/show_bug.cgi?id=41377

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://developer.microsoft
                   |                            |.com/en-us/windows/hardware
                   |                            |/windows-assessment-deploym
                   |                            |ent-kit
           Keywords|                            |download

[Bug 41377] Windows 10 DISM failed to find the resources

https://bugs.winehq.org/show_bug.cgi?id=41377

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #2 from Louis Lenders  ---
Confirming. I too get: Failed to find the resources for this executable.

My guess is that the problem is in SetThreadUILanguage
It gets a bit further with the hack at the end***
(MSDN says If the language identifier is 0, the function always succeeds and
returns the identifier of the language that best supports the Windows console.)

As said, it gets abit further then and it looks as if it then chokes in:

fixme:ver:GetFileVersionInfoExW stub: 3 L"C:\Program Files\Windows
Kits\10\Assessment and Deployment Kit\Deployment
Tools\x86\DISM\DismCore.dll" 3405192 2097152 0x550020

Error: 120

An error occurred while loading DISM. The DISM tool may be corrupt. 
Try reinstalling DISM.

Couldnt get any further.

***:

diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c
index ca59751..2712667 100644
--- a/dlls/kernel32/locale.c
+++ b/dlls/kernel32/locale.c
@@ -2749,7 +2749,7 @@ BOOL WINAPI SetThreadLocale( LCID lcid )
 LANGID WINAPI SetThreadUILanguage( LANGID langid )
 {
     TRACE("(0x%04x) stub - returning success\n", langid);
-    return langid;
+    if(langid) return langid; else return 1033;
 }

/******************************************************************************

[Bug 41377] Windows 10 DISM failed to find the resources

https://bugs.winehq.org/show_bug.cgi?id=41377

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Vijay Kamuju  ---
I have tested the function on windows vista 64 bit(english - user language)
usging cygwin+mingw-w64 
If you pass 1, it returns 1, error code = 0
If you pass 0, it returns 1033 , error code = 0
If you pass NULL, it returns 1033 , error code = 0
If you pass -1, it returns 1033 , error code = 0x2

[Bug 41377] Windows 10 DISM failed to find the resources

https://bugs.winehq.org/show_bug.cgi?id=41377

--- Comment #4 from Vijay Kamuju  ---
I have tested the function on windows vista 64 bit(english - user language)
usging cygwin+mingw-w64 
If you pass 1, it returns 1, error code = 0
If you pass 0, it returns 1033 , error code = 0
If you pass NULL, it returns 1033 , error code = 0
If you pass -1, it returns 1033 , error code = 0x2

[Bug 41377] Windows 10 DISM fails to find its resources ( kernel32 SetThreadUILanguage must return non-zero/ best fit language identifier if zero is passed)

https://bugs.winehq.org/show_bug.cgi?id=41377

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |kernel32
                 CC|                            |[e-mail]
            Summary|Windows 10 DISM failed to   |Windows 10 DISM fails to
                   |find the resources          |find its resources
                   |                            |(kernel32
                   |                            |SetThreadUILanguage must
                   |                            |return non-zero/best fit
                   |                            |language identifier if zero
                   |                            |is passed)

--- Comment #5 from Anastasius Focht  ---
Hello folks,

confirming.

The MUI app tries to locate its resource dlls based on the returned language
identifier - which should be non-zero even if zero is specified.

It's as Louis said.

https://msdn.microsoft.com/en-us/library/windows/desktop/dd374053(v=vs.85).a...

$ wine --version
wine-3.0-180-g85635db0ea

Regards

[Bug 41377] Windows 10 DISM fails to find its resources ( kernel32 SetThreadUILanguage must return non-zero/ best fit language identifier if zero is passed)

https://bugs.winehq.org/show_bug.cgi?id=41377

--- Comment #6 from Louis Lenders  ---
Created attachment 60921
  --> https://bugs.winehq.org/attachment.cgi?id=60921
patch

Attached patch improves stub so bug is gone

[Bug 41377] Windows 10 DISM fails to find its resources ( kernel32 SetThreadUILanguage must return non-zero/ best fit language identifier if zero is passed)

https://bugs.winehq.org/show_bug.cgi?id=41377

--- Comment #7 from Louis Lenders  ---
Created attachment 60922
  --> https://bugs.winehq.org/attachment.cgi?id=60922
added a few simple tests for SetThreadUILanguage

added a few simple tests for SetThreadUILanguage

[Bug 41377] Windows 10 DISM fails to find its resources ( kernel32 SetThreadUILanguage must return non-zero/ best fit language identifier if zero is passed)

https://bugs.winehq.org/show_bug.cgi?id=41377

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |e0f9ff9eb003211ce4fa436b739
                   |                            |8851f06e46293
         Resolution|---                         |FIXED

--- Comment #8 from Louis Lenders  ---
fixed by e0f9ff9eb003211ce4fa436b7398851f06e46293

[Bug 41377] Windows 10 DISM fails to find its resources ( kernel32 SetThreadUILanguage must return non-zero/ best fit language identifier if zero is passed)

https://bugs.winehq.org/show_bug.cgi?id=41377

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 3.6.

[Bug 41377] Windows 10 DISM fails to find its resources ( kernel32 SetThreadUILanguage must return non-zero/ best fit language identifier if zero is passed)

https://bugs.winehq.org/show_bug.cgi?id=41377

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.0.x

[Bug 41377] Windows 10 DISM fails to find its resources ( kernel32 SetThreadUILanguage must return non-zero/ best fit language identifier if zero is passed)

https://bugs.winehq.org/show_bug.cgi?id=41377

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.0.x                       |---

--- Comment #10 from Michael Stefaniuc  ---
Removing the 3.0.x milestone from bugs included in 3.0.2.