[Bug 48374] New: Divinity: Original Sin 2 - Icons in inventory are invisible (...again!) - wine-bugs

List overview All Threads

newer

[Bug 48374] New: Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

older

[Bug 12359] New: Express Rip can't...

[Bug 14715] New: TopStyle can't...

WineHQ Bugzilla

28 Dec 2019 28 Dec '19

10 a.m.

https://bugs.winehq.org/show_bug.cgi?id=48374

Bug ID: 48374 Summary: Divinity: Original Sin 2 - Icons in inventory are invisible (...again!) Product: Wine Version: 5.0-rc3 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs@winehq.org Reporter: apmichalopoulos@outlook.com Distribution: ---

Unfortunately, commit 27b9a420ea87fd85c0c933b7db77a9efb22f94cf "msvcrt: Fix [str|wcs]tod result being compared against FLT_MAX." reintroduces the buggy behavior described in https://bugs.winehq.org/show_bug.cgi?id=48180 .

As a first step I've included two tracelogs of WINEDEBUG=+msvcrt, the first one is running Wine built with the problematic commit while the second one is running Wine built with the immediately previous commit.

For anything else that may be needed (e.g. +relay tracelogs, as mentioned in the previous bug thread) I'm ready and willing :)

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Show replies by date

WineHQ Bugzilla

28 Dec 28 Dec

10:04 a.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

--- Comment #1 from Alexander Milos apmichalopoulos@outlook.com --- WINEDEBUG=+msvcrt @ 27b9a420ea87fd85c0c933b7db77a9efb22f94cf (bug is present)

https://ufile.io/zkyuuq2b

WINEDEBUG=+msvcrt @ 1b5f14d73285aaaa3982a3d8171680df85a04840 (bug is NOT present)

https://ufile.io/811s02j3

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:05 a.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

Alexander Milos apmichalopoulos@outlook.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

30 Dec 30 Dec

3:24 p.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

Gijs Vermeulen gijsvrm@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

3:38 p.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

--- Comment #2 from Erich E. Hoover erich.e.hoover@gmail.com --- Can you try Piotr's new solution?: https://source.winehq.org/patches/data/176192

It should be a much better way to solve this problem.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

2 Jan 2 Jan

2:07 a.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

--- Comment #3 from Alexander Milos apmichalopoulos@outlook.com --- If I'm not mistaken, this patch is already merged with 5034d109e033fbe820829ae43adba0cc30bf9b99, right? If so, I just tried with the latest master and unfortunately it's a no go. Though reverting that commit along with 27b9a420ea87fd85c0c933b7db77a9efb22f94cf (trying to revert only the latter produces conflicts of a kind that I'm pretty certain I shouldn't even try to resolve, so I'm forced to revert both) still results in the issue being "fixed".

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

1:15 p.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

--- Comment #4 from Sven sven.wine@gmail.com --- Isn't that because wcstod also has to be fixed?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

2:12 p.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

--- Comment #5 from Alexander Milos apmichalopoulos@outlook.com --- Ah, you're right, this new patch only applies to strtod while the issue we're dealing with here has been more or less confirmed to be dependent on wcstod. Alright then, I'll keep an eye out and I'll test again as soon as wcstod is also patched.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4:13 p.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

--- Comment #6 from Erich E. Hoover erich.e.hoover@gmail.com --- (In reply to Alexander Milos from comment #5)

...

Ah, you're right, this new patch only applies to strtod while the issue we're dealing with here has been more or less confirmed to be dependent on wcstod. Alright then, I'll keep an eye out and I'll test again as soon as wcstod is also patched.

Sorry about that, what I meant to say was to use that same code in wcstod. Please try applying these two patches: [1] https://source.winehq.org/patches/data/176267 [2] https://source.winehq.org/patches/data/176268

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

10:07 p.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

--- Comment #7 from Erich E. Hoover erich.e.hoover@gmail.com --- (In reply to Erich E. Hoover from comment #6)

...

... Please try applying these two patches: [1] https://source.winehq.org/patches/data/176267 [2] https://source.winehq.org/patches/data/176268

These were committed today, so you should be able to just update.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

3 Jan 3 Jan

11:05 a.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

--- Comment #8 from Alexander Milos apmichalopoulos@outlook.com --- No need to be sorry, especially when you've been putting so much work into solving this. As to the patches themselves, with the latest master everything is working properly so this bug can be marked as fixed. Once again, thank you for your work.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

2:40 p.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

Piotr Caban piotr.caban@gmail.com changed:

--- Comment #9 from Piotr Caban piotr.caban@gmail.com --- Marking as fixed.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

9:25 p.m.

New subject: [Bug 48374] Divinity: Original Sin 2 - Icons in inventory are invisible (...again!)

https://bugs.winehq.org/show_bug.cgi?id=48374

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #10 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.0-rc4.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1814

Age (days ago)

1820

Last active (days ago)

wine-bugs@winehq.org

12 comments

1 participants

tags (0)

participants (1)

WineHQ Bugzilla