[Bug 36784] New: valgrind shows a leak in kernel32/tests/thread.c

https://bugs.winehq.org/show_bug.cgi?id=36784

Bug ID: 36784
           Summary: valgrind shows a leak in kernel32/tests/thread.c
           Product: Wine
           Version: 1.7.20
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]

==27947== 68 bytes in 1 blocks are definitely lost in loss record 137 of 285
==27947==    at 0x7BC49369: notify_alloc (heap.c:255)
==27947==    by 0x7BC4D59F: RtlAllocateHeap (heap.c:1716)
==27947==    by 0x7BC31C49: RtlCreateActivationContext (actctx.c:4506)
==27947==    by 0x7B827493: CreateActCtxW (actctx.c:124)
==27947==    by 0x4E368BD: test_create (thread.c:1521)
==27947==    by 0x4E36BE1: test_thread_actctx (thread.c:1554)
==27947==    by 0x4E378A0: func_thread (thread.c:1772)
==27947==    by 0x4E537EE: run_test (test.h:584)
==27947==    by 0x4E53BBA: main (test.h:654)
==27947==

separate from 36782

[Bug 36784] valgrind shows a leak in kernel32/tests/thread.c

http://bugs.winehq.org/show_bug.cgi?id=36784

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Sebastian Lackner  ---
Created attachment 48855
  --> http://bugs.winehq.org/attachment.cgi?id=48855
kernel32/tests: Add missing ReleaseActCtx() calls.

If I didn't mess up the number of ReleaseActCtx() calls, this should fix it ;)

[Bug 36784] valgrind shows a leak in kernel32/tests/thread.c

https://bugs.winehq.org/show_bug.cgi?id=36784

--- Comment #2 from Austin English  ---
With the patch:
==29913== 68 bytes in 1 blocks are definitely lost in loss record 137 of 285
==29913==    at 0x7BC49369: notify_alloc (heap.c:255)
==29913==    by 0x7BC4D59F: RtlAllocateHeap (heap.c:1716)
==29913==    by 0x7BC31C49: RtlCreateActivationContext (actctx.c:4506)
==29913==    by 0x7B827493: CreateActCtxW (actctx.c:124)
==29913==    by 0x4E368BD: test_create (thread.c:1521)
==29913==    by 0x4E36BE1: test_thread_actctx (thread.c:1554)
==29913==    by 0x4E378E8: func_thread (thread.c:1777)
==29913==    by 0x4E53836: run_test (test.h:584)
==29913==    by 0x4E53C02: main (test.h:654)
==29913==

[Bug 36784] valgrind shows a leak in kernel32/tests/thread.c

https://bugs.winehq.org/show_bug.cgi?id=36784

--- Comment #3 from Sebastian Lackner  ---
Created attachment 48862
  --> https://bugs.winehq.org/attachment.cgi?id=48862
ntdll: Avoid leaking activation context in RtlCreateUserThread.

Thanks for testing, seems like there are multiple problems involved. Please
test with _BOTH_ patches attached in this bug report and additionally this fix
which was already submitted: http://source.winehq.org/patches/data/105217

[Bug 36784] valgrind shows a leak in kernel32/tests/thread.c

https://bugs.winehq.org/show_bug.cgi?id=36784

--- Comment #4 from Austin English  ---
(In reply to Sebastian Lackner from comment #3)
> Created attachment 48862 [details]
> ntdll: Avoid leaking activation context in RtlCreateUserThread.
>
> Thanks for testing, seems like there are multiple problems involved. Please
> test with _BOTH_ patches attached in this bug report and additionally this
> fix which was already submitted: http://source.winehq.org/patches/data/105217

Works, thanks.

[Bug 36784] valgrind shows a leak in kernel32/tests/thread.c

https://bugs.winehq.org/show_bug.cgi?id=36784

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2fcecdb72e11b7adb03dc797c2c
                   |                            |cc60fcb487fcd
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Austin English  ---
https://source.winehq.org/git/wine.git/commitdiff/c936e505e515f685606a1104f3...
https://source.winehq.org/git/wine.git/commitdiff/2fcecdb72e11b7adb03dc797c2...

[Bug 36784] valgrind shows a leak in kernel32/tests/thread.c

https://bugs.winehq.org/show_bug.cgi?id=36784

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.21.