[Bug 47546] New: Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

Bug ID: 47546
           Summary: Touhou 14-17 experience Spell Name and Music Room text
                    issues starting in Wine 4.1
           Product: Wine
           Version: 4.1
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

Now that half a year has passed, I'm making sure that I test all of the
applications I maintain. In doing so, I came across a strange issue in Touhou
14-17 (Japanese version, but regardless of Locale) where Spell Card names do
not render properly and where when opening the music room, all of the text
spazzes and behaves incredibly strangely.

By checking Wine releases, I have isolated the regression to the period between
4.0 rc7 and 4.1, and the issue remains to this day in Wine 4.12.1

I have only tested a few of the games, but main series Touhou games from 14-17,
which all share the same core engine with minor adjustments, are all affected.
This issue doesn't seem to affect any other aspects of gameplay - for example,
although the Music Room text is glitchy, the actual functionality of the menus
and the playing of the tracks works as intended, leading me to believe that the
issue is exclusively a text rendering issue.

Unfortunately at the time I most likely cannot successfully compile wine and so
therefore cannot perform a regression test to isolate the commit responsible
for this regression. I will update this bug report as well a the affected
entries in the series as I continue my testing.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

--- Comment #1 from Andrew Fan  ---
I have recorded a video showing the issue in 4.0-rc7 and 4.1 with new Wine
Prefixes.

Refer to https://youtu.be/ao42Bby4z0w for the video.

Note that I test 4.0-rc7 first, and 4.1 afterwards. During the testing, I am
navigating the menus, though it is not immediately noticeable since sound was
not recorded.

I hope this sheds some light on the issue. Note that the issue only seems to
affect Japanese text at the moment, though this may be coincidental.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

Mokou  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Mokou  ---
This issue affects Touhou 11 as well. The offending commit appears to be
65956ae50a136fe8467a0332c7495f36617a16dc, reverting it makes the text render
correctly.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
    Regression SHA1|                            |65956ae50a136fe8467a0332c74
                   |                            |95f36617a16dc
     Ever confirmed|0                           |1

--- Comment #3 from Fabian Maurer  ---
Confirming regression and CCing original author.

commit 65956ae50a136fe8467a0332c7495f36617a16dc
Author: Paul Gofman 
Date:   Mon Jan 14 21:45:13 2019 +0100

d3dx9: Use {lock|unlock}_surface() in D3DXLoadSurfaceFromMemory().

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

--- Comment #4 from Andrew Fan  ---
(In reply to Mokou from comment #2)
> This issue affects Touhou 11 as well. The offending commit appears to be
> 65956ae50a136fe8467a0332c7495f36617a16dc, reverting it makes the text render
> correctly.

I am unable to replicate this (specifically the music room portion) on 4.12.1
for Touhou 11 (I tested both English and Japanese).

However, if reverting the commit fixes Touhou 14-17, then it is likely the
cause, though I cannot test it myself.

Could you also submit test data for Touhou 11 on the AppDB, or describe the
environment that you tested here? That might be potentially helpful.

On that note, I'm using macOS High Sierra 10.13.6, and I'm running the 64 bit
distribution of Wine from
https://dl.winehq.org/wine-builds/macosx/download.html

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

--- Comment #5 from Paul Gofman  ---
Created attachment 64995
  --> https://bugs.winehq.org/attachment.cgi?id=64995
d3dx9: Pass rectangle to {lock|unlock}_surface().

I hope the attached patch should be fixing it.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

--- Comment #6 from Mokou  ---
(In reply to Andrew Fan from comment #4)
> Could you also submit test data for Touhou 11 on the AppDB, or describe the
> environment that you tested here? That might be potentially helpful.

Submitted. It seems weird you couldn't reproduce it, though.

(In reply to Paul Gofman from comment #5)
> Created attachment 64995 [details]
> d3dx9: Pass rectangle to {lock|unlock}_surface().
>
> I hope the attached patch should be fixing it.

The attached patch fixes the issue, tested with Touhou 11 and 14.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

--- Comment #7 from Andrew Fan  ---
(In reply to Mokou from comment #6)
> Submitted. It seems weird you couldn't reproduce it, though.

Perhaps it's a macOS vs Linux issue? There may have been something with DirectX
allowing the text to render fine on macOS for the older engine (10-13) but not
on the newer engine (14-17), while it was broken on both for Linux?

Either way, when Wine 4.14 comes out I'll give it a test.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

--- Comment #8 from Paul Gofman  ---
(In reply to Andrew Fan from comment #7)
> (In reply to Mokou from comment #6)
> > Submitted. It seems weird you couldn't reproduce it, though.
>
> Perhaps it's a macOS vs Linux issue?

No, this is not specific to Mac OS or Linux. My guess is that you might be
having native d3dx override in your Wine prefix, this could be the reason you
don't see this.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

--- Comment #9 from Andrew Fan  ---
(In reply to Paul Gofman from comment #8)
> (In reply to Andrew Fan from comment #7)
> > (In reply to Mokou from comment #6)
> > > Submitted. It seems weird you couldn't reproduce it, though.
> >
> > Perhaps it's a macOS vs Linux issue?
>
> No, this is not specific to Mac OS or Linux. My guess is that you might be
> having native d3dx override in your Wine prefix, this could be the reason
> you don't see this.

Ah, that's right. A lot of older Touhou distributions come with DirectX 9
overrides. I have them up to Touhou 13, which aligns with what has occurred
here. I've accepted the bug link for Touhou 11 - it might be worth checking how
far back the issue occurs, in case 10, 12, and 13 also exhibit the behavior.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

--- Comment #10 from Paul Gofman  ---
> it might be worth checking
> how far back the issue occurs, in case 10, 12, and 13 also exhibit the
> behavior.

I am not sure if it is much useful in respect to this bug, the issue is clear
and will hopefully be fixed soon.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

--- Comment #11 from Paul Gofman  ---
Should be fixed by 378204527e1f42ed1373a0cd7356770d235e319d.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |378204527e1f42ed1373a0cd735
                   |                            |6770d235e319d
             Status|NEW                         |RESOLVED
          Component|-unknown                    |directx-d3dx9
         Resolution|---                         |FIXED

--- Comment #12 from Józef Kucia  ---
(In reply to Paul Gofman from comment #11)
> Should be fixed by 378204527e1f42ed1373a0cd7356770d235e319d.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  ---
Closing bugs fixed in 4.14.

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

https://bugs.winehq.org/show_bug.cgi?id=47546

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |4.0.x

[Bug 47546] Touhou 14-17 experience Spell Name and Music Room text issues starting in Wine 4.1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47546

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.x                       |---

--- Comment #14 from Michael Stefaniuc  ---
Removing the 4.0.x milestone from bug fixes included in 4.0.3.