[Bug 22809] New: SUPERAntiSpyware displays crash handler when Preferences button is clicked

http://bugs.winehq.org/show_bug.cgi?id=22809

Summary: SUPERAntiSpyware displays crash handler when
                    Preferences button is clicked
           Product: Wine
           Version: 1.2-rc1
          Platform: x86
               URL: http://www.technicalbloke.com/sas_ols.exe
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: ole32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=28164)
 --> (http://bugs.winehq.org/attachment.cgi?id=28164)
SUPERAntiSpyware winedbg first-chance exception backtrace

As described in bug 21061, clicking the Preferences button in the
SUPERAntiSpyware window causes a SUPERAntiSpyware Error Report window to be
displayed. Anastasius Focht suggests that the crash is related to the ole32
storage code, which seems to be substantiated by a captured backtrace and trace
log. The relevant files are attached.

[Bug 22809] SUPERAntiSpyware displays crash handler when Preferences button is clicked

http://bugs.winehq.org/show_bug.cgi?id=22809

--- Comment #1 from Andrew Nguyen   2010-05-21 20:26:43 ---
Created an attachment (id=28165)
 --> (http://bugs.winehq.org/attachment.cgi?id=28165)
SUPERAntiSpyware +storage,+seh,+tid log

[Bug 22809] SUPERAntiSpyware displays crash handler when Preferences button is clicked

http://bugs.winehq.org/show_bug.cgi?id=22809

--- Comment #2 from Juan Lang   2010-05-22 12:44:01 ---
> From your log:

002a:trace:storage:PropertyStorage_ReadDictionary Reading entry with ID
0x00000010, 3145778 bytes

And from stg_prop.c:
* FIXME: there isn't any checking whether the read property extends past the
* end of the buffer.

Oops :/

Also, shortly before that:
002a:warn:storage:PropertyStorage_ReadProperty Unicode string has odd number of
bytes

The warning basically indicates that something is likely to go bad shortly
thereafter, because the code isn't sure what to do in this case.  (I wrote it,
and I'm not either.)

[Bug 22809] SUPERAntiSpyware displays crash handler when Preferences button is clicked

http://bugs.winehq.org/show_bug.cgi?id=22809

--- Comment #3 from Juan Lang   2010-05-24 12:40:56 ---
Created an attachment (id=28243)
 --> (http://bugs.winehq.org/attachment.cgi?id=28243)
Patch: Only read known format ids when attempting to read summary information

This patch fixes the crash.  It's sort of a lame attempt, though, because I
really should test how ole32 behaves with unknown format ids.  The file
SASRESPAIRS.STG has the format id {d5f98878-191b-4453-bcf5-a1560328da3a}, and I
don't know what format that's supposed to be in.

[Bug 22809] SUPERAntiSpyware displays crash handler when Preferences button is clicked

http://bugs.winehq.org/show_bug.cgi?id=22809

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 22809] SUPERAntiSpyware displays crash handler when Preferences button is clicked

http://bugs.winehq.org/show_bug.cgi?id=22809

--- Comment #4 from Andrew Nguyen   2010-05-24 12:56:24 ---
Indeed, the patch does resolve the patch, thanks!

[Bug 22809] SUPERAntiSpyware displays crash handler when Preferences button is clicked

http://bugs.winehq.org/show_bug.cgi?id=22809

--- Comment #5 from Juan Lang   2010-05-24 15:29:07 ---
I added some tests to help bolster the patch a bit:
http://www.winehq.org/pipermail/wine-patches/2010-May/088910.html
http://www.winehq.org/pipermail/wine-patches/2010-May/088908.html

[Bug 22809] SUPERAntiSpyware displays crash handler when Preferences button is clicked

http://bugs.winehq.org/show_bug.cgi?id=22809

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Juan Lang   2010-05-25 12:15:12 ---
Fixed by commit c94b2687d223100300b61628a77fe942e4f42121.

[Bug 22809] SUPERAntiSpyware displays crash handler when Preferences button is clicked

http://bugs.winehq.org/show_bug.cgi?id=22809

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2010-05-28 12:51:58 ---
Closing bugs fixed in 1.2-rc2.