[Bug 29967] New: Cyberboard Player hangs when opening a game

http://bugs.winehq.org/show_bug.cgi?id=29967

Bug #: 29967
           Summary: Cyberboard Player hangs when opening a game
           Product: Wine
           Version: 1.3.36
          Platform: x86
               URL: http://cyberboard.brainiac.com/cyberboardv310.exe
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
            Blocks: 23225
    Classification: Unclassified
   Regression SHA1: 579afe5cc6ffd661b1802c42ae2adf17dbfcedc8

Created attachment 39007
  --> http://bugs.winehq.org/attachment.cgi?id=39007
winedbg backtrace

I came across the problem when testing bug #23225.

Steps to reproduce the problem:
1. Install Cyberboard, then start it with CBPlayer.exe.
2. "File" -> "Open" -> "GenericGame.gam". At that point the application
freezes.

Nothing relevant in the terminal.
The attached backtrace was created with wine-1.4-rc4-31-gf43f37d.

This is a regression caused by

579afe5cc6ffd661b1802c42ae2adf17dbfcedc8 is the first bad commit
commit 579afe5cc6ffd661b1802c42ae2adf17dbfcedc8
Author: Alexandre Julliard 
Date:   Thu Dec 29 09:57:58 2011 +0100

gdi32: Implement PolyPolygon in the DIB driver.

:040000 040000 5d2ceff77fe209eb9e185dbafa9b15754ed61155
91a9ad1dc5873b198973190b34e66970fa39996b M    dlls

git checkout 579afe5cc6ffd661b1802c42ae2adf17dbfcedc8   >>the application hangs
git reset --hard HEAD^  >>the application opens the game normally

[Bug 29967] Cyberboard Player hangs when opening a game

http://bugs.winehq.org/show_bug.cgi?id=29967

--- Comment #1 from Alexandre Julliard  2012-02-21 14:00:37 CST ---
Created attachment 39008
  --> http://bugs.winehq.org/attachment.cgi?id=39008
quick and dirty fix

The app is passing garbage coords to Polygon which cause an overflow in
clip_line().

[Bug 29967] Cyberboard Player hangs when opening a game

http://bugs.winehq.org/show_bug.cgi?id=29967

Huw Davies  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Huw Davies  2012-02-22 03:44:14 CST ---
The overflow case is tricky, the quick and dirty fix is probably good enough
for now.  I'll look at this more after 1.4

[Bug 29967] Cyberboard Player hangs when opening a game

http://bugs.winehq.org/show_bug.cgi?id=29967

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |556267bde446412741e5c209d40
                   |                            |90f4a3761e03f
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Alexandre Julliard  2012-02-22 14:28:13 CST ---
Committed as 556267bde446412741e5c209d4090f4a3761e03f.

[Bug 29967] Cyberboard Player hangs when opening a game

http://bugs.winehq.org/show_bug.cgi?id=29967

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2012-02-24 12:48:19 CST ---
Closing bugs fixed in 1.4-rc5.