[Bug 44168] New: Wizardry 8 hangs when starting a new game or loading a saved game

https://bugs.winehq.org/show_bug.cgi?id=44168

Bug ID: 44168
           Summary: Wizardry 8 hangs when starting a new game or loading a
                    saved game
           Product: Wine
           Version: 3.0-rc1
          Hardware: x86
               URL: https://www.fileplanet.com/81227/80000/fileinfo/Wizard
                    ry-8-Demo
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: ee33d38c5041a8293c64257801572d1c742b0aba
      Distribution: ---

Created attachment 59933
  --> https://bugs.winehq.org/attachment.cgi?id=59933
terminal output

I tested this bug with the GOG.com version of the game, but it can be
reproduced with the demo version, too.
The demo contains only a sample save game but that will do to reproduce the
bug.

The game becomes unresponsive when I start a new game (after the party
selection and intro video), or when I try to load a previously saved game. The
game executable constantly pegging the CPU at 100% and the game needs to be
closed forcibly.

To reproduce the problem in the demo:
1. Install the demo and start Wiz8.exe. On first launch the game configuration
window will appear (requires mfc42.dll). Just accept the default settings and
get in the game.
2. In the menu select load game and choose the only available save game the
demo offers --> the game hangs for good.

Reverting the following commit fixes the problem for me:

commit ee33d38c5041a8293c64257801572d1c742b0aba
Author: Piotr Caban 
Date:   Mon Nov 27 20:29:44 2017 +0100

msvcrt: Call cdecl functions with empty FPU stack in _CI* functions.

The FPU stack should be empty on cdecl function call. Failing to do so
    breaks GCC 6.4.0 -O2 optimized code.

Using native msvcrt.dll also works around the problem (winetricks vcrun6).
I'm on Arch Linux (64-bit) and gcc version is: gcc version 7.2.1 20171128 (GCC)
I compiled Wine without compiler optimizations '-O0  -g' but that didn't solve
the problem.

wine-3.0-rc1-23-g081eae7ac3

Wiz8NetDemoEB.exe (143M)
md5sum: 728f87e9768102c71017675a1bb06425

[Bug 44168] Wizardry 8 hangs when starting a new game or loading a saved game

https://bugs.winehq.org/show_bug.cgi?id=44168

--- Comment #1 from Béla Gyebrószki  ---
I came across a different kind of issue caused by the very same commit in
another game, maybe it should be reported in a separate bug?
In the game Original War the opening videos have messed up colors and they're
heavily pixelated. Other than that, the game seems to function properly.

Wine-3.0-rc2

[Bug 44168] Wizardry 8 hangs when starting a new game or loading a saved game

https://bugs.winehq.org/show_bug.cgi?id=44168

--- Comment #2 from Piotr Caban  ---
(In reply to Béla Gyebrószki from comment #1)
> I came across a different kind of issue caused by the very same commit in
> another game, maybe it should be reported in a separate bug?

I've sent a patch that fixes Wizardry 8 demo. Please report a separate bug if
it doesn't fix the other game (https://source.winehq.org/patches/data/139657).

[Bug 44168] Wizardry 8 hangs when starting a new game or loading a saved game

https://bugs.winehq.org/show_bug.cgi?id=44168

--- Comment #3 from Béla Gyebrószki  ---
(In reply to Piotr Caban from comment #2)
> (In reply to Béla Gyebrószki from comment #1)
> > I came across a different kind of issue caused by the very same commit in
> > another game, maybe it should be reported in a separate bug?
>
> I've sent a patch that fixes Wizardry 8 demo. Please report a separate bug
> if it doesn't fix the other game
> (https://source.winehq.org/patches/data/139657).

The patch fixes both issues.

[Bug 44168] Wizardry 8 hangs when starting a new game or loading a saved game

https://bugs.winehq.org/show_bug.cgi?id=44168

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |22edbd849ada33e8037f6f2b7fd
                   |                            |e75b1617f3f78
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Béla Gyebrószki  ---
Fixed with
https://source.winehq.org/git/wine.git/commit/22edbd849ada33e8037f6f2b7fde75...

[Bug 44168] Wizardry 8 hangs when starting a new game or loading a saved game

https://bugs.winehq.org/show_bug.cgi?id=44168

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 3.0-rc3.

[Bug 44168] Wizardry 8 hangs when starting a new game or loading a saved game

https://bugs.winehq.org/show_bug.cgi?id=44168

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x

[Bug 44168] Wizardry 8 hangs when starting a new game or loading a saved game

https://bugs.winehq.org/show_bug.cgi?id=44168

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #6 from Michael Stefaniuc  ---
Removing the 2.0.x milestone from bugs included in 2.0.5.