[Bug 19074] New: Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

Summary: Error message "Module not found" should be more
                    obvious
           Product: Wine
           Version: 1.1.21
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: integration
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

On multiple occasions, I have seen users open a terminal and attempt to run
their application by typing something like "wine itunes.exe"

Wine then looks in the current folder (where it isn't), then looks in its
system32 folder (where it also isn't), and then outputs this message:

wine: could not load L"C:\windows\system32\itunes.exe": Module not found

I suggest changing this error message to something clearer based on what the
typical error here, something like:

wine: could not load "itunes.exe": the specified program was not found in the
current directory

This message is more specific to the problem, and more importantly it tells the
user (even a clueless new terminal user) that they need to change the current
directory.  So rather than saying "Wine's broken" and making a bad post on a
forum/bug tracker, they'll instead look up how to change a directory in the
terminal.

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #1 from Austin English   2009-06-24 22:23:53 ---
Patch sent:
http://www.winehq.org/pipermail/wine-patches/2009-June/074810.html

though you probably could've done the same in less time than it took to file
the bug ;-).

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

--- Comment #2 from Scott Ritchie   2009-06-24 23:12:27 ---
True, although my internet is rather slow here and I don't have git checked out
in this install ;)

Regardless, thanks!

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|download, integration       |
           Severity|normal                      |enhancement

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

--- Comment #3 from Dmitry Timoshkov   2009-06-25 07:07:54 ---
ERROR_MOD_NOT_FOUND clearly corresponds to the "Module not found" error
message. Moreover 'current directory' is wrong, Wine searches full PATH
for a program.

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

--- Comment #4 from Austin English   2009-06-25 16:49:28 ---
We could use window's message:
C:\Documents and Settings\austin>foobar
'foobar' is not recognized as an internal or external command,
operable program or batch file.

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

--- Comment #5 from Dmitry Timoshkov   2009-06-25 23:19:55 ---
(In reply to comment #4)
> We could use window's message:
> C:\Documents and Settings\austin>foobar
> 'foobar' is not recognized as an internal or external command,
> operable program or batch file.

This is what cmd.exe reports. cmd.exe in Wine reports "File not found",
and that's a different problem.

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

--- Comment #6 from Scott Ritchie   2009-06-26 01:30:08 ---
The usual place (and reason) for a user seeing this error is the program not
being in the current directory - although you are right that we search the full
PATH (as well as the system32 folder).  Perhaps:

wine: could not load "itunes.exe": the specified program was not found in the
current directory or system path

Windows error message unfortunately appears just as unhelpful (not telling you
"wrong directory")

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

--- Comment #7 from Dmitry Timoshkov   2009-06-26 03:43:14 ---
(In reply to comment #6)
> Windows error message unfortunately appears just as unhelpful (not telling you
> "wrong directory")

This "wrong directory" thing is completely misleading. Try for instance
run 'foobar' from an xterm, you will get "command not found". Why Wine
error message should look differently?

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

--- Comment #8 from Austin English   2009-06-26 10:58:57 ---
(In reply to comment #7)
> (In reply to comment #6)
> > Windows error message unfortunately appears just as unhelpful (not telling you
> > "wrong directory")
>
> This "wrong directory" thing is completely misleading. Try for instance
> run 'foobar' from an xterm, you will get "command not found".

And if you're running on Ubuntu/OpenSuse/others with 'command-not-found'
installed (it is by default), most missing packages will give you helpful
advice:
http://packages.ubuntu.com/jaunty/command-not-found

e.g.,:
$ evolution
The program ‘evolution’ can be found in the following package:
* evolution [ path: /usr/bin/evolution, repository: zypp (OSS_11.1_Factory) ]
Try: sudo zypper install evolution
bash: evolution: command not found
> Why Wine error message should look differently?

Wine is inherently a different program than most. It's not a pure native unix
program, and doesn't behave like one for many other things. A simple message
like 'the specified program was not found in the current directory or system
path', as Scott suggested, gives the user an idea of what's wrong, before
filing invalid bugs about it (we've seen a few here before, and the forums get
it quite a bit).

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #9 from Austin English   2010-06-04 15:17:04 ---
Still present.

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Jerome Leclanche  2011-04-01 09:47:28 CDT ---
(In reply to comment #9)
> Still present.

wine: cannot find L"C:\windows\system32\test.exe"

Fixed i guess. Or is that still unclear?

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Austin English  2012-03-14 07:58:57 CDT ---
(In reply to comment #10)
> (In reply to comment #9)
> > Still present.
>
> wine: cannot find L"C:\windows\system32\test.exe"
>
> Fixed i guess. Or is that still unclear?

Fine by me, haven't heard any complaints lately.

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

--- Comment #12 from Alexandre Julliard  2012-03-16 14:09:06 CDT ---
Closing bugs fixed in 1.5.0.

[Bug 19074] Error message "Module not found" should be more obvious

http://bugs.winehq.org/show_bug.cgi?id=19074

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  2012-03-16 17:11:31 CDT ---
Really closing bugs fixed in 1.5.0.