[Bug 34190] New: number.c could not compile due to "dtoa" naming conflict

http://bugs.winehq.org/show_bug.cgi?id=34190

Bug #: 34190
           Summary: number.c could not compile due to "dtoa" naming
                    conflict
           Product: Wine
           Version: 1.6
          Platform: x86-64
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P2
         Component: jscript
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

dlls/jscript/number.c could not compile on Cygwin (on Windows 7) due to a
naming conflict of name "dtoa". Apparently the name "dtoa" was already used in
wine/port.h

I was able to fix this issue and compile Wine properly by renaming all
instances of "dtoa" and "DTOA" to "dtoaa" and "DTOAA", respectively, in the
number.c file.

[Bug 34190] number.c could not compile due to "dtoa" naming conflict

http://bugs.winehq.org/show_bug.cgi?id=34190

Jasper Danielson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal

[Bug 34190] number.c could not compile due to "dtoa" naming conflict in Cygwin

http://bugs.winehq.org/show_bug.cgi?id=34190

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
          Component|jscript                     |build-env
            Summary|number.c could not compile  |number.c could not compile
                   |due to "dtoa" naming        |due to "dtoa" naming
                   |conflict                    |conflict in Cygwin
     Ever Confirmed|0                           |1

--- Comment #1 from Ken Sharp  2013-08-03 10:56:29 CDT ---
Confirming.

[Bug 34190] number.c could not compile due to "dtoa" naming conflict in Cygwin

http://bugs.winehq.org/show_bug.cgi?id=34190

--- Comment #2 from Ken Sharp  2013-08-03 10:59:52 CDT ---
..except it's not defined in Wine's port.h it's inherited and defined in
Cygwin's stdlib.h

http://forum.winehq.org/viewtopic.php?f=2&t=19501

[Bug 34190] number.c could not compile due to "dtoa" naming conflict in Cygwin

http://bugs.winehq.org/show_bug.cgi?id=34190

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Ken Sharp  2013-08-05 07:11:11 CDT ---
http://www.winehq.org/pipermail/wine-patches/2013-August/125701.html
http://source.winehq.org/patches/data/97774

Thanks Piotr :)

[Bug 34190] number.c could not compile due to "dtoa" naming conflict in Cygwin

http://bugs.winehq.org/show_bug.cgi?id=34190

--- Comment #4 from Austin English  2013-08-15 13:31:45 CDT ---
http://source.winehq.org/git/wine.git/commitdiff/2e752a115ac814fc252af592d01...

please retest

[Bug 34190] number.c could not compile due to "dtoa" naming conflict in Cygwin

http://bugs.winehq.org/show_bug.cgi?id=34190

Jasper Danielson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Jasper Danielson  2013-08-15 13:47:30 CDT ---
The number.c file now compiles with no problems, thank you.

[Bug 34190] number.c could not compile due to "dtoa" naming conflict in Cygwin

http://bugs.winehq.org/show_bug.cgi?id=34190

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2e752a115ac814fc252af592d01
                   |                            |c816b34e96cb0

[Bug 34190] number.c could not compile due to "dtoa" naming conflict in Cygwin

http://bugs.winehq.org/show_bug.cgi?id=34190

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2013-08-30 13:05:20 CDT ---
Closing bugs fixed in 1.7.1.

[Bug 34190] number.c could not compile due to "dtoa" naming conflict in Cygwin

http://bugs.winehq.org/show_bug.cgi?id=34190

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.6.x

[Bug 34190] number.c could not compile due to "dtoa" naming conflict in Cygwin

http://bugs.winehq.org/show_bug.cgi?id=34190

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.6.x                       |---

--- Comment #7 from Alexandre Julliard  2013-11-15 13:39:54 CST ---
Removing 1.6.x milestone from bugs included in 1.6.1.