[Bug 14891] New: Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

Summary: Bitmaps with offset bits do not display correctly
           Product: Wine
           Version: CVS/GIT
          Platform: PC
               URL: http://entropymine.com/jason/bmpsuite/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=15458)
 --> (http://bugs.winehq.org/attachment.cgi?id=15458)
program to load a bitmap from command line, display on screen

I was hunting around for small windows programs to display bitmaps via GDI so
that I could test the bitmap display code in Wine (to follow an afterthought I
had relating to bug 14868). Since I wasn't able to find anything, I decided to
write my own (attached), then run it through Jason Summers' bitmap test suite
(http://entropymine.com/jason/bmpsuite/reference/reference.html). One of these
bitmaps failed the test (g08offs.bmp), appearing different to the reference
image. According to the reference page, the "... bfOffBits in [the] header not
set to the usual value. There are 100 extra unused bytes between palette and
bits."

The program has been compiled with mingw32 (Version 4.2.1.dfsg-1) on a Debian
system (see Makefile for full parameters etc.).

Running Wine off a git branch pulled ~1.5 days ago, with patch from bug 14868.

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

--- Comment #1 from David Hall (gringer)   2008-08-17 02:02:36 ---
Created an attachment (id=15459)
 --> (http://bugs.winehq.org/attachment.cgi?id=15459)
bitmap display with offset pixels

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

--- Comment #2 from David Hall (gringer)   2008-08-17 02:05:37 ---
Created an attachment (id=15460)
 --> (http://bugs.winehq.org/attachment.cgi?id=15460)
What it should look like (test run on a different reference bitmap)

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

--- Comment #3 from David Hall (gringer)   2008-12-09 05:42:36 ---
Dmitry, I see that you have recently changed the Version from CVS/GIT to
unspecified. I'd like to point you to the last sentence of my initial post:

"Running Wine off a git branch pulled ~1.5 days ago, with patch from bug
14868."

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Dmitry Timoshkov   2008-12-09 06:07:22 ---
CVS/GIT version tag is deprecated, we need to know exact version which
shows the problem at the time the bug was reported.

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

Luke Benstead  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Luke Benstead   2009-08-16 02:28:49 ---
Still present in 1.1.27.

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

--- Comment #6 from Wolfram Sang   2010-04-06 04:59:37 ---
Created an attachment (id=27234)
 --> (http://bugs.winehq.org/attachment.cgi?id=27234)
Patch to take offsets into account in BITMAP_Load

I sent this patch to wine-patches today.

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

Wolfram Sang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Wolfram Sang   2010-05-10 18:51:45 ---
Extended version of the patch accepted \o/ Fixed with commit
f76a3b965c5c5440e2302b86e6b705d590cd23d1.

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Dmitry Timoshkov   2010-05-10 23:07:44 ---
Fixed then.

[Bug 14891] Bitmaps with offset bits do not display correctly

http://bugs.winehq.org/show_bug.cgi?id=14891

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2010-05-21 14:38:55 ---
Closing bugs fixed in 1.2-rc1.