[Bug 31768] New: Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

Bug #: 31768
           Summary: Starcraft: Brood War loses mouse focus when using
                    ICCup's W-Mode plugin
           Product: Wine
           Version: 1.5.13
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified
   Regression SHA1: ff60249cab238bed124b98a7624ccfe415f8648e

Created attachment 41801
  --> http://bugs.winehq.org/attachment.cgi?id=41801
Smallest portion of ff60249cab238bed124b98a7624ccfe415f8648e that causes my
regression

When running Starcraft: Brood War via ICCup's launcher with the W-Mode plugin
enabled the mouse grab functionality (Alt+F1) no longer works as of wine-1.5.11
(the last working version was wine-1.5.10).  I tested with wine-1.5.12 and
wine-1.5.13, neither of which solves the problem.

I used git-bisect to track down this regression to commit 
f60249cab238bed124b98a7624ccfe415f8648e.  I don't really understand any of this
patch, but I found that reverting that commit does fix the regression I'm
experiencing.

I then messed around with the offending commit a bit and discovered that
reverting a single line is sufficient to fix the regression for me.  I've
attached that single line patch, which applies against the current git head. 
Like I said, I know nothing about this code so my fix is probably wrong. 
Hopefully someone who understands the problem will be able to come up with a
proper fix :).

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

--- Comment #1 from Alexandre Julliard  2012-09-25 03:18:15 CDT ---
Please attach the output of "xinput --list --long".

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

--- Comment #2 from Palmer Dabbelt  2012-09-25 09:42:53 CDT ---
Created attachment 41822
  --> http://bugs.winehq.org/attachment.cgi?id=41822
xinput --list --long

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

--- Comment #3 from Alexandre Julliard  2012-09-25 11:00:36 CDT ---
Looks like your mouse driver doesn't set any labels at all. What system is
that?

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

--- Comment #4 from Palmer Dabbelt  2012-09-25 11:10:31 CDT ---
(In reply to comment #3)
> Looks like your mouse driver doesn't set any labels at all. What system is
> that?

I run Gentoo with "x11-base/xorg-server-1.12.2" and "x11-apps/xinput-1.6.0". 
I'll also attach my xorg.conf in case that helps any.

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

--- Comment #5 from Palmer Dabbelt  2012-09-25 11:10:52 CDT ---
Created attachment 41825
  --> http://bugs.winehq.org/attachment.cgi?id=41825
/etc/X11/xorg.conf

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

--- Comment #6 from Alexandre Julliard  2012-09-25 12:23:53 CDT ---
Created attachment 41826
  --> http://bugs.winehq.org/attachment.cgi?id=41826
workaround for broken drivers

Please give this a try.

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

--- Comment #7 from Palmer Dabbelt  2012-09-26 00:14:51 CDT ---
(In reply to comment #6)
> Created attachment 41826 [details]
> workaround for broken drivers
>
> Please give this a try.

Yes, with this patch Brood War works for me.

Thanks!

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |0a9398421ce3d5a57419d1c8582
                   |                            |d66ec31a31f91
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Alexandre Julliard  2012-09-26 14:08:36 CDT ---
Fixed by 0a9398421ce3d5a57419d1c8582d66ec31a31f91.

[Bug 31768] Starcraft: Brood War loses mouse focus when using ICCup's W-Mode plugin

http://bugs.winehq.org/show_bug.cgi?id=31768

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2012-09-28 13:43:09 CDT ---
Closing bugs fixed in 1.5.14.