[Bug 14509] New: RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

Summary: RegGetValue sometimes doesn't work properly
           Product: Wine
           Version: 1.1.1
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: advapi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=14835)
 --> (http://bugs.winehq.org/attachment.cgi?id=14835)
Solution for wrong behaviour of RegGetValue

While configuration "The Bat!" for Wine I found out a problem with
"RegGetValueA" and "RegGetValueA".
In case dwFlags contains the Bits (RRF_RT_REG_EXPAND_SZ | RRF_RT_REG_SZ) and
not the bit RRF_NOEXPAND the function will return ERROR_INVALID_PARAMETER. This
is wrong behaviour, because expansion will transform a result of type
RRF_RT_REG_EXPAND_SZ into RRF_RT_REG_SZ which satisfies the request.

This behaviour causes "The Bat!" to be unable to access some of its registry
settings, including the registration code. So it refuses to work after the
trial period expired and the code need to be entered manually every time the
program starts up.
Other programs may be affected ass well, especially because the flag RRF_RT_ANY
won't work.

I built a patch for wine 1.1.1 wich solves this issue. This patch applies to
advapi32.

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

Mathias Kosch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Difficulty|---                         |Minutes
           Keywords|                            |patch

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Difficulty|Minutes                     |---

--- Comment #1 from James Hawkins   2008-07-15 22:32:24 ---
Please send patches to wine-patches.  You're going to need to add a test case
for this change.

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

Joerg Schiermeier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |newsletter@Schiermeier-
                   |                            |Software.de

--- Comment #2 from Joerg Schiermeier   2008-07-19 13:29:31 ---
Hi Mathias!

Could you please tell use which version of 'The Bat!' is affected by this item?

Sincerely
Joerg Schiermeier

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

--- Comment #3 from Mathias Kosch   2008-07-19 15:29:19 ---
Hello Joerg!

This Problem causes Bug [1] (which has already been closed, maybe because it
doesn't affect older versions of "The Bat!"). However it is a little more
general.
According to [1] this it persists after "The Bat! v3.99.24".

I'm currently trying to hand in the patch, but formal mistakes are haunting me.

[1] http://bugs.winehq.org/show_bug.cgi?id=11335

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

Mathias Kosch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14835|0                           |1
        is obsolete|                            |

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

--- Comment #4 from Mathias Kosch   2008-07-19 15:34:27 ---
Sorry, I noticed that my previous mistake is still visible here.
This bug is related to "dwFlags" containing (lot less than) "RRF_RT_ALL".
Only the Bits (RRF_RT_REG_EXPAND_SZ | RRF_RT_REG_SZ) also lead to an error
return value under Windows.

I don't post the new patch since I already posted it to the mailing list.

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

--- Comment #5 from Joerg Schiermeier   2008-07-26 19:37:18 ---
Hi!

Is working since version 1.1.2. I saw it in 'The Bat! v4.0.26' - an email
client which had a lot of trouble with this bug. Now is working fine.

Sincerely
Joerg Schiermeier

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

Mathias Kosch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Mathias Kosch   2008-07-27 10:29:10 ---
Is working since version 1.1.2.

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2008-08-22 10:47:48 ---
Closing bugs fixed in 1.1.3.

[Bug 14509] RegGetValue sometimes doesn't work properly

http://bugs.winehq.org/show_bug.cgi?id=14509

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
         OS/Version|All                         |other

--- Comment #8 from Austin English  2012-02-23 15:11:09 CST ---
Removing deprecated 'All' Platform/OS.