[Bug 25684] New: 16 bit ole2 installer hangs

http://bugs.winehq.org/show_bug.cgi?id=25684

Summary: 16 bit ole2 installer hangs
           Product: Wine
           Version: 1.1.38
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=32716)
 --> (http://bugs.winehq.org/attachment.cgi?id=32716)
interesting threads from bt all

Happens with both 1.1.38 and current git.

To reproduce:

rm -rf ~/.wine
mkdir tmp
cd tmp
wget
http://download.microsoft.com/download/win31/update/2.03/win/en-us/ww1116.ex...
unzip ww1116.exe
wine setup.exe

After clicking ok, it hangs here with

err:ntdll:RtlpWaitForCriticalSection section 0x7eb29760 "syslevel.c:
Win16Mutex" wait timed out in thread 000b, blocked by 0021, retrying (60 sec)
err:ntdll:RtlpWaitForCriticalSection section 0x7efec7c4 "loader.c:
loader_section" wait timed out in thread 0021, blocked by 000b, retrying (60
sec)

and then eventually crashes.  
btall says the deadlocked threads are in TASK_ExitTask and LoadLibrary16.
I'll attach the deadlocked thread stacks.

[Bug 25684] 16 bit ole2 installer hangs

http://bugs.winehq.org/show_bug.cgi?id=25684

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://web.archive.org/web/
                   |                            |20060320000423/http://downl
                   |                            |oad.microsoft.com/download/
                   |                            |win31/update/2.03/win/en-us
                   |                            |/ww1116.exe
                 CC|                            |[e-mail]

[Bug 25684] 16 bit ole2 installer hangs

http://bugs.winehq.org/show_bug.cgi?id=25684

--- Comment #1 from Bruno Jesus  2013-07-17 21:14:20 CDT ---
Still in wine 1.6-rc5.

[Bug 25684] OLE v2.03 16bit (Win3.1 & 3.11): installer deadlocks

https://bugs.winehq.org/show_bug.cgi?id=25684

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|16 bit ole2 installer hangs |OLE v2.03 16bit (Win3.1 &
                   |                            |3.11): installer deadlocks

--- Comment #2 from Wylda  ---
Still present in wine-1.7.29. Installs corectly in WinXP.

[Bug 25684] OLE v2.03 16bit (Win3.1 & 3.11): installer deadlocks

https://bugs.winehq.org/show_bug.cgi?id=25684

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer, win16
                 CC|                            |[e-mail],
                   |                            |[e-mail]
          Component|-unknown                    |kernel32

--- Comment #3 from Béla Gyebrószki  ---
I can reproduce the problem in wine-1.7.43-166-g39d71c5

At the end of installation the installer hangs with
> err:ntdll:RtlpWaitForCriticalSection section 0x7ea7b7c0 "syslevel.c: Win16Mutex" wait timed out in thread 0028, blocked by 0022, retrying (60 sec)
> err:ntdll:RtlpWaitForCriticalSection section 0x7bcc9fc0 "loader.c: loader_section" wait timed out in thread 0022, blocked by 0028, retrying (60 sec)

If I run the installer on a single core ('taskset -c 0 wine setup.exe') then
installation ends properly.

Not sure if this counts as a regression, but according to my testing the
problem is present since
cd6295d276ec9c0b41bbe89b989281853578904b is the first bad commit
commit cd6295d276ec9c0b41bbe89b989281853578904b
Author: Alexandre Julliard 
Date:   Tue Feb 24 18:09:09 2009 +0100

kernel32: Add support for loading stand-alone 16-bit modules.

ww1116.exe
sha1: b803991c40f387464b61f606536b7c98a88245d2

[Bug 25684] OLE v2.03 16bit (Win3.1 & 3.11): installer deadlocks

https://bugs.winehq.org/show_bug.cgi?id=25684

--- Comment #4 from Alexandre Julliard  ---
Created attachment 51572
  --> https://bugs.winehq.org/attachment.cgi?id=51572
Release the Win16 lock when loading a 32-bit dll.

You could try something like this.

[Bug 25684] OLE v2.03 16bit (Win3.1 & 3.11): installer deadlocks

https://bugs.winehq.org/show_bug.cgi?id=25684

--- Comment #5 from Béla Gyebrószki  ---
(In reply to Alexandre Julliard from comment #4)
> Created attachment 51572 [details]
> Release the Win16 lock when loading a 32-bit dll.
>
> You could try something like this.

The patch fixes the issue here as well.

[Bug 25684] OLE v2.03 16bit (Win3.1 & 3.11): installer deadlocks

https://bugs.winehq.org/show_bug.cgi?id=25684

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3a2e7d1a3dbf42a0385e5c0f64d
                   |                            |79e9ea054252e
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Béla Gyebrószki  ---
Fixed with
http://source.winehq.org/git/wine.git/commit/3a2e7d1a3dbf42a0385e5c0f64d79e9...

[Bug 25684] OLE v2.03 16bit (Win3.1 & 3.11): installer deadlocks

https://bugs.winehq.org/show_bug.cgi?id=25684

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.44.