[Bug 15384] New: Incorrect behaviour when using BIF_RETURNONLYFSDIRS | BIF_BROWSEINCLUDEFILES
http://bugs.winehq.org/show_bug.cgi?id=15384
Summary: Incorrect behaviour when using BIF_RETURNONLYFSDIRS | BIF_BROWSEINCLUDEFILES Product: Wine Version: 1.0.0 Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: shell32 AssignedTo: wine-bugs@winehq.org ReportedBy: boris.seve@drillscan.com
When calling SHBrowseForFolder with both BIF_RETURNONLYFSDIRS and BIF_BROWSEINCLUDEFILES flags the 'Ok' button is incorrectly disabled when a file is selected (button is enabled however when a directory is selected)
If only the BIF_BROWSEINCLUDEFILES flag is set the 'Ok' button is correctly enabled when a file is selected.
AFAIK (and confirmed on Windows XP SP3) the 'Ok' should be enabled when a directory is selected AND when a file is selected if both flags are set.
This holds true whether BIF_NEWDIALOGSTYLE is set or not.
http://bugs.winehq.org/show_bug.cgi?id=15384
--- Comment #1 from Austin English austinenglish@gmail.com 2008-09-23 10:19:23 --- A testcase would be useful.
http://bugs.winehq.org/show_bug.cgi?id=15384
--- Comment #2 from boris.seve@drillscan.com 2008-09-24 02:04:59 --- Created an attachment (id=16244) --> (http://bugs.winehq.org/attachment.cgi?id=16244) Testcase for SHBrowseForFolder
http://bugs.winehq.org/show_bug.cgi?id=15384
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, testcase
http://bugs.winehq.org/show_bug.cgi?id=15384
--- Comment #3 from boris.seve@drillscan.com 2008-09-24 16:57:52 --- Created an attachment (id=16260) --> (http://bugs.winehq.org/attachment.cgi?id=16260) Patch proposition
http://bugs.winehq.org/show_bug.cgi?id=15384
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #4 from Austin English austinenglish@gmail.com 2008-09-24 19:10:59 --- Please send patches to wine-patches@winehq.org
http://bugs.winehq.org/show_bug.cgi?id=15384
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #5 from Dan Kegel dank@kegel.com 2008-09-25 08:05:21 --- Thanks! Can you recast your test case as a C program that renders a pass/fail judgement without human attention, and fits into our conformance test suite? See http://www.winehq.org/site/docs/winedev-guide/testing The test should probably live in a C file named dlls/shell32/tests/brsfolder.c. If your test needs to move or click the mouse, use the win32 functions to simulate user input. Then make sure the test passes on Windows XP and, with your patch, Wine.
Good luck! Which app is this for, by the way?
http://bugs.winehq.org/show_bug.cgi?id=15384
--- Comment #6 from boris.seve@drillscan.com 2008-10-03 09:17:06 --- I'm afraid my C is rusty at best. I'll see what I can do, but don't think I'll be able to deliver a proper testcase in a timely manner.
I've posted my patch proposition to wine-patches a few days ago but I'm not sure if it was deemed incorrect of if the lack of a proper testcase postponed it.
Which app is this for, by the way?
This is for a commercial scientific application written in Delphi (so I can't use libwine) not ported yet to non Windows OS.
http://bugs.winehq.org/show_bug.cgi?id=15384
--- Comment #7 from Dan Kegel dank@kegel.com 2008-10-03 09:27:59 --- OK, then let's do something simpler. How about writing a test program in Delphi that outputs pass or fail to standard output (or worst case, a file), without user intervention?
We can then translate that to C and insert it into our test suite.
http://bugs.winehq.org/show_bug.cgi?id=15384
--- Comment #8 from Austin English austinenglish@gmail.com 2010-06-04 01:06:38 --- In wine-1.2-rc2-111-g9aa9a12, I get:
- Nothing checked : Every directory is valid
- RETURNONLYFSDIRS checked : Real directories valid (Control Panel, Network Places... are invalid)
- BROWSEINCLUDEFILES checked : All directories AND files are valid
- Both RETURNONLYFSDIRS and BROWSEINCLUDEFILES : Real directories AND files are valid (With wine, files are not valid)
- NEWDIALOGSTYLE checked : No effect
so...fixed? I didn't check it against windows..
http://bugs.winehq.org/show_bug.cgi?id=15384
--- Comment #9 from boris.seve@drillscan.com 2010-06-04 03:44:26 --- I've just tested with rev. g9aa9a12 and the bug is still present.
Both RETURNONLYFSDIRS and BROWSEINCLUDEFILES : Real directories AND files are valid (With wine, files are not valid)
That's the problem. Files should also be valid.
http://bugs.winehq.org/show_bug.cgi?id=15384
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other
--- Comment #10 from Austin English austinenglish@gmail.com 2012-02-23 15:22:45 CST --- Removing deprecated 'All' Platform.
https://bugs.winehq.org/show_bug.cgi?id=15384
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #11 from Austin English austinenglish@gmail.com --- (In reply to boris.seve from comment #9)
I've just tested with rev. g9aa9a12 and the bug is still present.
Both RETURNONLYFSDIRS and BROWSEINCLUDEFILES : Real directories AND files are valid (With wine, files are not valid)
That's the problem. Files should also be valid.
Still in wine-1.7.19-70-gd6a59f7
https://bugs.winehq.org/show_bug.cgi?id=15384
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #12 from super_man@post.com --- - Nothing checked : Every directory is valid
- RETURNONLYFSDIRS checked : Real directories valid (Control Panel, Network Places... are invalid)
- BROWSEINCLUDEFILES checked : All directories AND files are valid
- Both RETURNONLYFSDIRS and BROWSEINCLUDEFILES : Real directories AND files are valid (With wine, files are not valid)
- NEWDIALOGSTYLE checked : No effect
wine 1.9
-
wine-bugs＠winehq.org