[Bug 39920] New: [REGRESSION] In Nanocad 5.1 the file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

Bug ID: 39920
           Summary: [REGRESSION] In Nanocad 5.1 the file open/import
                    dialog does not open
           Product: Wine
           Version: 1.9.0
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comdlg32
          Assignee: [e-mail]
          Reporter: [e-mail]
   Regression SHA1: bbf2cce16041e90d621a1f5889ea1bd760e21a0e
      Distribution: ---

Nanocad 5.0 works great with wine 1.4.1, but in wine 1.9.0.37 it's not possible
anymore to open or import file in NanoCad. That make the CAD useless.

I bisected the problem to commit:
[bbf2cce16041e90d621a1f5889ea1bd760e21a0e] comdlg32: Do not modify dialog
resource directly.

I reverted this commit on the latest wine (1.9.0.37) and that fixed my issue
with file open dialog.

Nanocad 5.0 is free and can be downloaded here:
ftp://ftp.nanocad.com/nanocad/nanoCAD50(2000).ZIP
or here
http://nanocad.com/page/DownloadNanoCAD
It can be used without registration/activation in Demo mode. This is enough to
reproduce the bug.

Steps to reproduce the problem:
1. Unpack zip archive into ~/nanocad5

2. Install prerequirements
WINEARCH=win32 WINEPREFIX=~/.wine/wine-test ./wine
~/nanocad5/PreReq/vcredist_x86.exe

3. Install nanoCad
WINEARCH=win32 WINEPREFIX=~/.wine/wine-test ./wine msiexec /i
~/nanocad5/nanoCAD.msi

4. Install nanoCad
WINEARCH=win32 WINEPREFIX=~/.wine/wine-test ./wine msiexec /i
~/nanocad5/nanoCAD.msi

5. Run nanoCad. Select Demo mode.
WINEARCH=win32 WINEPREFIX=~/.wine/wine-test ./wine
~/.wine/wine-test/drive_c/Program\ Files/Nanosoft/nanoCAD\ en\ 5.0/nCad.exe

6. Select menu File->Open. or Click on "Open" icon on the toolbar. Dialog
window will not open.

[Bug 39920] [REGRESSION] In Nanocad 5.1 the file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
            Summary|[REGRESSION] In Nanocad 5.1 |Nanocad 5.: file
                   |the file open/import dialog |open/import dialog does not
                   |does not open               |open

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                URL|                            |ftp://ftp.nanocad.com/nanoc
                   |                            |ad/nanoCAD50(2000).ZIP
           Keywords|                            |download
     Ever confirmed|0                           |1

--- Comment #1 from Bruno Jesus  ---
Confirming the regression in wine 1.9.18.

http://source.winehq.org/git/wine.git/commitdiff/bbf2cce16041e90d621a1f5889e...

comdlg32: Do not modify dialog resource directly.

author: Thomas Faber 
Fri, 20 Jul 2012 06:33:08 +0000 (08:33 +0200)
committer: Alexandre Julliard 
Fri, 20 Jul 2012 12:02:31 +0000 (14:02 +0200)

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

--- Comment #2 from Bruno Jesus  ---
Created attachment 55648
  --> https://bugs.winehq.org/attachment.cgi?id=55648
patch

For absolutely unknown reasons "dwSize = SizeofResource(COMDLG32_hInstance,
hRes)" receives zero as value. hRes is not NULL, otherwise a previous error
would have been triggered.

I don't know if the patch is correct or not, it just works.

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

--- Comment #3 from Nikolay Sivov  ---
It looks like it also need some version of dotnet. Bruno, what did you use for
testing?

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

--- Comment #4 from Bruno Jesus  ---
(In reply to Nikolay Sivov from comment #3)
> It looks like it also need some version of dotnet. Bruno, what did you use
> for testing?

If you try in a clean prefix the program will crash "Loading modules". So prior
to installing the app winetricks dotnet35.

The Open/Import dialogs still do not open in 2.0-rc1.

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

--- Comment #5 from Nikolay Sivov  ---
Created attachment 56723
  --> https://bugs.winehq.org/attachment.cgi?id=56723
patch 2

Zero size is "normal" in this case, that's apparently how resource entry is set
up by application. Attached patch doesn't modify template regardless of where
it comes from, deferring style changes to initialization time. I think it's
better to wait after 2.0 with it, as it should be split to fix SetWindowLong
separately, and that's unrelated to this regression. Please retest.

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |6c4aaf776faf6bf465e3a06bb68
                   |                            |a7c7e998b68be
           Assignee|[e-mail]        |[e-mail]
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Nikolay Sivov  ---
Fixed with 6c4aaf776faf6bf465e3a06bb68a7c7e998b68be. Please test.

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 2.1.

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x

[Bug 39920] Nanocad 5.: file open/import dialog does not open

https://bugs.winehq.org/show_bug.cgi?id=39920

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #8 from Michael Stefaniuc  ---
Removing the 2.0.x milestone from bugs included in 2.0.1.