[Bug 54916] New: regression : touhou 12.3 dpad mod crash

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

Bug ID: 54916
           Summary: regression : touhou 12.3 dpad mod crash
           Product: Wine
           Version: 8.7
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: xinput
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 74430
  --> https://bugs.winehq.org/attachment.cgi?id=74430
Log file of the game crashing/hanging

--The game
The popular version of this game is a community edition that includes mods :
https://soku.delthas.fr/

--Launch the game(with mods)
The right executable file is th123e.exe.
In order to launch the game correctly with the mods, it is needed to either use
DXVK or either add a d3d9 lib with winecfg and use WINEDLLOVERRIDES="d3d9=n,b",
as mods are injected through the d3d9.dll file inside the game folder.
You can check that mods are injected correctly by going in the "Vs NETWORK"
menu, if mods are injected correctly there will be a hostlist menu, if not it
is a IP and port connecting menu without hostlist.

--The dpad mod and expected behavior
https://hisouten.koumakan.jp/wiki/Mods#DPad_Fix
This mod is enabled by default and can be disabled by placing a ; in front of
the line DPadFix= inside SWRSToys.ini, the mod config file.
Without this mod, only joystick are usable, with it, dpad and joystick are both
usable, you can test that in the game main menu.

--Current behavior
The game crash because of this mod, other mods don't.
This was seemingly fixed around wine 7, but supposedly since wine 8 it crash
again.
Recently tested with wine and wine-staging 8.7. The mod still works with
lutris-fshack-7.2 and recent wine-ge based on proton 7, but not proton 8.

The file attached is a log file of the game crashing/hanging.

[Bug 54916] regression : touhou 12.3 dpad mod crash

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

--- Comment #1 from [e-mail] ---
It crashes at launch, the game can't launch with the mod.

[Bug 54916] touhou 12.3 with dpad mod crashes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|regression : touhou 12.3    |touhou 12.3 with dpad mod
                   |dpad mod crash              |crashes on start
           Keywords|                            |regression
          Component|xinput                      |-unknown
           Severity|major                       |normal

--- Comment #2 from Gijs Vermeulen  ---
Not major, see: https://wiki.winehq.org/Bugs#severity

If possible, please perform a regression test, see:
https://wiki.winehq.org/Regression_Testing

[Bug 54916] touhou 12.3 with dpad mod crashes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

--- Comment #3 from [e-mail] ---
(In reply to Gijs Vermeulen from comment #2)
> Not major, see: https://wiki.winehq.org/Bugs#severity
>
> If possible, please perform a regression test, see:
> https://wiki.winehq.org/Regression_Testing

For now I found that the regression is between wine 8.0 and 8.1

[Bug 54916] touhou 12.3 with dpad mod crashes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

--- Comment #4 from [e-mail] ---
Created attachment 74448
  --> https://bugs.winehq.org/attachment.cgi?id=74448
First bad commit

[Bug 54916] touhou 12.3 with dpad mod crashes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |80d1d087877cb20122039277955
                   |                            |96fca8da3945b
          Component|-unknown                    |dinput

[Bug 54916] touhou 12.3 with dpad mod crashes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 54916] touhou 12.3 with dpad mod crashes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

--- Comment #5 from Rémi Bernon  ---
Created attachment 74485
  --> https://bugs.winehq.org/attachment.cgi?id=74485
Possible fix

Does this patch fix the issue?

[Bug 54916] touhou 12.3 with dpad mod crashes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

--- Comment #6 from YuriK7  ---
(In reply to Rémi Bernon from comment #5)
> Created attachment 74485 [details]
> Possible fix
>
> Does this patch fix the issue?

Tested with latest git and git with patch. The issue is fixed with this patch !

[Bug 54916] touhou 12.3 with dpad mod crashes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |88a34c74b0fee3f7dc8c53c92e7
                   |                            |52a84a1c61923
         Resolution|---                         |FIXED

--- Comment #7 from Rémi Bernon  ---
The patch has been merged as 88a34c74b0fee3f7dc8c53c92e752a84a1c61923, marking
as fixed.

[Bug 54916] touhou 12.3 with dpad mod crashes on start

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54916

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 8.9.