https://bugs.winehq.org/show_bug.cgi?id=44473
Bug ID: 44473 Summary: glyph overlap in Delphi editor Product: Wine Version: 3.1 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdi32 Assignee: wine-bugs@winehq.org Reporter: development@winomega.com Distribution: ---
Created attachment 60421 --> https://bugs.winehq.org/attachment.cgi?id=60421 text overlap effect (after regression)
Starting with commit 34e73617903da1f73f628d1eca355a9e2173da2e glyph position is not correctly calculated for Delphi editor, which results in text overlap.
https://bugs.winehq.org/show_bug.cgi?id=44473
--- Comment #1 from Omega Software development@winomega.com --- Created attachment 60422 --> https://bugs.winehq.org/attachment.cgi?id=60422 expected result (before regression)
https://bugs.winehq.org/show_bug.cgi?id=44473
Omega Software development@winomega.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |34e73617903da1f73f628d1eca3 | |55a9e2173da2e CC| |huw@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=44473
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sagawa.aki+winebugs@gmail.c | |om
https://bugs.winehq.org/show_bug.cgi?id=44473
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
https://bugs.winehq.org/show_bug.cgi?id=44473
--- Comment #2 from Sagawa sagawa.aki+winebugs@gmail.com --- Hello, thanks for reporting. Could you provide some more information?
- Which version of Delphi did you try? Is the demo available? - What font face and size did you use? e.g. Courier, 12pt.
I'll try to reproduce this issue if possible. Thanks in advance.
https://bugs.winehq.org/show_bug.cgi?id=44473
--- Comment #3 from Omega Software development@winomega.com ---
Hi Sagawa-san
(In reply to Sagawa from comment #2)
Hello, thanks for reporting. Could you provide some more information?
- Which version of Delphi did you try? Is the demo available?
We found the bug with Delphi 7. There's no demo available. Unfortunately this version is very old. Embarcadero provides trial versions of Delphi but only recent versions are available (which don't work at all with Wine).
- What font face and size did you use? e.g. Courier, 12pt.
The screenshots I sent are for Courier 10 (this is the only available size). In Editor Properties there are other fonts available:
Fixedsys 9 -> same problem
DejaVu Sans Mono -> several sizes are available, all work OK
I'm available for tests if you need.
https://bugs.winehq.org/show_bug.cgi?id=44473
--- Comment #4 from Omega Software development@winomega.com --- BTW I'm not sure why is "Courier 10" even present, as I hadn't installed MS fonts in this $WINEPREFIX.
I've just run "winetricks corefonts" and now "Courier New" appears, with several sizes. These work OK too.
But the "Courier" font is still present, with same broken results (just like Fixedsys).
https://bugs.winehq.org/show_bug.cgi?id=44473
--- Comment #5 from Sagawa sagawa.aki+winebugs@gmail.com --- Created attachment 60436 --> https://bugs.winehq.org/attachment.cgi?id=60436 proposed patch
Could you try this patch? I found out some text metrics aren't updated when synthesizing bold glyphs in bitmap font case.
https://bugs.winehq.org/show_bug.cgi?id=44473
--- Comment #6 from Omega Software development@winomega.com --- Created attachment 60438 --> https://bugs.winehq.org/attachment.cgi?id=60438 with fix_metrics.patch (Courier 10)
Your patch works fine. I'm attaching a Courier 10 screenshot.
Many thanks!
https://bugs.winehq.org/show_bug.cgi?id=44473
--- Comment #7 from Omega Software development@winomega.com --- BTW Fixedsys 9 works now, too.
https://bugs.winehq.org/show_bug.cgi?id=44473
--- Comment #8 from Sagawa sagawa.aki+winebugs@gmail.com --- Good news. Thanks for testing. I'll send a revised patch as I find a minor issue in the original one.
https://bugs.winehq.org/show_bug.cgi?id=44473
--- Comment #9 from Sagawa sagawa.aki+winebugs@gmail.com --- Should be fixed by dce3e171858d831e9861ed02df30a5aeddcc3a64.
https://bugs.winehq.org/show_bug.cgi?id=44473
Omega Software development@winomega.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #10 from Omega Software development@winomega.com --- Confirmed. Thanks!
https://bugs.winehq.org/show_bug.cgi?id=44473
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.kucia@gmail.com Fixed by SHA1| |dce3e171858d831e9861ed02df3 | |0a5aeddcc3a64
https://bugs.winehq.org/show_bug.cgi?id=44473
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.3.
https://bugs.winehq.org/show_bug.cgi?id=44473
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x
https://bugs.winehq.org/show_bug.cgi?id=44473
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |---
--- Comment #12 from Michael Stefaniuc mstefani@winehq.org --- Removing the 3.0.x milestone from bugs included in 3.0.1.