http://bugs.winehq.org/show_bug.cgi?id=27664
Summary: Various Telltale games crash on startup Product: Wine Version: 1.3.23 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: rmlipman@gmail.com
Created an attachment (id=35380) --> (http://bugs.winehq.org/attachment.cgi?id=35380) Poker Night backtrace (gameoverlayrenderer disabled)
Games tested:
Poker Night at the Inventory Sam and Max 305 Sam and Max 301
http://bugs.winehq.org/show_bug.cgi?id=27664
--- Comment #1 from rmlipman@gmail.com 2011-06-30 17:00:11 CDT --- Created an attachment (id=35381) --> (http://bugs.winehq.org/attachment.cgi?id=35381) Sam and Max 305 backtrace (gameoverlayrenderer disabled)
http://bugs.winehq.org/show_bug.cgi?id=27664
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #2 from Jerome Leclanche adys.wh@gmail.com 2011-06-30 19:58:10 CDT --- What's your OS? Please install debug symbols. On ubuntu, that would be a wine*-dbg package.
http://bugs.winehq.org/show_bug.cgi?id=27664
--- Comment #3 from rmlipman@gmail.com 2011-06-30 20:22:17 CDT --- (In reply to comment #2)
What's your OS?
Debian testing. I usually build from source.
Please install debug symbols. On ubuntu, that would be a wine*-dbg package.
Whoops, getting those now.
http://bugs.winehq.org/show_bug.cgi?id=27664
rmlipman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #35380|0 |1 is obsolete| |
--- Comment #4 from rmlipman@gmail.com 2011-06-30 20:22:49 CDT --- Created an attachment (id=35383) --> (http://bugs.winehq.org/attachment.cgi?id=35383) Poker Night backtrace (with debug symbols)
http://bugs.winehq.org/show_bug.cgi?id=27664
rmlipman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #35381|0 |1 is obsolete| |
--- Comment #5 from rmlipman@gmail.com 2011-06-30 20:23:37 CDT --- Created an attachment (id=35384) --> (http://bugs.winehq.org/attachment.cgi?id=35384) Sam and Max 305 backtrace (with debug symbols)
http://bugs.winehq.org/show_bug.cgi?id=27664
Alex Bradbury asb@asbradbury.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |asb@asbradbury.org
--- Comment #6 from Alex Bradbury asb@asbradbury.org 2011-07-01 01:58:40 CDT --- Can you reproduce this with one of the Telltale demos? e.g. the one available at http://www.telltalegames.com/store/samandmax-thedevilsplayhouse
http://bugs.winehq.org/show_bug.cgi?id=27664
--- Comment #7 from rmlipman@gmail.com 2011-07-01 02:19:50 CDT --- (In reply to comment #6)
Can you reproduce this with one of the Telltale demos? e.g. the one available at http://www.telltalegames.com/store/samandmax-thedevilsplayhouse
Yes, the demo crashes as well.
http://bugs.winehq.org/show_bug.cgi?id=27664
--- Comment #8 from rmlipman@gmail.com 2011-07-01 02:20:33 CDT --- Created an attachment (id=35385) --> (http://bugs.winehq.org/attachment.cgi?id=35385) Sam and Max 301 demo backtrace
http://bugs.winehq.org/show_bug.cgi?id=27664
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.telltalegames.co | |m/store/samandmax-thedevils | |playhouse
--- Comment #9 from Austin English austinenglish@gmail.com 2011-07-01 11:16:30 CDT --- (In reply to comment #7)
(In reply to comment #6)
Can you reproduce this with one of the Telltale demos? e.g. the one available at http://www.telltalegames.com/store/samandmax-thedevilsplayhouse
Yes, the demo crashes as well.
Works fine for me in wine-1.3.23-109-g7340dcd. Try native dinput.
http://bugs.winehq.org/show_bug.cgi?id=27664
--- Comment #10 from Andrew Nguyen arethusa26@gmail.com 2011-07-01 17:09:49 CDT --- (In reply to comment #9)
(In reply to comment #7)
(In reply to comment #6)
Can you reproduce this with one of the Telltale demos? e.g. the one available at http://www.telltalegames.com/store/samandmax-thedevilsplayhouse
Yes, the demo crashes as well.
Works fine for me in wine-1.3.23-109-g7340dcd. Try native dinput.
The problem occurs when a joystick device is connected. The application's callback function provided to EnumDevices has the wrong calling convention.
http://bugs.winehq.org/show_bug.cgi?id=27664
--- Comment #11 from rmlipman@gmail.com 2011-07-02 01:04:01 CDT --- (In reply to comment #10)
(In reply to comment #9)
(In reply to comment #7)
(In reply to comment #6)
Can you reproduce this with one of the Telltale demos? e.g. the one available at http://www.telltalegames.com/store/samandmax-thedevilsplayhouse
Yes, the demo crashes as well.
Works fine for me in wine-1.3.23-109-g7340dcd. Try native dinput.
The problem occurs when a joystick device is connected. The application's callback function provided to EnumDevices has the wrong calling convention.
I can confirm the crashes stop when unplugging my joystick.
http://bugs.winehq.org/show_bug.cgi?id=27664
rmlipman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Various Telltale games |Various Telltale games |crash on startup |crash on startup when a | |joystick is plugged in
http://bugs.winehq.org/show_bug.cgi?id=27664
--- Comment #12 from Andrew Nguyen arethusa26@gmail.com 2011-07-02 03:05:42 CDT --- Created an attachment (id=35395) --> (http://bugs.winehq.org/attachment.cgi?id=35395) dinput: Use an assembler wrapper for invoking the EnumDevices callback.
Try this patch; it fixes the crash in the SamMax301.exe demo for me.
http://bugs.winehq.org/show_bug.cgi?id=27664
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #13 from Andrew Nguyen arethusa26@gmail.com 2011-07-02 03:06:21 CDT --- I'll take the liberty of confirming the bug.
http://bugs.winehq.org/show_bug.cgi?id=27664
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #35395|0 |1 is obsolete| |
--- Comment #14 from Andrew Nguyen arethusa26@gmail.com 2011-07-02 03:10:35 CDT --- Created an attachment (id=35396) --> (http://bugs.winehq.org/attachment.cgi?id=35396) dinput: Use an assembler wrapper for invoking the EnumDevices callback. (try 2)
Sorry, the patch I previously attached is diffed against a private branch, so the tests won't apply with the latest Git. I'm attaching a revised version.
http://bugs.winehq.org/show_bug.cgi?id=27664
--- Comment #15 from rmlipman@gmail.com 2011-07-02 03:29:19 CDT --- (In reply to comment #14)
Created an attachment (id=35396)
--> (http://bugs.winehq.org/attachment.cgi?id=35396) [details]
dinput: Use an assembler wrapper for invoking the EnumDevices callback. (try 2)
Sorry, the patch I previously attached is diffed against a private branch, so the tests won't apply with the latest Git. I'm attaching a revised version.
Poker Night works with this patch, but not Sam and Max. It crashes silently with the following dumped to console:
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7ee15be0 err:ole:RevokeDragDrop invalid hwnd (nil) err:ole:RevokeDragDrop invalid hwnd 0x1013e
http://bugs.winehq.org/show_bug.cgi?id=27664
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |hardware
--- Comment #16 from Bruno Jesus 00cpxxx@gmail.com --- Is this still an issue in the latest development version of wine?
http://bugs.winehq.org/show_bug.cgi?id=27664
Navdeep Singh Sidhu navdeepsingh.sidhu95@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |navdeepsingh.sidhu95@gmail. | |com
--- Comment #17 from Navdeep Singh Sidhu navdeepsingh.sidhu95@gmail.com --- Does anybody have solution for this bug :) ?? facing bug in Don Bradman Cricket 14.
https://bugs.winehq.org/show_bug.cgi?id=27664
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
https://bugs.winehq.org/show_bug.cgi?id=27664
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@fds-team.de
--- Comment #18 from Michael Müller michael@fds-team.de --- I can't reproduce the issue with the Sam and Max 301 demo from http://www.gamershell.com/download_57930.shtml and a PS3 controller as joystick.
I guess the problem was fixed in the mean time, at least it works for me using Wine 1.7.54.
https://bugs.winehq.org/show_bug.cgi?id=27664
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |erich.e.hoover@wine-staging | |.com, sebastian@fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/dinput-EnumDev | |ice_Callback
https://bugs.winehq.org/show_bug.cgi?id=27664
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Various Telltale games |Various Telltale games |crash on startup when a |crash on startup when a |joystick is plugged in |joystick is plugged in | |(application provides | |EnumDevice callback with | |wrong calling convention)
--- Comment #19 from Sebastian Lackner sebastian@fds-team.de --- Based on the previous comments, there are multiple issues mixed up in a single bug report. Lets make this one about the games which call EnumDevice with a non-standard calling convention. By looking at the assembler code, I have indeed confirmed that some applications do that. Tests also show that such wrong behaviour works fine Windows version < Win 8.
If there are problems with other games, which are not fixed by the staged patchset, please open a new bug report for it (and add me as CC). Also attach terminal output with a recent version of Wine, and provide a download link if a demo is available.
The reason why some people do not encounter the crash is just because different versions of gcc generate different code. If the calling function itself restores ESP at the end, its more unlikely that it crashes. This doesn't make the bug report invalid though.
https://bugs.winehq.org/show_bug.cgi?id=27664
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |directx-dinput
https://bugs.winehq.org/show_bug.cgi?id=27664
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |6566cd76ce56cc2cfca16123b16 | |a286f02d27327 Status|STAGED |RESOLVED Resolution|--- |FIXED
--- Comment #20 from Sebastian Lackner sebastian@fds-team.de --- The patch was added in http://source.winehq.org/git/wine.git/commit/6566cd76ce56cc2cfca16123b16a286....
As mentioned above, for any remaining issues with other games (which are still valid in current versions of Wine) please open new bug reports.
https://bugs.winehq.org/show_bug.cgi?id=27664
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #21 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.8-rc1.