[Bug 34122] New: Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

Bug #: 34122
           Summary: Civilization V breaks both expansion packs are
                    installed
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 45374
  --> http://bugs.winehq.org/attachment.cgi?id=45374
Test program that tries to reproduce Civilization V's behavior as seen from the
+files log

With the release of Brave New World for Civiliziation V, the game itself fails
to properly load either expansion if both are loaded. The issue appears to boil
down to the fact that Civ tries to load its datafiles in the order returned by
Find{First,Next}File, and inadvertently loads its expansions in the wrong order
(G&K must be loaded before Brave New World).

This issue can be semi-worked around by renaming files so that their return
order is changed (generally renaming Expansion to Expansion3 seems to do the
trick, but its not foolproof).

On Windows, FindFirstFile returns its files in alphabetical order (likely due
to Steam installing them in that order), and as such, Civ can load things
correctly. I was able to reproduce this bug on Windows by moving everything to
a network drive (which returns a different order), and getting similar results.

To show the problem, I wrote a test program which calls FindFirstFile in a
matter similiar to Civ5 does; said program is attached along with a trace from
+file.

Results from the test program:

Wine git (game does NOT work):
mcasadevall@perdition:~/wine-dev/steam/drive_c/Program
Files/Steam/SteamApps/common/Sid Meier's Civilization V$ $WINE ./a.exe 
.\Assets\DLC\DLC_02\SpainInca.Civ5Pkg
.\Assets\DLC\Shared\Upgrade1.Civ5Pkg
.\Assets\DLC\DLC_05\Korea.Civ5Pkg
.\Assets\DLC\Tablet\Tablet.Civ5Pkg
.\Assets\DLC\Expansion2\Expansion2.Civ5Pkg
.\Assets\DLC\DLC_06\AncientWonders.Civ5Pkg
.\Assets\DLC\DLC_04\Denmark.Civ5Pkg
.\Assets\DLC\DLC_01\Mongol.Civ5Pkg
.\Assets\DLC\DLC_03\Polynesia.Civ5Pkg
.\Assets\DLC\Expansion\Expansion1.Civ5Pkg
.\Assets\DLC\DLC_Deluxe\Babylon.Civ5Pkg

Windows XP - NTFS filesystem (game works)
C:\Program Files\Steam\steamapps\common1\Sid Meier's Civilization V>a
.\Assets\DLC\DLC_01\Mongol.Civ5Pkg
.\Assets\DLC\DLC_02\SpainInca.Civ5Pkg
.\Assets\DLC\DLC_03\Polynesia.Civ5Pkg
.\Assets\DLC\DLC_04\Denmark.Civ5Pkg
.\Assets\DLC\DLC_05\Korea.Civ5Pkg
.\Assets\DLC\DLC_06\AncientWonders.Civ5Pkg
.\Assets\DLC\DLC_Deluxe\Babylon.Civ5Pkg
.\Assets\DLC\Expansion\Expansion1.Civ5Pkg
.\Assets\DLC\Expansion2\Expansion2.Civ5Pkg
.\Assets\DLC\Shared\Upgrade1.Civ5Pkg
.\Assets\DLC\Tablet\Tablet.Civ5Pkg

Windows XP - network filesystem (game does NOT work)
X:\wine-dev\steam\drive_c\Program Files\Steam\SteamApps\common\Sid Meier's
Civil
ization V>a
.\Assets\DLC\Tablet\Tablet.Civ5Pkg
.\Assets\DLC\DLC_02\SpainInca.Civ5Pkg
.\Assets\DLC\Shared\Upgrade1.Civ5Pkg
.\Assets\DLC\DLC_05\Korea.Civ5Pkg
.\Assets\DLC\Expansion2\Expansion2.Civ5Pkg
.\Assets\DLC\DLC_06\AncientWonders.Civ5Pkg
.\Assets\DLC\DLC_04\Denmark.Civ5Pkg
.\Assets\DLC\DLC_01\Mongol.Civ5Pkg
.\Assets\DLC\DLC_03\Polynesia.Civ5Pkg
.\Assets\DLC\Expansion\Expansion1.Civ5Pkg
.\Assets\DLC\DLC_Deluxe\Babylon.Civ5Pkg

I believe the underlying cause of this bug may also be the root of bug #31113,
but until I know for sure, they should be considered seperate issues.

[Bug 34122] Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #1 from Michael Casadevall  2013-07-23 17:18:55 CDT ---
Created attachment 45375
  --> http://bugs.winehq.org/attachment.cgi?id=45375
Compiled test program

[Bug 34122] Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

Andrew Mitchell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 34122] Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #2 from Michael Casadevall  2013-07-23 17:50:53 CDT ---
The log was too large to upload even when compressed, so I put it on personal
storage space:
here: http://people.canonical.com/~mcasadevall/civ5_files_loaddll.log.bz2

There's a fair bit of cruft due to Steam loading, but you can see from the log
that Civ5 essentially loads its datafiles in the order located on disk (look
for CreateFileW entries for the civ5pkg files).

[Bug 34122] Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
            Version|unspecified                 |1.6
     Ever Confirmed|0                           |1

--- Comment #3 from Jerome Leclanche  2013-07-24 13:37:37 CDT ---
Confirming

[Bug 34122] Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 34122] Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

Luke Bratch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 34122] Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

Anders Larsson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #4 from Anders Larsson  2013-08-13 07:01:09 CDT ---
Created an account to confirm that this is a issue for me as well.
Would be great if it could be solved.

[Bug 34122] Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 34122] Civilization V breaks both expansion packs are installed

http://bugs.winehq.org/show_bug.cgi?id=34122

Michal Illich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Michal Illich  2013-08-26 02:49:18 CDT ---
btw, it might be related:
when loading savegames in Firaxis games (Civilization or the new UFO), the
files are also not sorted alphabetically. I guess that sorting outputs of
FindFirstFile will fix many bugs at once.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Civilization V breaks both  |Civilization V breaks both
                   |expansion packs are         |expansion packs are
                   |installed                   |installed due to
                   |                            |FindFirstFile
                   |                            |implementation

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

Marc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Marc  2013-08-26 21:44:05 CDT ---
This looks like a duplicate of bug 31113, which has a work-around script that
seems to be giving mixed results.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #7 from Anders Larsson  2013-09-01 10:00:30 CDT ---
(In reply to comment #6)
> This looks like a duplicate of bug 31113, which has a work-around script that
> seems to be giving mixed results.

Just tried the workaround with a clean Civilization 5 install and it does not
fix the bug mentioned in this thread.
Elements of the interface is gone in Civilization 5 which makes it impossible
to play since you're unable to build buildings/units in cities.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

Jayky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Jayky  2013-09-15 09:01:02 CDT ---
(In reply to comment #0)
> With the release of Brave New World for Civiliziation V, the game itself fails
> to properly load either expansion if both are loaded. The issue appears to boil
> down to the fact that Civ tries to load its datafiles in the order returned by
> Find{First,Next}File, and inadvertently loads its expansions in the wrong order
> (G&K must be loaded before Brave New World).
>
> This issue can be semi-worked around by renaming files so that their return
> order is changed (generally renaming Expansion to Expansion3 seems to do the
> trick, but its not foolproof).

I confirm this bug. Would be great if it can be fixed.

Additional my experience with renaming the directory and the two files showed
that this just deactivates G&K. So you can fix this easier by
1. going ingame to the DLC menu
2. deactivate G&K expansion
The important thing is that BNW got all the benefits of G&K except the civs.
And this is how you really can check if the renaming fix works for you:
1. Use the renaming fix
2. try to select a civilization form the first expansion like Sweden or Austria
If you can select them, than the renaming fix works perfectly for you. If not,
you can simply deactivate the DLC G&K with exactly the same effect (at least
this was so on my system).

I'm curious if someone here is able to select civs from the first and second
expansion in one game. If it should be possible for you, please tell me which
wine version you are using.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

olelukoie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from olelukoie  2013-10-16 13:43:09 CDT ---
I think this is not a bug in WINE but the bug in the game. The game developers
do rely on an NTFS file system driver feature instead of carefully read MSDN.
Here's the link to FindFisrtFile description:

http://msdn.microsoft.com/en-us/library/windows/desktop/aa364418%28v=vs.85%2...

You can find there the following:

[quote]
Remarks

The FindFirstFile function opens a search handle and returns information about
the first file that the file system finds with a name that matches the
specified pattern. This may or may not be the first file or directory that
appears in a directory-listing application (such as the dir command) when given
the same file name string pattern. This is because FindFirstFile does no
sorting of the search results. For additional information, see FindNextFile.
[/quote]

You can reproduce this "bug" by using FAT32 instead of NTFS under Windows.
FAT/FAT32 driver returns files in the creation time order instead of
alphabetical one. This means that if you create the files or dirs with names
"1", "3", "2" on FAT partition then you'll get them in the same order and not
in 1-2-3 one.

BTW ntfs-3g driver under Linux sorts the files so installing the game on NTFS
or FAT partition could be a solution for the problem.

To check the real order of files and dirs in any FS-driver under Linux you can
use 'ls -l --sort=no' command.

PS. It would be really great to have an option (command line option or
environment variable) to imitate NTFS driver behavior (file sorting) in WINE.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

Lee Trager  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Lee Trager  2013-10-18 03:29:18 CDT ---
(In reply to comment #9)
> I think this is not a bug in WINE but the bug in the game. The game developers
> do rely on an NTFS file system driver feature instead of carefully read MSDN.
> Here's the link to FindFisrtFile description:
>
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa364418%28v=vs.85%2...
>
> You can find there the following:
>
> [quote]
> Remarks
>
> The FindFirstFile function opens a search handle and returns information about
> the first file that the file system finds with a name that matches the
> specified pattern. This may or may not be the first file or directory that
> appears in a directory-listing application (such as the dir command) when given
> the same file name string pattern. This is because FindFirstFile does no
> sorting of the search results. For additional information, see FindNextFile.
> [/quote]
>
> You can reproduce this "bug" by using FAT32 instead of NTFS under Windows.
> FAT/FAT32 driver returns files in the creation time order instead of
> alphabetical one. This means that if you create the files or dirs with names
> "1", "3", "2" on FAT partition then you'll get them in the same order and not
> in 1-2-3 one.
>
> BTW ntfs-3g driver under Linux sorts the files so installing the game on NTFS
> or FAT partition could be a solution for the problem.
>
> To check the real order of files and dirs in any FS-driver under Linux you can
> use 'ls -l --sort=no' command.
>
> PS. It would be really great to have an option (command line option or
> environment variable) to imitate NTFS driver behavior (file sorting) in WINE.

Yes and no, wine is trying to implement a replica environment of different
versions of Windows. AFAIK recent versions of Windows only support having the
system drive, where programs are installed by default, formatted as NTFS. Most
Windows application developers assume and only support NTFS.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

Cristina Botta  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from [e-mail] 2013-11-09 06:49:11 CST ---
ftp://ftp.uhulinux.hu/pub/sources/sortdir/sortdir-0.6.tar.gz - Try this as a
workaround (compile with -m32, use with LD_PRELOAD). It intercepts readdir and
sorts files in alphabetical order. so FindFirstFile will recieve them in
exactly same order as it does on NTFS

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #12 from [e-mail] 2013-11-09 08:59:06 CST ---
I figured out an actual workaround

cd %HERE_IS_YOUR_CIV5_DIR%/Assets
mv DLC ../DLC.orig # Only first time
mount -t tmpfs tmpfs DLC
cd DLC
for i in `ls ../../DLC.orig/|tac`; do ln -s ../../DLC.orig/$i .; done;

That's it. tmpfs lists files in the order in which they were created
(reversed), so your test program, civ5 and ls -la --sort=no gets them right.

You need to mount tmpfs and create symlinks after every reboot, but it works.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

deonix  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

Mark Eoberts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Mark Eoberts  2013-12-03 00:47:00 CST ---
(In reply to comment #12)
> I figured out an actual workaround
>
> cd %HERE_IS_YOUR_CIV5_DIR%/Assets
> mv DLC ../DLC.orig # Only first time
> mount -t tmpfs tmpfs DLC
> cd DLC
> for i in `ls ../../DLC.orig/|tac`; do ln -s ../../DLC.orig/$i .; done;
>
> That's it. tmpfs lists files in the order in which they were created
> (reversed), so your test program, civ5 and ls -la --sort=no gets them right.
>
> You need to mount tmpfs and create symlinks after every reboot, but it works.

For those of us who aren't all that savvy, how can we get things to work
properly? My game loads but much of the DLC is missing and when the game
starts, there are no order menus, making it unplayable.

Mark

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #14 from Jayky  ---
(In reply to comment #13)
> For those of us who aren't all that savvy, how can we get things to work
> properly? My game loads but much of the DLC is missing and when the game
> starts, there are no order menus, making it unplayable.
>
> Mark

Dear Mark,

For all that are not so familiar with Linux here a short HowTo:
1. Find the place where Civ is installed. Normally in your home directory. When
you are using PlayOnLinux it should be something like this:
/home/$USE_HERE_YOUR_OWN_USER_DIR$/PlayOnLinux's\ virtual\
drives/Steam/drive_c/Program\ Files/Steam/SteamApps/common/sid\ meier's\
civilization\ v
Be sure that you find the directory with a folder called "Assets" in it.
2. Open a shall/terminal
3. Change the folder to your Civ5 directory that you found in step 1. For this
use the "cd" command. Here an example that must be adapt to your dir:
cd /home/$USE_HERE_YOUR_OWN_USER_DIR$/PlayOnLinux's\ virtual\
drives/Steam/drive_c/Program\ Files/Steam/SteamApps/common/sid\ meier's\
civilization\ v/Assets
4. Use this command: mv DLC ../DLC.orig
5. Create a new folder called "DLC" within the Civ5 folder with the name
"Assets". You can use your favourite file manager (e.g. Nautilus, Dolphin,
Thunar, ...) for this step.
6. Use this command: sudo mount -t tmpfs tmpfs DLC
For this step you have to type your password. It is the password that you are
also usung to login to your computer account. If there is an Error because
there is no correct mount point, than you have done something wrong in step 5. 
7. Use this command: cd DLC
If there is an Error because there is no directory with this name, than you
have done something wrong in step 5.
8. Use this command: for i in `ls ../../DLC.orig/|tac`; do ln -s
../../DLC.orig/$i .; done;

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

Peter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Peter  ---
Interestingly, I have this issue only on Ubuntu 13.10. On Ubuntu 13.04 it
works, tested on two different installations with several wine version 1.7.x.
Full Civ V with all DLCs and expansions.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

Patrick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #16 from Patrick  ---
- Rookie here.

I can also confirm this bug, it only occurs when both expansions are enabled.

I read that time of creation of the DLC-files matters so I've removed the
Expansion-folder and let steam redownload the missing files. But that didn't
seem to work either. Renaming Expansion-folder resulted in graphical errors
whilst the bug still persisted.

Unfortunately Jayky's work around didn't do much for me either. Got similair
results as described above.

I'll keep hunting.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Stefan Dösinger  ---
The original description suggests that the load order depends on Steam writing
the files in the correct order. What happens on Windows if the game directory
is moved away and re-created by copying the files back manually in a
non-alphabetical order?

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #18 from olelukoie  ---
(In reply to Stefan Dösinger from comment #17)
> The original description suggests that the load order depends on Steam
> writing the files in the correct order. What happens on Windows if the game
> directory is moved away and re-created by copying the files back manually in
> a non-alphabetical order?

Depends on FS you use. NTFS always sorts files/dirs alphabetically regardless
of creation time. FAT seems to sort files in creation time order. So using NTFS
you would not see any problem, and using FAT you should see the same error
loading DLCs. (see my comment 9)

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

http://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #19 from Stefan Dösinger  ---
(In reply to olelukoie from comment #18)
> Depends on FS you use.

Right, I didn't see that comment when I read through the bug.

In this case it seems to me rewriting the test program in attachment 45374 as a
proper wine test in dlls/ntdll/tests and/or maybe dlls/kernel32/tests is a
logical next step. Use todo_wine markers for everything that doesn't return the
proper result on Wine yet.

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #20 from Austin English  ---
This is your friendly reminder that there has been no bug activity for over a
year. Is this still an issue in current (1.7.51 or newer) wine?

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

https://bugs.winehq.org/show_bug.cgi?id=34122

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from [e-mail] ---
Created attachment 52641
  --> https://bugs.winehq.org/attachment.cgi?id=52641
test this patch

[Bug 34122] Civilization V breaks both expansion packs are installed due to FindFirstFile implementation

https://bugs.winehq.org/show_bug.cgi?id=34122

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #22 from Józef Kucia  ---
*** Bug 27005 has been marked as a duplicate of this bug. ***

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www.tagap.net/down_t
                   |                            |agap.htm
                 CC|                            |[e-mail]
            Summary|Civilization V breaks both  |Multiple applications
                   |expansion packs are         |expects files returned by
                   |installed due to            |FindFirstFile/FindNextFile
                   |FindFirstFile               |to be in alphabetical order
                   |implementation              |(Civilization V with 2
                   |                            |expansion packs, TAGAP)

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Adam Bolte  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #23 from Adam Bolte  ---
*** Bug 39467 has been marked as a duplicate of this bug. ***

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #24 from Adam Bolte  ---
> From my testing of the patch in the Steam file selector, the patch doesn't yet

behave identically to Windows 7 on NTFS (but gets us 99% of the way there).

The Windows 7 screenshot (attached to duplicate bug 39467) shows the "Backups"
directory listed after "appcache", whereas the attached patch causes Wine to
list "Backups" first (before "amf").

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Robert Walker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #25 from Robert Walker  ---
(In reply to super_man from comment #21)
> Created attachment 52641 [details]
> test this patch

This patch works to fix the issue with the Steam Client backup/restore browser.

I had to change the function call: CompareStringOrdinal(... , true)
This then appears to exactly duplicate the sort order for an NTFS formatted
drive (when accessed under native Windows).

However running the Steam client backup/restore browser - under native Windows
8.1 - the sort order for:
FindFirstFile/FindNextFile
appears to be extremely random for a CIFS network-mapped drive (Linux Samba
share). I couldn't even work out what the sort order is based on (it's not
alphabetical, or creation/modification dates).

Surely this bug is really in Windows applications (Steam client, etc.) that
assume that FindFirstFile/FindNextFile will always return sorted results? As
this is only the case for NTFS formatted volumes.

I will keep the patch in my Gentoo Wine user patches... The end result is a
much better user experience!

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Michael McGuire  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |[e-mail]

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Daniel Elstner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #26 from Daniel Elstner  ---
The game "Agatha Christie - And Then There Were None" is also affected by this.
Took me an entire day to track down why the game would run perfectly fine from
an NTFS partition, but locks up on certain puzzles when running from ext4...

So, yeah, this bug could easily affect a lot of users, but since it looks like
random application misbehavior/instability, few will ever make the connection.

Thus I think any work-around should be implicitly applied by Wine itself,
without requiring users to know about this arcane issue.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #27 from [e-mail] ---
The game "Kingdoms of Amalur: Reckoning" is also affected. The provided patch
solved the crash on startup for me - unlike all other suggested workarounds.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Andrew Pam  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #28 from Andrew Pam  ---
The game "Nexus: The Jupiter Incident" is also affected by this issue.  Could
we make NTFS-style lexical ordering a compatibility option in Wine, please?

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #29 from [e-mail] ---
You need to test the patch attached here. Without testing it never gets merged.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #30 from Adam Bolte  ---
I tested the patch back in October. As per my above comment, it makes the
ordering closer to Windows on NTFS (a significant improvement), but not
identical.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #31 from Andrew Pam  ---
I built my own wine from source with that patch applied and now "Nexus: The
Jupiter Incident" runs perfectly.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #32 from Robert Walker  ---
(In reply to super_man from comment #29)
> You need to test the patch attached here. Without testing it never gets
> merged.

The patch is great but it should be:
+    int ret = CompareStringOrdinal( ....
+                                    TRUE );
as NTFS is a case insensitive file-system - which Wine should emulate...
I see all the files in the original bug report started upper case - probably
why this minor issue was missed...

The patch fixes the issue with directory sorting in the Steam client
backup/restore dialog (which is frankly a pain in the ass at the moment)...

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #33 from Józef Kucia  ---
(In reply to super_man from comment #29)
> You need to test the patch attached here. Without testing it never gets
> merged.

This is just a debug patch to make it easier to confirm that an application is
affected by this bug. I have no intention to submit it for inclusion.

This issue is mostly an application bug, i.e. the affected applications exhibit
the same behavior on Windows when other file system is used (e.g. FAT).
Moreover, I'm not aware of a clean and nice way to workaround this bug in a
general case.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #34 from Sebastian Lackner  ---
This issue should be fixed with
http://source.winehq.org/git/wine.git/patch/12fc123338f7af601d3fe76b168a644f...,
could you please retest?

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #35 from Béla Gyebrószki  ---
(In reply to Sebastian Lackner from comment #34)
> This issue should be fixed with
> http://source.winehq.org/git/wine.git/patch/
> 12fc123338f7af601d3fe76b168a644fcd7e1362, could you please retest?

Confirmed, TAGAP and TAGAP 2 don't have the missing textures problem in
wine-1.9.9-67-g9eaa372.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #36 from Robert Walker  ---
(In reply to Sebastian Lackner from comment #34)
> This issue should be fixed with
> http://source.winehq.org/git/wine.git/patch/
> 12fc123338f7af601d3fe76b168a644fcd7e1362, could you please retest?

Tested wine-1.9.9-118-ge1970c8 ...

I can confirm the Steam Client backup/restore browser is also now sorting
directories!! Great stuff.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |12fc123338f7af601d3fe76b168
                   |                            |a644fcd7e1362
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #37 from Sebastian Lackner  ---
(In reply to Béla Gyebrószki from comment #35)
> Confirmed, TAGAP and TAGAP 2 don't have the missing textures problem in
> wine-1.9.9-67-g9eaa372.

(In reply to Robert Walker from comment #36)
> Tested wine-1.9.9-118-ge1970c8 ...
>
> I can confirm the Steam Client backup/restore browser is also now sorting
> directories!! Great stuff.

Thanks for testing, I'm resolving this bug report as fixed. If there are still
cases which are not handled correctly, please open a new bug report for them.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #38 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.10.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/ FindNextFile to be in alphabetical order ( Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.8.x
                 CC|                            |[e-mail]

[Bug 34122] Multiple applications expects files returned by FindFirstFile/ FindNextFile to be in alphabetical order ( Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

--- Comment #39 from Michael Stefaniuc  ---
Remove 1.8.x target milestone from bugs that didn't make it into 1.8.x for one
reason or another.
This are all included in the stable 2.0 release.

[Bug 34122] Multiple applications expects files returned by FindFirstFile/ FindNextFile to be in alphabetical order ( Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

[Bug 34122] Multiple applications expects files returned by FindFirstFile/ FindNextFile to be in alphabetical order ( Civilization V with 2 expansion packs, TAGAP)

https://bugs.winehq.org/show_bug.cgi?id=34122

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #40 from Matteo Bruni  ---
*** Bug 37443 has been marked as a duplicate of this bug. ***

[Bug 34122] Multiple applications expects files returned by FindFirstFile/FindNextFile to be in alphabetical order (Civilization V with 2 expansion packs, TAGAP)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=34122

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|kernel32                    |ntdll