https://bugs.winehq.org/show_bug.cgi?id=52108
Bug ID: 52108 Summary: user32:monitor breaks user32:win on Win10 1809 Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
Created attachment 71132 --> https://bugs.winehq.org/attachment.cgi?id=71132 Windows 10 1809 "blurry popup"
On 2021-09-01 user32:monitor started breaking user32:win on Windows 10 1809:
win.c:3322: Test failed: GetActiveWindow() = 00220510 win.c:3325: Test failed: GetFocus() = 00000000 win.c:3337: Test failed: GetFocus() = 00000000 win.c:3340: Test failed: GetFocus() = 00000000 win.c:3343: Test failed: GetFocus() = 00000000 win.c:3346: Test failed: GetActiveWindow() = 00220510 win.c:3350: Test failed: GetFocus() = 00000000 win.c:3353: Test failed: GetFocus() = 00000000 win.c:4047: Test failed: hwnd 004A050A/003600CA message 0737 win.c:4052: Test failed: hwnd 003600CA/003600CA message 0202 win.c:4057: Test failed: hwnd 003600CA/003600CA message 0203 win.c:4061: Test failed: message 0202 available
https://test.winehq.org/data/patterns.html#user32:win
A bisect shows that the failures started with this commit:
commit 2d51077a22b7d8faa9587d02a84181f58d1203aa Author: Zhiyi Zhang zzhang@codeweavers.com AuthorDate: Wed Sep 1 14:37:21 2021 +0800
user32/tests: Add DisplayConfigSetDeviceInfo() tests.
Test that DisplayConfigSetDeviceInfo() can be used for getting and setting display DPI.
Signed-off-by: Zhiyi Zhang zzhang@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
What happens is that the new display tests cause Windows 10 1809 to display a notification that the "apps might be blurry". This notification stays up after user32:monitor completes and then steals the focus from the user32:win tests and causes them to fail.
So there's not really anything wrong in either user32:monitor nor user32:win but this still causes test failures :-(
https://bugs.winehq.org/show_bug.cgi?id=52108
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, source, | |testcase Regression SHA1| |2d51077a22b7d8faa9587d02a84 | |181f58d1203aa
https://bugs.winehq.org/show_bug.cgi?id=52108
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=52108
--- Comment #1 from Zhiyi Zhang zzhang@codeweavers.com --- Hi François, you can add a registry entry by executing reg add "HKCU\Control Panel\Desktop" /v IgnorePerProcessSystemDPIToast /t REG_DWORD /d 1 /f to disable the nofication and then remake the VM image.
https://bugs.winehq.org/show_bug.cgi?id=52108
--- Comment #2 from François Gouget fgouget@codeweavers.com --- That works and it looks like it does not require a logout+login or a reboot to take effect.
So then would it work to set this registry value at the start of the test and restore it when it ends? I would prefer that approach as it would make the test more resilient.
https://bugs.winehq.org/show_bug.cgi?id=52108
--- Comment #3 from Zhiyi Zhang zzhang@codeweavers.com --- (In reply to François Gouget from comment #2)
That works and it looks like it does not require a logout+login or a reboot to take effect.
So then would it work to set this registry value at the start of the test and restore it when it ends? I would prefer that approach as it would make the test more resilient.
It's probably alright. Although I vaguely remember removing the registry key will only take effect after a reboot. Adding the key takes effect immediately though.
https://bugs.winehq.org/show_bug.cgi?id=52108
--- Comment #4 from François Gouget fgouget@codeweavers.com --- According to the tests I have done both adding and removing the value takes effect immediately (or at least in the processes that are started after).
https://bugs.winehq.org/show_bug.cgi?id=52108
--- Comment #5 from Zhiyi Zhang zzhang@codeweavers.com --- (In reply to François Gouget from comment #4)
According to the tests I have done both adding and removing the value takes effect immediately (or at least in the processes that are started after).
No problem then.
https://bugs.winehq.org/show_bug.cgi?id=52108
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |François Status|NEW |RESOLVED
--- Comment #6 from Zhiyi Zhang zzhang@codeweavers.com --- Fixed by d16998e0c7e185ae9125e44fbf2e700d869d6127. Thanks, François, for spotting this.
https://bugs.winehq.org/show_bug.cgi?id=52108
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1|François |d16998e0c7e185ae9125e44fbf2 | |e700d869d6127
https://bugs.winehq.org/show_bug.cgi?id=52108
--- Comment #7 from François Gouget fgouget@codeweavers.com --- Yay. Thanks for the fix!
https://bugs.winehq.org/show_bug.cgi?id=52108
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.0-rc6.
-
WineHQ Bugzilla