[Bug 33999] New: IncrediMail crashes on startup (GetNextDlgTabItem shouldn't return NULL?)

http://bugs.winehq.org/show_bug.cgi?id=33999

Bug #: 33999
           Summary: IncrediMail crashes on startup (GetNextDlgTabItem
                    shouldn't return NULL?)
           Product: Wine
           Version: 1.6-rc4
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

After working around bug 33996 with 'winetricks wsh56vb vcrun2005',
and bug 33998 with 'winetricks ie7', it eventually finishes its very
long 'configuring' progress bar.  The next dialog crashes when you click
'next',
with:

Unhandled exception: page fault on read access to 0x00000020 in 32-bit code
(0x25ff6766).

+relay,+seh reveals:

006e:Ret  user32.GetNextDlgTabItem() retval=00000000 ret=67b5438d
trace:seh:raise_exception code=c0000005 flags=0 addr=0x67b54393 ip=67b54393
tid=006e

And applying the patch
http://marc.info/?l=wine-patches&m=127045782322161&q=raw
"user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found"
by Mikhail Maroukhine works around the problem.

Tested with
f05f8f39b559f2763f9e917dacb15c225357e7c4  IncrediMailSetup.exe

[Bug 33999] IncrediMail crashes on startup (GetNextDlgTabItem shouldn't return NULL?)

https://bugs.winehq.org/show_bug.cgi?id=33999

--- Comment #1 from Austin English  ---
This is your friendly reminder that there has been no bug activity for over a
year. Is this still an issue in current (1.7.37 or newer) wine? If so, please
attach the terminal output in 1.7.37 (see http://wiki.winehq.org/FAQ#get_log).

[Bug 33999] IncrediMail crashes on startup (GetNextDlgTabItem shouldn't return NULL?)

https://bugs.winehq.org/show_bug.cgi?id=33999

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33999] IncrediMail crashes on startup (GetNextDlgTabItem shouldn't return NULL?)

https://bugs.winehq.org/show_bug.cgi?id=33999

--- Comment #2 from Sebastian Lackner  ---
In the current form the patch is definitely not correct (see
https://bugs.wine-staging.com/show_bug.cgi?id=38), it introduces additional
test failures:

../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p
user32_test.exe.so dialog && touch dialog.ok
dialog.c:951: Test failed: Focus not set to label, focus=0x700a8 dialog=0x700a8
label=0x600ac
dialog.c:966: Test failed: Focus not set to label on WM_SETFOCUS, focus=0x800a8
dialog=0x800a8 label=0x700ac

Does someone still know a download link for the Incredi Mail version used to
reproduce this bug? I wasn't able to find the corresponding version.

[Bug 33999] IncrediMail crashes on startup (GetNextDlgTabItem shouldn't return NULL?)

https://bugs.winehq.org/show_bug.cgi?id=33999

--- Comment #3 from Bruno Jesus  ---
DId you try
http://www5l.incredimail.com/im/imsetup/201104120001/default/installer/fulls...
?

[Bug 33999] IncrediMail crashes on startup (GetNextDlgTabItem shouldn't return NULL?)

https://bugs.winehq.org/show_bug.cgi?id=33999

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail] ---
winetricks -q wsh56vb vcrun2005 is still needed to install the application
without any errors.

The configuration state lasts quite long.

it crashes with error at 83%

wine 1.7.52

[Bug 33999] IncrediMail 6.x crashes when pressing 'Next' button in initial configuration dialog ('GetNextDlgTabItem( hDlg, NULL, FALSE)' shouldn't return NULL)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=33999

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www5l.incredimail.co
                   |                            |m/im/imsetup/201104120001/d
                   |                            |efault/installer/fullsetup/
                   |                            |IncrediMailSetup.exe
                 CC|                            |[e-mail]
            Summary|IncrediMail crashes on      |IncrediMail 6.x crashes
                   |startup (GetNextDlgTabItem  |when pressing 'Next' button
                   |shouldn't return NULL?)     |in initial configuration
                   |                            |dialog ('GetNextDlgTabItem(
                   |                            |hDlg, NULL, FALSE)'
                   |                            |shouldn't return NULL)

--- Comment #5 from Anastasius Focht  ---
Hello folks,

revisiting, still present.

After 'winetricks ie7' to work around bug 26739 you can remove the overrides -
except native 'mshtml' and 'shdocvw'. For "pure" mode (all builtin) the 'Next'
button click does nothing.

--- snip ---
$ pwd
/home/focht/.wine/drive_c/Program Files/IncrediMail/Bin

$ WINEDEBUG=+seh,+relay,+win,+msg wine ./IncMail.exe >>log.txt 2>&1
...
01dd:Call PE DLL (proc=0x67b856cf,module=0x67b30000
L"ImLookU.dll",reason=PROCESS_ATTACH,res=0x32fd24) 
...
01dd:trace:win:WIN_CreateWindowEx L"" #8002 ex=00010020 style=40000044 0,0
515x382 parent=0x160274 menu=(nil) inst=0x27f0000 params=(nil)
01dd:trace:win:dump_window_styles style: WS_CHILD 00000044
01dd:trace:win:dump_window_styles exstyle: WS_EX_TRANSPARENT
WS_EX_CONTROLPARENT
01dd:trace:win:WIN_SetWindowLong 0x140294 -12 0 W
01dd:Call hook proc 0x78311e8d (id=WH_CBT,code=3,wp=00140294,lp=0032e7f0) 
...
01dd:Call user32.GetWindowLongW(00140294,ffffffec) ret=7833ab45
01dd:Ret  user32.GetWindowLongW() retval=00010020 ret=7833ab45
01dd:Call user32.GetNextDlgTabItem(00140294,00000000,00000000) ret=67b5438d
01dd:Ret  user32.GetNextDlgTabItem() retval=00000000 ret=67b5438d
01dd:trace:seh:raise_exception code=c0000005 flags=0 addr=0x67b54393
ip=67b54393 tid=01dd
01dd:trace:seh:raise_exception  info[0]=00000000
01dd:trace:seh:raise_exception  info[1]=00000020
01dd:trace:seh:raise_exception  eax=00000000 ebx=01871190 ecx=00000000
edx=00000000 esi=01871190 edi=00000002
01dd:trace:seh:raise_exception  ebp=0186bcd0 esp=0032eed4 cs=0023 ds=002b
es=002b fs=0063 gs=006b flags=00010246 
...
--- snip ---

Base=67B30000
Module=imlooku.dll
Path=C:\Program Files\IncrediMail\Bin\ImLookU.dll

--- snip ---
67B54370 | push esi                      
67B54371 | mov esi,ecx                   
67B54373 | call 0x67B8464C               ; CWnd::GetExStyle()
67B54378 | push 0                        ; bPrevious = FALSE
67B5437A | test eax,10000                ; WS_EX_CONTROLPARENT
67B5437F | mov eax,dword ptr ds:[esi+20] 
67B54382 | push 0                        ; hCtl = NULL
67B54384 | je imlooku.67B543AC           
67B54386 | push eax                      ; hDlg
67B54387 | call dword ptr ds:[67B90F40]  ; user32.GetNextDlgTabItem()
67B5438D | push eax                      
67B5438E | call                          ; CWnd::FromHandle()
67B54393 | mov ecx,dword ptr ds:[eax+20] ; pWnd->m_hWnd == NULL *boom*
67B54396 | mov edx,dword ptr ds:[esi+20] 
67B54399 | push 1                        
67B5439B | push ecx                      
67B5439C | push 28                       ; WM_NEXTDLGCTL
67B5439E | push edx                      
67B5439F | call dword ptr ds:[67B91048]  ; user32.SendMessageW()
67B543A5 | mov eax,1                     
67B543AA | pop esi                       
67B543AB | ret                           
67B543AC | push 28                       ; WM_NEXTDLGCTL
67B543AE | push eax                      
67B543AF | call dword ptr ds:[67B91048]  ; user32.SendMessageW()
67B543B5 | mov eax,1                     
67B543BA | pop esi                       
67B543BB | ret                           
--- snip ---

$ sha1sum IncrediMailSetup.exe 
e943e5dab371312420e686df6dda7811e5857b0e  IncrediMailSetup.exe

$ du -sh IncrediMailSetup.exe 
12M    IncrediMailSetup.exe

$ wine --version
wine-5.0-rc5-42-g0cbadb716d

Regards