[Bug 36810] New: valgrind shows a definite leak in winspool.drv/tests/info.c

https://bugs.winehq.org/show_bug.cgi?id=36810

Bug ID: 36810
           Summary: valgrind shows a definite leak in
                    winspool.drv/tests/info.c
           Product: Wine
           Version: 1.7.20
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: wineps.drv
          Assignee: [e-mail]
          Reporter: [e-mail]

==27687== 22 bytes in 1 blocks are definitely lost in loss record 139 of 616
==27687==    at 0x7BC4C6DF: notify_alloc (heap.c:255)
==27687==    by 0x7BC50F23: RtlAllocateHeap (heap.c:1716)
==27687==    by 0x4D098B1: strdupWtoA (info.c:405)
==27687==    by 0x4D11AC1: DocumentPropertiesA (info.c:2379)
==27687==    by 0x4BBD700: test_DocumentProperties (info.c:2680)
==27687==    by 0x4BBF42C: func_info (info.c:3030)
==27687==    by 0x4BC02B1: run_test (test.h:584)
==27687==    by 0x4BC069F: main (test.h:654)

continuation of bug 36604

[Bug 36810] valgrind shows a definite leak in winspool.drv/tests/info.c

https://bugs.winehq.org/show_bug.cgi?id=36810

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Bruno Jesus  ---
Created attachment 48887
  --> https://bugs.winehq.org/attachment.cgi?id=48887
patch

Please try the attached patch.

[Bug 36810] valgrind shows a definite leak in winspool.drv/tests/info.c

https://bugs.winehq.org/show_bug.cgi?id=36810

--- Comment #2 from Austin English  ---
I can't get the bug to reliably occur to test the patch :/. It only seems to
occur with a full make test, but not the past two I've run (and it takes
several hours to run).

[Bug 36810] valgrind shows a definite leak in winspool.drv/tests/info.c

https://bugs.winehq.org/show_bug.cgi?id=36810

--- Comment #3 from Bruno Jesus  ---
No problem, the leak is visible in the source code so I'll send the patch.

[Bug 36810] valgrind shows a definite leak in winspool.drv/tests/info.c

https://bugs.winehq.org/show_bug.cgi?id=36810

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |daaa4c40d46e08e2bb3ab5ddb58
                   |                            |89bdc6e782594
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Austin English  ---
(In reply to Bruno Jesus from comment #3)
> No problem, the leak is visible in the source code so I'll send the patch.

Fixed by
https://source.winehq.org/git/wine.git/commitdiff/daaa4c40d46e08e2bb3ab5ddb5...,
thanks Bruno.

[Bug 36810] valgrind shows a definite leak in winspool.drv/tests/info.c

https://bugs.winehq.org/show_bug.cgi?id=36810

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.22.