[Bug 55070] New: winemenubuilder adds incorrect prefix on 32bit only Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

Bug ID: 55070
           Summary: winemenubuilder adds incorrect prefix on 32bit only
                    Wine
           Product: Wine
           Version: 8.10
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

On 32bit (x86 only) wine, the Exec= line automatically created in an
application's .desktop file is incorrect and can not be launched.

eg: /home/gman/.local/share/applications/wine/Programs/7-Zip/7-Zip\ File\
Manager.desktop
```
[Desktop Entry]
Name=7-Zip File Manager
Exec=env WINEPREFIX="/home/gman/.wine/dosdevices/f:/home/gman/.wine" wine
C:\\users\\gman\\AppData\\Roaming\\Microsoft\\Windows\\Start\
Menu\\Programs\\7-Zip\\7-Zip\ File\ Manager.lnk
Type=Application
StartupNotify=true
Icon=EA23_7zFM.0
StartupWMClass=7zfm.exe
```

64bit (x64 with WOW64) wine does not have this issue and the generated .desktop
file will be correct.

eg: /home/gman/.local/share/applications/wine/Programs/7-Zip/7-Zip\ File\
Manager.desktop
```
[Desktop Entry]
Name=7-Zip File Manager
Exec=env WINEPREFIX="/home/gman/.wine" wine
C:\\users\\gman\\AppData\\Roaming\\Microsoft\\Windows\\Start\
Menu\\Programs\\7-Zip\\7-Zip\ File\ Manager.lnk
Type=Application
StartupNotify=true
Icon=EA23_7zFM.0
StartupWMClass=7zfm.exe
```

Both are with fresh wine installs with fresh/clean prefixes. Confirmed on
multiple devices.

[Bug 55070] winemenubuilder adds incorrect prefix on 32bit only Wine

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #1 from [e-mail] ---
It appears that this can happen on both my x86 only and x64 WOW64 builds of
wine-8.10. I am unable to determine what causes the issue since I am using the
exact same binary build on one system (running Ubuntu Focal) that does not have
the issue, and another system (running Ubuntu Bionic) that has the issues, and
another system (running Debian Bullseye) that has the issue.

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|winemenubuilder adds        |winemenubuilder adds
                   |incorrect prefix on 32bit   |incorrect prefix
                   |only Wine                   |

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #2 from Austin English  ---
Is this a regression?

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #3 from [e-mail] ---
Yes this is a regression. This issue did not exist in the previous wine version
used (wine 5.10)

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #4 from [e-mail] ---
The issue looks to have been reported in the wine forum as well as early as Jun
2022 using winehq-stable apt package which would have been wine 6.0.4 at the
time.
https://forum.winehq.org/viewtopic.php?t=36639

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P1
           Severity|normal                      |major

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #5 from [e-mail] ---
Can confirm again Wine-5.13 does not have the bug. I do not really want to
build fully and continue to bisect the bug. The bug was likely introduced
between after 5.13 and before or in the 6.0.4 release.

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #6 from [e-mail] ---
Issue confirmed still present in Wine-8.11 release

my builds can be found here incase it ends up being something that you can not
replicate in your own builds

options enabled: `--enable-archs=i386,x86_64 --prefix=/opt/wine-8.11`
https://github.com/Pi-Apps-Coders/files/releases/download/large-files/wine-8...
options enabled: `--prefix=/opt/wine-8.11`
https://github.com/Pi-Apps-Coders/files/releases/download/large-files/wine-i...

as noted in this github comment
https://github.com/ptitSeb/box64/issues/465#issuecomment-1604963631 both
systems that display the bug are running off of SD/eMMC while the ones that do
not diplay the bug are using NVMe SSDs. This might be unrelated but I thought I
would at least mention it incase Wine is doing something different depending on
the detected storage medium (which would be strange imho)

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #7 from Alexandre Julliard  ---
(In reply to dofficialgman from comment #6)
> https://github.com/ptitSeb/box64/issues/465#issuecomment-1604963631 both
> systems that display the bug are running off of SD/eMMC while the ones that
> do not diplay the bug are using NVMe SSDs. This might be unrelated but I
> thought I would at least mention it incase Wine is doing something different
> depending on the detected storage medium (which would be strange imho)

Actually it's likely to be something with the storage setup. I'd suggest
comparing mounted devices, permissions, drive symlinks, etc. between the
working and non-working cases.

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #8 from [e-mail] ---
> Actually it's likely to be something with the storage setup. I'd suggest
> comparing mounted devices, permissions, drive symlinks, etc. between the
> working and non-working cases.

Nothing seems non-standard in any of the non-working cases.
Regardless I was able to bisect the issue to last working and first non-working
wine version.

Wine-6.18 works as expected and produces a .desktop file with the following
output
```
[Desktop Entry]
Name=7-Zip File Manager
Exec=env WINEPREFIX="/home/gman/.wine" wine
C:\\windows\\command\\start.exe /Unix
/home/gman/.wine/dosdevices/c:/ProgramData/Microsoft/Windows/Start\
Menu/Programs/7-Zip/7-Zip\ File\ Manager.lnk
Type=Application
StartupNotify=true
Icon=BE44_7zFM.0
StartupWMClass=7zfm.exe
```

Wine-6.19 is the first version to have the bug and produces a .desktop file
with the following output
```
[Desktop Entry]
Name=7-Zip File Manager
Exec=env WINEPREFIX="/home/gman/.wine/dosdevices/f:/home/gman/.wine" wine
C:\\ProgramData\\Microsoft\\Windows\\Start\
Menu\\Programs\\7-Zip\\7-Zip\ File\ Manager.lnk
Type=Application
StartupNotify=true
Icon=EA23_7zFM.0
StartupWMClass=7zfm.exe
```

That limits the number of commits to look through to only 522
https://github.com/wine-mirror/wine/compare/wine-6.18...wine-6.19

And I have reason to believe this is the commit causing the issues
https://github.com/wine-mirror/wine/commit/f1d4dd7cc83d971c6e69c3f2bdffe85db...

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #9 from [e-mail] ---
Created attachment 74682
  --> https://bugs.winehq.org/attachment.cgi?id=74682
partial revert of the commit f1d4dd7cc83d971c6e69c3f2bdffe85dbcd81c0a which
changes WINEPREFIX to WINECONFIGDIR

This partial revert patch fixes the issue. The root source of the bug is likely
`WINECONFIGDIR` being set incorrectly somewhere else in source or a broken
`wine_get_unix_file_name`.

With this patch applied to Wine-6.19, the output becomes
```
[Desktop Entry]
Name=7-Zip File Manager
Exec=wine C:\\ProgramData\\Microsoft\\Windows\\Start\
Menu\\Programs\\7-Zip\\7-Zip\ File\ Manager.lnk
Type=Application
StartupNotify=true
Icon=EA23_7zFM.0
StartupWMClass=7zfm.exe
```

[Bug 55070] winemenubuilder adds incorrect prefix

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55070

--- Comment #10 from [e-mail] ---
Anyone looking into this or found what the cause it?
Having to perform this partial revert every time so that wine can be usable on
desktop linux is quite annoying and the patch needed to be updated in Wine 8.20
due to file changes.