[Bug 27970] New: cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Summary: cmd's attrib command doesn't accept multiple
                    attributes
           Product: Wine
           Version: 1.3.25
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: cmd
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

And it doesn't do the right thing with "attrib +r" or "attrib +s +r".

Here's a draft patch for this.  Not yet finished.

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

--- Comment #1 from Dan Kegel  2011-08-03 13:15:29 CDT ---
Created an attachment (id=35798)
 --> (http://bugs.winehq.org/attachment.cgi?id=35798)
Draft patch

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35798|0                           |1
        is obsolete|                            |

--- Comment #2 from Dan Kegel  2011-08-05 23:19:40 CDT ---
Created an attachment (id=35828)
 --> (http://bugs.winehq.org/attachment.cgi?id=35828)
almost ready patch

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Frédéric Delanoy  2011-10-08 08:48:17 CDT ---
(In reply to comment #2)
> Created attachment 35828 [details]
> almost ready patch

You'd probably want to update your patch, since attrib was moved to an external
command.
Also, there's now an attrib test section in test_builtins.cmd, so your new
tests should be moved there.

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Christian Costa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Christian Costa  2012-03-14 14:59:57 CDT ---
http://source.winehq.org/git/wine.git/commitdiff/d59538f977819149b152f508a36....

I'm just realizing there was a patch with some tests. :|
That would be good to port them on top of mine.

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |d59538f977819149b152f508a36
                   |                            |6892003c5d919
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #5 from Jerome Leclanche  2012-03-15 11:48:00 CDT ---
Fixed

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #6 from Frédéric Delanoy  2012-03-15 12:00:55 CDT ---
(In reply to comment #5)
> Fixed

As comment 4 suggested, tests would probably need to be added before closing
this bug.

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Alexandre Julliard  2012-03-15 13:44:05 CDT ---
Tests would be good of course, but the bug is fixed.

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

--- Comment #8 from Alexandre Julliard  2012-03-16 14:08:21 CDT ---
Closing bugs fixed in 1.5.0.

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2012-03-16 17:10:59 CDT ---
Really closing bugs fixed in 1.5.0.

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.4.x

[Bug 27970] cmd's attrib command doesn't accept multiple attributes

http://bugs.winehq.org/show_bug.cgi?id=27970

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.4.x                       |---