[Bug 16611] New: Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

Summary: Regression: WoW crashes on startup in git
           Product: Wine
           Version: CVS/GIT
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=18162)
 --> (http://bugs.winehq.org/attachment.cgi?id=18162)
Crashlog

Tested in today's git. Log attached.

Crashes on 9800GTX+.

878c2a83325b66cea79c24dc7379e5a6ee976044 is first bad commit
commit 878c2a83325b66cea79c24dc7379e5a6ee976044
Author: Vincent Pelletier 
Date:   Mon Dec 22 21:56:14 2008 +0100

user32: Fix SPI_GETMOUSESPEED and SPI_SETMOUSESPEED.

:040000 040000 560e75ac4aead92227abf3bbb013abce85f82fd9
420d368616bb19877d5395a87c74df658211a476 M      dlls

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

Adys  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Adys   2008-12-23 23:32:48 ---
CC Vincent Pelletier

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Keywords|                            |regression
            Version|CVS/GIT                     |1.1.11

--- Comment #2 from Jeff Zaroyko   2008-12-23 23:36:27 ---
The CVS/GIT tag is deprecated.

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

--- Comment #3 from Vincent Pelletier   2008-12-24 02:19:32 ---
Crash reproduced here. Sorry for the bug.
Extract of output:

Unhandled exception: page fault on read access to 0x0000000a in 32-bit code
(0x7ec9edca).
[...]
Backtrace:
=>0 0x7ec9edca SystemParametersInfoW+0xd7a(uiAction=113, uiParam=0,
pvParam=0xa, fWinIni=0) [/home/vincent/git/wine/dlls/user32/sysparams.c:2174]
in user32 (0x0039e9c8)

0x0000000a is pvParam value, which I dereferenced in that patch, but it's the
value itself...
Dereference should be replaced either by PtrToInt macro call (which I replaced
without paying enough attention, obviously) or by an equivalent casting to UINT
(to avoid a signedness difference at build).

PtrToInt is defined here:
include/basetsd.h:#define PtrToInt(p)             ((INT)(INT_PTR)(p))

Sadly, I won't have access to a machine where I can test this change before
monday. Could someone make that change and test it instead ?

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Dmitry Timoshkov   2008-12-24 04:23:31 ---
I sent a patch:
http://www.winehq.org/pipermail/wine-patches/2008-December/066689.html

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

Karsten Elfenbein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Karsten Elfenbein   2008-12-24 06:25:20 ---
the suggested patch in comment #4 fixes the crash issue

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
           Keywords|                            |patch
         Resolution|                            |FIXED

--- Comment #6 from Austin English   2008-12-24 16:53:00 ---
Alexandre committed a fix. Reopen if not fixed.

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

--- Comment #7 from Adys   2008-12-24 22:00:27 ---
(In reply to comment #6)
> Alexandre committed a fix. Reopen if not fixed.

Confirmed fixed

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2009-01-02 10:34:26 ---
Closing bugs fixed in 1.1.12.

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |878c2a83325b66cea79c24dc737
                   |                            |9e5a6ee976044

[Bug 16611] Regression: WoW crashes on startup in git

http://bugs.winehq.org/show_bug.cgi?id=16611

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |77ca32cf71903c090c157f3f970
                   |                            |7050fcfe49dcb