[Bug 20695] New: Cannot scroll documents being compared in winmerge

Summary: Cannot scroll documents being compared in winmerge Product: Wine Version: 1.1.32 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: joao.eiras@gmail.com

1. Get Winmerge http://winmerge.org/downloads/ (I'm using 2.12.4) 2. Install MFC71U.DLL and MSVCP71.dll (winetricks is good)

3. Open WinMerge and compare two documents

Notice how the double document view cannot be scrolled horizontally using the scrollbar. IT works though if you select text and drag the mouse.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

14 Nov 14 Nov

3:50 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download

wine-bugs＠winehq.org

15 Nov 15 Nov

1:18 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Wylda wylda@volny.cz changed:

--- Comment #1 from Wylda wylda@volny.cz 2009-11-14 19:18:58 ---

No need for winetricks to bisect this bug report...

1. Confirming, please consider UNCONFIRMED->NEW and KEYWORDS: +REGRESSION

2. Did a regression test between 1.1.16 and 1.1.17:

032356ec379fbac733d4009381338e882672126e is first bad commit commit 032356ec379fbac733d4009381338e882672126e Author: Nikolay Sivov bunglehead@gmail.com Date: Wed Mar 4 17:38:41 2009 -0500

user32: Disable scroll bar control window when both buttons disabled.

:040000 040000 71bf079bf85ee2f7bb34fca71a7d348c943f1716 3b1f435b113e3cef7ea46c6b926fe9a7f3bf8f85 M dlls

3. No other bug report suffers from this commit.

4. Revert of this patch on top of wine-1.1.17 makes that problem goes away.

5. Adding author of this patch to CC.

--private keyword: bisected

wine-bugs＠winehq.org

2:12 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Nikolay Sivov bunglehead@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |user32

--- Comment #2 from Nikolay Sivov bunglehead@gmail.com 2009-11-14 20:12:01 --- 2Wylda:

Could you please manually revert patch part from user32/scroll.c to see that it helps on current 1.1.33?

wine-bugs＠winehq.org

2:41 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #3 from Wylda wylda@volny.cz 2009-11-14 20:41:06 --- (In reply to comment #2)

Could you please manually revert patch part from user32/scroll.c to see that it helps on current 1.1.33?

Hi Nikolay, yes reverting commit 032356ec379fbac733d4009381338e882672126e on top of 1.1.33 helps, i.e. horizontal scrolling works again after revert.

wine-bugs＠winehq.org

24 Nov 24 Nov

10:20 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Nikolay Sivov bunglehead@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression

wine-bugs＠winehq.org

25 Nov 25 Nov

9:02 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Nikolay Sivov bunglehead@gmail.com changed:

wine-bugs＠winehq.org

9:12 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Nikolay Sivov bunglehead@gmail.com changed:

--- Comment #4 from Nikolay Sivov bunglehead@gmail.com 2009-11-25 03:12:57 --- I can confirm this.

wine-bugs＠winehq.org

28 Feb 28 Feb

midnight

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #5 from Wylda wylda@volny.cz 2010-02-27 18:00:25 ---

This bisected regression is still not fixed in wine-1.1.39-163-g583f0f0.

wine-bugs＠winehq.org

17 Apr 17 Apr

8:15 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #6 from Wylda wylda@volny.cz 2010-04-17 15:15:16 ---

This regression (bisected) is still present in wine-1.1.43.

wine-bugs＠winehq.org

10 May 10 May

8:05 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #7 from Wylda wylda@volny.cz 2010-05-10 15:05:38 ---

This regression (bisected) is still present in wine-1.1.44-72-g658209b.

Nikolay, don't you want me to test some of your patch for this issue?

wine-bugs＠winehq.org

8:11 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #8 from Nikolay Sivov bunglehead@gmail.com 2010-05-10 15:11:20 --- (In reply to comment #7)

This regression (bisected) is still present in wine-1.1.44-72-g658209b.

Nikolay, don't you want me to test some of your patch for this issue?

No, but I'm going to fix it. Well, try at least.

wine-bugs＠winehq.org

20 Jun 20 Jun

4:52 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #9 from Wylda wylda@volny.cz 2010-06-20 11:52:06 ---

This regression (bisected) is still present in wine-1.2-rc4.

wine-bugs＠winehq.org

22 Aug 22 Aug

9:07 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #10 from Wylda wylda@volny.cz 2010-08-22 04:07:22 ---

This regression (bisected) is still present in wine-1.3.1.

wine-bugs＠winehq.org

22 Jul 22 Jul

6:51 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

André H. nerv@dawncrow.de changed:

--- Comment #11 from André H. nerv@dawncrow.de 2011-07-22 13:51:26 CDT --- This regression (bisected) is still present in wine-1.3.25.

wine-bugs＠winehq.org

11 Aug 11 Aug

8:15 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Henri Verbeet hverbeet@gmail.com changed:

wine-bugs＠winehq.org

2 Dec 2 Dec

12:57 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

A Wine user RandomAccountName@mail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |RandomAccountName@mail.com

wine-bugs＠winehq.org

10 Dec 10 Dec

11:40 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #12 from Wylda wylda@volny.cz 2011-12-10 05:40:47 CST ---

This regression (bisected) is still present in wine-1.3.34-202-gb0f704d.

wine-bugs＠winehq.org

9 Feb 9 Feb

8:21 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Andrew Eikum aeikum@codeweavers.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum@codeweavers.com

--- Comment #13 from Andrew Eikum aeikum@codeweavers.com 2012-02-09 14:21:12 CST --- The problem here is SetScrollInfo can set the scrollbar's flags, but doesn't En/Disable the scrollbar itself. So the flags and actual window state are not in sync and we end up with this sequence:

EnableScrollBar(ESB_DISABLE_BOTH) infoPtr->flags = ESB_DISABLE_BOTH EnableWindow(FALSE)

SetScrollInfo(...) ... infoPtr->flags = ESB_ENABLE_BOTH

EnableScrollBar(ESB_ENABLE_BOTH) infoPtr->flags == ESB_ENABLE_BOTH => return

So some possible fixes: *) SetScrollInfo() is setting the flags incorrectly, or *) EnableScrollBar() should use some other method to determine if EnableWindow() needs to be called, or *) SetScrollInfo() should En/Disable the window to keep the flags in sync

I'll keep looking, but thought maybe something would be obvious to Nikolay.

wine-bugs＠winehq.org

10 Feb 10 Feb

7:41 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #14 from Nikolay Sivov bunglehead@gmail.com 2012-02-10 01:41:02 CST --- (In reply to comment #13)

So some possible fixes: *) SetScrollInfo() is setting the flags incorrectly, or *) EnableScrollBar() should use some other method to determine if EnableWindow() needs to be called, or *) SetScrollInfo() should En/Disable the window to keep the flags in sync

I'll keep looking, but thought maybe something would be obvious to Nikolay.

Interesting, second case seems to work fine, we even have some tests for that, probably incomplete.

I feel like last part is most likely a case, needs some testing to be done. I can do it this weekend but if you have time today (Friday) please do.

wine-bugs＠winehq.org

19 May 19 May

2:42 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #15 from Wylda wylda@volny.cz 2012-05-19 09:42:10 CDT ---

This regression (bisected) is still present in wine-1.5.4-185-g6c51c1b.

Which one of these three choices in comment #13 won? ;)

wine-bugs＠winehq.org

2:47 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #16 from Nikolay Sivov bunglehead@gmail.com 2012-05-19 09:47:01 CDT --- (In reply to comment #15)

Which one of these three choices in comment #13 won? ;)

I had no chance to spend more time and fix that, I think Andrew is right about desynchronized flags and style.

wine-bugs＠winehq.org

7 Aug 7 Aug

11:49 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #17 from Austin English austinenglish@gmail.com 2013-08-07 18:49:41 CDT --- http://sourceforge.net/projects/winmerge/files/stable/2.12.4/WinMerge-2.12.4...

Still in 1.7.0.

wine-bugs＠winehq.org

27 Aug 27 Aug

7:20 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Luke lukebenes@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |lukebenes@hotmail.com

--- Comment #18 from Luke lukebenes@hotmail.com --- This regression is still present in wine-1.7.24.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

17 Nov 17 Nov

7:17 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Saulius K. saulius2@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |saulius2@gmail.com

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

15 Nov 15 Nov

7:32 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #19 from Nikolay Sivov bunglehead@gmail.com --- Hi, Andrew.

I looked a bit at this today, and I'm unable to catch this sequence that you described in comment 13 - which is ESB_ENABLE_BOTH when flags are already enabled while window itself is not. I'm attaching patch that traces this condition, and it doesn't trigger for me.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7:32 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #20 from Nikolay Sivov bunglehead@gmail.com --- Created attachment 52764 --> https://bugs.winehq.org/attachment.cgi?id=52764 trace patch

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

21 Nov 21 Nov

11:59 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #21 from Wylda wylda@volny.cz --- (In reply to Nikolay Sivov from comment #19)

...condition, and it doesn't trigger for me.

Hi Nikolay, i applied your patch to wine-1.7.13 and it triggers for me. When i click on OK in open dialog, i immediately get following two lines:

err:scroll:EnableScrollBar flag mismatch err:scroll:EnableScrollBar flag mismatch

PS: WinMerge 2.12.4 + I tested this on "older" wine, because i had this version prepared from other testing.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

9:25 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

--- Comment #22 from Nikolay Sivov bunglehead@gmail.com --- (In reply to Wylda from comment #21)

(In reply to Nikolay Sivov from comment #19)

...
...condition, and it doesn't trigger for me.

Hi Nikolay, i applied your patch to wine-1.7.13 and it triggers for me. When i click on OK in open dialog, i immediately get following two lines:

err:scroll:EnableScrollBar flag mismatch err:scroll:EnableScrollBar flag mismatch

PS: WinMerge 2.12.4 + I tested this on "older" wine, because i had this version prepared from other testing.

Right, I can see it know, not sure why I missed that first time. Regarding directions from comment 13, I'm leaning towards second option - already have a fix locally, but it has to wait until after 1.8 is out, because this regression affects only one application so far that we're aware of, and changes to this area are potentially destabilizing.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

9:25 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Nikolay Sivov bunglehead@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs@winehq.org |bunglehead@gmail.com

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

20 Feb 20 Feb

12:43 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

[1] http://winmerge.org/downloads/source-code.php

--- Comment #23 from Luke lukebenes@hotmail.com --- Nikolay, Now that Wine 1.9 is here, could we please test your fix? WinMerge is fully Open Source.[1] Would the scrollbar code provide any hints as to what's going on here?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

24 Mar 24 Mar

4:50 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Nikolay Sivov bunglehead@gmail.com changed:

--- Comment #24 from Nikolay Sivov bunglehead@gmail.com --- Fixed with http://source.winehq.org/git/wine.git/commit/9d91fce444fab9dc408f1e3834b2b07....

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

1 Apr 1 Apr

3:06 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #25 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.9.7.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

12 Apr 12 Apr

3:01 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Michael Stefaniuc mstefani@redhat.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

3:32 p.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge

Nikolay Sivov bunglehead@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead@gmail.com |wine-bugs@winehq.org

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

16 Jun 16 Jun

9:24 a.m.

New subject: [Bug 20695] Cannot scroll documents being compared in winmerge