[Bug 18885] New: Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

Summary: Space bar doesn't work for "mantling"
           Product: Wine
           Version: 1.1.23
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

In Thief 2 and in System Shock 2 the space bar is used for "mantling", or
climbing onto a barrier -- in both these games it's necessary to hold the space
bar down until the maneuver is complete.

Unfortunately under wine this does not appear to work.  My best guess is that
the "holding" of the space bar is somehow being interrupted at the API level.

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

--- Comment #1 from Michael Abbott   2009-06-15 11:27:14 ---
Created an attachment (id=21814)
 --> (http://bugs.winehq.org/attachment.cgi?id=21814)
Result of holding space for about two seconds

This log was generated with WINEDEBUG=+key,+keyboard piped through `grep -v
'^trace:key:X11DRV_GetAsyncKeyState'` to make the result usable, and selecting
just that part of the trace generate when pressing and holding space for about
two seconds.

No wonder the game doesn't like this.

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

--- Comment #2 from Michael Abbott   2009-06-15 11:33:57 ---
Ok, the problem arises from keyboard auto-repeat -- if I disable key repeat
then the problem goes away.

Shouldn't Wine take control of this sort of thing?

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

--- Comment #3 from el   2009-06-15 18:22:07 ---
Created an attachment (id=21818)
 --> (http://bugs.winehq.org/attachment.cgi?id=21818)
log snippet

I have "Enable keyboard repeat" checked in my KDE control center and I can
mantle in SS2. I have attached a little log.

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

el  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21818|application/octet-stream    |text/plain
          mime type|                            |

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

--- Comment #4 from Michael Abbott   2009-06-16 00:54:27 ---
(In reply to comment #3)
> I have "Enable keyboard repeat" checked in my KDE control center and I can
> mantle in SS2. I have attached a little log.

Huh.  But your log also seems to show an excess(?) of space bar events (and
ends in a crash, I see...)

My window manager is xfce, but I doubt that has anything to do with anything. 
I'll check SS2 with and without key repeat enabled.

My key repeat parameters are 500ms latency, 30ms repeat interval.

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

--- Comment #5 from el   2009-06-16 05:31:14 ---
Yes, I also get a lot of log events when I hold down space.
The crash on exit is related to bug 18916 and is fixed by Henri's patch.

I tried key repeat settings like yours and also some other settings but it
always worked for me.

What happens if you bind jump to a key that never repeats (like Shift)?
Does it start working?

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

--- Comment #6 from Michael Abbott   2009-06-16 14:13:09 ---
(In reply to comment #5)
> What happens if you bind jump to a key that never repeats (like Shift)?
> Does it start working?

Yes, it does.  So somehow autorepeat is different.  Going to try SS2 now.

Ok, same behaviour as for Thief 2 for me: mantling fails if keyboard autorepeat
enabled, succeeds if it's disabled.

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

--- Comment #7 from el   2009-07-19 08:28:46 ---
http://www.winehq.org/pipermail/wine-devel/2009-July/077422.html
might be relevant to this bug report.

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

--- Comment #8 from [e-mail]  2009-07-20 12:08:13 ---
Created an attachment (id=22477)
 --> (http://bugs.winehq.org/attachment.cgi?id=22477)
keyboard-repeat.patch

Joe222's patch at http://ubuntuforums.org/showthread.php?p=7467947#post7467947
(attached) fixes the problem in wine 1.1.26 (and several versions previous to
that, also) of lockpicking in Thief 2 being very slow due to the keyrepeat
being messed up. Also seems to fix this mantling bug :)

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #9 from [e-mail]  2009-07-20 12:12:39 ---
*** This bug has been confirmed by popular vote. ***

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #10 from Vitaliy Margolen   2009-07-20 21:27:58 ---
Duplicate.

*** This bug has been marked as a duplicate of bug 18296 ***

[Bug 18885] Space bar doesn't work for "mantling"

http://bugs.winehq.org/show_bug.cgi?id=18885

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Vitaliy Margolen   2009-07-20 21:29:30 ---
Closing.