[Bug 33065] New: Make it possible to build a winetest executable with a single test

http://bugs.winehq.org/show_bug.cgi?id=33065

Bug #: 33065
           Summary: Make it possible to build a winetest executable with a
                    single test
           Product: Wine-Testbot
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Currently WineTestBot runs individual tests through TestLauncher (see
testbot/src/TestLauncher). TestLauncher is responsible for checking for
potential issues like missing dlls that could cause the test to hang on an
error dialog. However that means duplicating a lot of WineTest's code and also
that TestLauncher tends to be out of date (see bug 31609 for instance).

Building the regular winetest.exe (with all the tests) and just running one
test would result in a lot of wasted disk space and bandwidth.

So the idea would be to make it possible to build winetest.exe and to only
include the one test we want to run in the resources.

[Bug 33065] Make it possible to build a winetest executable with a single test

http://bugs.winehq.org/show_bug.cgi?id=33065

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31609, 32216

[Bug 33065] Make it possible to build a winetest executable with a single test

http://bugs.winehq.org/show_bug.cgi?id=33065

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33065] Make it possible to build a winetest executable with a single test

http://bugs.winehq.org/show_bug.cgi?id=33065

--- Comment #1 from Alexandre Julliard  2013-10-02 08:23:17 CDT ---
You can specify the list of tests in EXTRA_OBJS, something like

cd programs/winetest; make winetest.exe EXTRA_OBJS=advapi32_test.res

[Bug 33065] Make it possible to build a winetest executable with a single test

http://bugs.winehq.org/show_bug.cgi?id=33065

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 33065] Make it possible to build a winetest executable with a single test

https://bugs.winehq.org/show_bug.cgi?id=33065

--- Comment #2 from François Gouget  ---
Setting EXTRA_OBJS does not work anymore.

[Bug 33065] Make it possible to build a winetest executable with a single test

https://bugs.winehq.org/show_bug.cgi?id=33065

--- Comment #3 from Alexandre Julliard  ---
It's not being used yet, right?

[Bug 33065] Make it possible to build a winetest executable with a single test

https://bugs.winehq.org/show_bug.cgi?id=33065

--- Comment #4 from François Gouget  ---
No :-(

[Bug 33065] Make it possible to build a winetest executable with a single test

https://bugs.winehq.org/show_bug.cgi?id=33065

--- Comment #5 from Alexandre Julliard  ---
OK, good ;-)

Nowadays you can achieve the same thing with:

rm programs/winetest/Makefile
make programs/winetest/Makefile ALL_TEST_RESOURCES=advapi32_test.res

But this will probably change again with future build system improvements.

[Bug 33065] Make it possible to build a winetest executable with a single test

https://bugs.winehq.org/show_bug.cgi?id=33065

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #6 from François Gouget  ---
This issue was created when the goal was to eliminate TestLauncher.
However this does not seem desirable or necessary anymore. See this wine-devel
discussion for the rationale:
https://www.winehq.org/pipermail/wine-devel/2017-April/117163.html

Note that all the issues mentioned at the end of that email have been resolved,
except for the dll check. And regarding that WineTest is actually worse (see
bug 45032).

So I'm closing this bug.

[Bug 33065] Make it possible to build a winetest executable with a single test

https://bugs.winehq.org/show_bug.cgi?id=33065

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Austin English  ---
Closing.

[Bug 33065] Make it possible to build a winetest executable with a single test

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=33065

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|32216                       |