[Bug 20153] New: AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

Summary: AutoCAD 2008: Icons in popup menus too big
           Product: Wine
           Version: 1.1.30
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=23750)
 --> (http://bugs.winehq.org/attachment.cgi?id=23750)
AutoCAD 2008 Icons in PopUp menu

Attachment explains everything. 
This is definitely an regression (it worked good in Wine 1.1.29). I suspect
that patch from bug #175 could cause it. Is regression test required?

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #1 from Nikolay Sivov   2009-09-25 15:12:03 ---
(In reply to comment #0)
> This is definitely an regression (it worked good in Wine 1.1.29). I suspect
> that patch from bug #175 could cause it. Is regression test required?

Actually yes, but for a start you could just revert this commit and report.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #2 from NSLW   2009-09-26 06:09:37 ---
(In reply to comment #1)
> Actually yes, but for a start you could just revert this commit and report.

Reverting commit 32ca9b27c376af255dacd67c2744b3b5285b8cf1 makes icons in
AutoCAD 2008 PopUp menu look correct again.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |user32

--- Comment #3 from Nikolay Sivov   2009-09-26 06:13:31 ---
(In reply to comment #2)
> (In reply to comment #1)
> > Actually yes, but for a start you could just revert this commit and report.
>
> Reverting commit 32ca9b27c376af255dacd67c2744b3b5285b8cf1 makes icons in
> AutoCAD 2008 PopUp menu look correct again.

Confirming then.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Nikolay Sivov   2009-09-26 06:14:30 ---
Really confirming this time.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #5 from Wilfried Pasquazzo   2009-09-26 07:57:17 ---
Original patch author here.

I'm downloading Autocad 2008 Trial version and will check on this. It's likely
that the code relevant for placing the icons in Popup-Menus relies on the
old/incorrect implementation of DrawIcon, which drew Icons sometimes smaller
than it should do.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #6 from Wilfried Pasquazzo   2009-09-26 10:02:31 ---
Created an attachment (id=23775)
 --> (http://bugs.winehq.org/attachment.cgi?id=23775)
Respect precalculated image width/height when drawing a state-sensitive Icon

Wasn't successful with installing autocad 2008, but I think I've found the
problem (or at least one of them) anyway.

When drawing state-sensitive Icons with DrawState() (dlls/user32/uitools.c) -
which is mostly done with buttons and menu icons - the size of the icon was
calculated but not passed on to the drawing function. This problem didn't
reveal itself up till now, because the used drawing method "DrawIcon" did
respect the icon size (which it shouldn't have).

This one-liner patch should fix it. Can someone try it and tell me if it really
fixes that problem?

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from NSLW   2009-09-26 10:28:07 ---
(In reply to comment #6)
> This one-liner patch should fix it. Can someone try it and tell me if it really
> fixes that problem?

Yes, it solves the problem mentioned above. Thank you. Bug is fixed.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #8 from Nikolay Sivov   2009-09-26 10:29:14 ---
Not fixed yet. Patch isn't committed.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #9 from Wilfried Pasquazzo   2009-09-26 10:36:10 ---
Commiting the patch as it is now, thanks for testing.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #10 from Wilfried Pasquazzo   2009-09-26 10:44:38 ---
... erm, I meant I sent the patch to the patches-mailing list. :)

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

Wim Lewis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Wim Lewis   2009-10-01 04:05:12 ---
FWIW, the SourceBoost IDE is showing a similar problem with its menu and
toolbar icons (as of git rev 3fe20bdc7 and a few days previous), and applying
Wilfried Pasquazzo's patch fixes it as well.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #12 from NSLW   2009-10-01 06:28:25 ---
(In reply to comment #11)
I don't know why isn't this patch accepted.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #13 from Wilfried Pasquazzo   2009-10-01 07:39:16 ---
Created an attachment (id=23866)
 --> (http://bugs.winehq.org/attachment.cgi?id=23866)
State sensitive Icons in SourceBoost (Wine)

Didn't get any feedback on that patch, so I guess it's because there was no
testcase attached or a easy to test application was missing.

SourceBoost is easier to install and test, thanks for that tip. I made a
screenshot to show that it is the same bug.

Will write and resend a testcase plus the patch later today.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #14 from Wylda   2009-10-02 10:08:39 ---
Created an attachment (id=23880)
 --> (http://bugs.winehq.org/attachment.cgi?id=23880)
NFS Undercover installer

Hi, NFS Undercover installer is affected too by commit...

32ca9b27c376af255dacd67c2744b3b5285b8cf1 is first bad commit
commit 32ca9b27c376af255dacd67c2744b3b5285b8cf1
Author: Wilfried Pasquazzo 
Date:   Tue Sep 22 14:20:28 2009 +0000

user32: Correct scaling of DrawIcon.

:040000 040000 e3a1f553e9f16b7bd47d9dcf23bddc40b0bfb8b7
addf0374f38168449965d4fe2f0f1c9066462d6a M      dlls

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Vitaliy Margolen   2009-10-03 11:17:04 ---
*** Bug 20247 has been marked as a duplicate of this bug. ***

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #16 from Wim Lewis   2009-10-06 02:37:59 ---
It looks like this patch was applied (in commit 2326f3d4), I can confirm that
the SourceBoost IDE draws its icons correctly now.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from NSLW   2009-10-06 05:11:05 ---
Patch worked for me so now if it's in latest git i mark this bug as fixed.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard   2009-10-09 11:14:25 ---
Closing bugs fixed in 1.1.31.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #19 from Steve Caddy   2009-10-12 17:54:01 ---
I don't think this bug is entirely fixed - I've just run RadioMobile against
1.1.31, and the icons are still displaying too large... unless there's some
other change between 1.1.29 and 1.1.30 that caused this.

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #20 from Steve Caddy   2009-10-12 17:55:09 ---
Created an attachment (id=24063)
 --> (http://bugs.winehq.org/attachment.cgi?id=24063)
Toolbar on Radio Mobile running under Wine 1.1.31

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #21 from Wim Lewis   2009-10-13 01:43:00 ---
Hmm, SourceBoost is still drawing correctly as of tonight's git checkout, so I
guess RadioMobile must be tickling the bug in some other way?

[Bug 20153] AutoCAD 2008: Icons in popup menus too big

http://bugs.winehq.org/show_bug.cgi?id=20153

--- Comment #22 from Jeff Zaroyko   2009-10-13 01:53:37 ---
(In reply to comment #19)
> I don't think this bug is entirely fixed - I've just run RadioMobile against
> 1.1.31, and the icons are still displaying too large... unless there's some
> other change between 1.1.29 and 1.1.30 that caused this.

File a new bug for the next problem, this one is closed as at least one case
was broken, then fixed by a patch that was committed.