http://bugs.winehq.org/show_bug.cgi?id=34579
Bug #: 34579 Summary: rotated ArcTo drawing problem Product: Wine Version: 1.7.2 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdi32 AssignedTo: wine-bugs@winehq.org ReportedBy: ralf.habacker@freenet.de Classification: Unclassified
Created attachment 46038 --> http://bugs.winehq.org/attachment.cgi?id=46038 wine screenshot showing bug
Drawing arcs with gdi function ArcTo() using GM_ADVANCED graphics mode and rotation set with SetWorldTransform() is not correct.
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #1 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 07:30:26 CDT --- Created attachment 46039 --> http://bugs.winehq.org/attachment.cgi?id=46039 Windows screenshot
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #2 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 07:38:23 CDT --- Created attachment 46040 --> http://bugs.winehq.org/attachment.cgi?id=46040 testcase sourcecode
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #3 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 07:38:41 CDT --- Created attachment 46041 --> http://bugs.winehq.org/attachment.cgi?id=46041 testcase binary
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|rotated ArcTo drawing |rotated Arc, ArcTo, Chord |problem |and Pie drawing problem
--- Comment #4 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 08:38:27 CDT --- wine codes say that Arc, ArcTo, Chord and Pie drawing are using the same code path draw_arc(), so rotation problems of them could be fixed with the same patch.
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #5 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 08:39:14 CDT --- Created attachment 46042 --> http://bugs.winehq.org/attachment.cgi?id=46042 Pie() Windows screenshot
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #46038|wine screenshot showing bug |ArcTo() wine screenshot description| |
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #46039|Windows screenshot |ArcTo() Windows screenshot description| |
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #6 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 08:40:20 CDT --- Created attachment 46043 --> http://bugs.winehq.org/attachment.cgi?id=46043 Pie() wine screenshot
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #7 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 08:42:46 CDT --- Created attachment 46044 --> http://bugs.winehq.org/attachment.cgi?id=46044 Pie() testcase source
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #8 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 08:43:06 CDT --- Created attachment 46045 --> http://bugs.winehq.org/attachment.cgi?id=46045 Pie() testcase win32 binary
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #46040|testcase sourcecode |ArcTo() testcase sourcecode description| |
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #46041|testcase binary |ArcTo() testcase win32 description| |binary
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #9 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 08:57:29 CDT --- Created attachment 46046 --> http://bugs.winehq.org/attachment.cgi?id=46046 Arc() wine screenshot
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #10 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 08:58:09 CDT --- Created attachment 46047 --> http://bugs.winehq.org/attachment.cgi?id=46047 Arc() Windows screenshot
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #11 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 09:00:49 CDT --- Created attachment 46048 --> http://bugs.winehq.org/attachment.cgi?id=46048 Arc() testcase source
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #12 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 09:01:14 CDT --- Created attachment 46049 --> http://bugs.winehq.org/attachment.cgi?id=46049 Arc() testcase win32 binary
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #13 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 09:20:41 CDT --- Created attachment 46050 --> http://bugs.winehq.org/attachment.cgi?id=46050 Chord() wine screenshot
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #14 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 09:21:09 CDT --- Created attachment 46051 --> http://bugs.winehq.org/attachment.cgi?id=46051 Chord() Windows screenshot
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #15 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 09:23:51 CDT --- Created attachment 46052 --> http://bugs.winehq.org/attachment.cgi?id=46052 Chord() testcase source
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #16 from Ralf Habacker ralf.habacker@freenet.de 2013-09-23 09:24:10 CDT --- Created attachment 46053 --> http://bugs.winehq.org/attachment.cgi?id=46053 Chord() testcase win32 binary
http://bugs.winehq.org/show_bug.cgi?id=34579
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase CC| |dank@kegel.com
http://bugs.winehq.org/show_bug.cgi?id=34579
lizhenbo litimetal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |litimetal@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #17 from Ralf Habacker ralf.habacker@freenet.de 2013-09-24 09:27:24 CDT --- patches submitted: http://www.winehq.org/pipermail/wine-patches/2013-September/127024.html http://www.winehq.org/pipermail/wine-patches/2013-September/127025.html
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|rotated Arc, ArcTo, Chord |Arc, ArcTo, Chord and Pie |and Pie drawing problem |drawing problem using | |GM_ADVANCED graphicsmode
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Arc, ArcTo, Chord and Pie |Arc, ArcTo, Chord and Pie |drawing problem using |drawing problem using |GM_ADVANCED graphicsmode |GM_ADVANCED graphics mode
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.7.2 |1.7.10
http://bugs.winehq.org/show_bug.cgi?id=34579
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.7.10 |1.7.2
http://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #18 from Ralf Habacker ralf.habacker@freenet.de --- Created attachment 47122 --> http://bugs.winehq.org/attachment.cgi?id=47122 Fix for rotated Arc, ArcTo, Chord and Pie drawin
This patch requires patch 47119 from bug 33190
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.7.2 |1.7.10
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33190
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #47122|0 |1 is obsolete| |
--- Comment #19 from Ralf Habacker ralf.habacker@freenet.de --- Created attachment 47158 --> http://bugs.winehq.org/attachment.cgi?id=47158 Fix for rotated Arc, ArcTo, Chord and Pie drawin
included helper functions and refactored
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on|33190 |
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33190
http://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35331
https://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #20 from Austin English austinenglish@gmail.com --- This is your friendly reminder that there has been no bug activity for over a year. Is this still an issue in current (1.7.37 or newer) wine? If so, please attach the terminal output in 1.7.37 (see http://wiki.winehq.org/FAQ#get_log).
https://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #21 from lizhenbo litimetal@gmail.com --- (In reply to Austin English from comment #20)
This is your friendly reminder that there has been no bug activity for over a year. Is this still an issue in current (1.7.37 or newer) wine? If so, please attach the terminal output in 1.7.37 (see http://wiki.winehq.org/FAQ#get_log).
It's still a problem in wine 1.7.37
https://bugs.winehq.org/show_bug.cgi?id=34579
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=34579
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/gdi32-rotation Status|UNCONFIRMED |STAGED Ever confirmed|0 |1
https://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #22 from Ralf Habacker ralf.habacker@freenet.de --- See this links
- https://www.winehq.org/pipermail/wine-devel/2021-February/180513.html - https://www.winehq.org/pipermail/wine-devel/2021-February/180514.html
for associated test cases added to the embedded gdi32 tests.
https://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #23 from Ralf Habacker ralf.habacker@freenet.de --- Created attachment 69347 --> https://bugs.winehq.org/attachment.cgi?id=69347 Images generated on Windows10 with the patches mentioned at https://bugs.winehq.org/show_bug.cgi?id=34579#c22
https://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #24 from Ralf Habacker ralf.habacker@freenet.de --- Created attachment 69348 --> https://bugs.winehq.org/attachment.cgi?id=69348 Images generated with wine with the patches mentioned at https://bugs.winehq.org/show_bug.cgi?id=34579#c22
https://bugs.winehq.org/show_bug.cgi?id=34579
--- Comment #25 from Ralf Habacker ralf.habacker@freenet.de --- In wine version 9.19, the commit https://gitlab.winehq.org/wine/wine/-/commit/16e1978a29c8caece6f258b09496e4e... was added, which refers to this problem.
https://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #69347|Images generated on |Images generated on Windows description|Windows10 with the patches |10 |mentioned at | |https://bugs.winehq.org/sho | |w_bug.cgi?id=34579#c22 |
https://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #46038|0 |1 is obsolete| | Attachment #46042|0 |1 is obsolete| | Attachment #46043|0 |1 is obsolete| | Attachment #46044|0 |1 is obsolete| | Attachment #46045|0 |1 is obsolete| | Attachment #46046|0 |1 is obsolete| | Attachment #46047|0 |1 is obsolete| | Attachment #46048|0 |1 is obsolete| | Attachment #46049|0 |1 is obsolete| | Attachment #46050|0 |1 is obsolete| | Attachment #46051|0 |1 is obsolete| | Attachment #46052|0 |1 is obsolete| | Attachment #46053|0 |1 is obsolete| | Attachment #47158|0 |1 is obsolete| |
--- Comment #26 from Ralf Habacker ralf.habacker@freenet.de --- Created attachment 77287 --> https://bugs.winehq.org/attachment.cgi?id=77287 ArcTo() wine screenshot (Update
With wine and wine-staging version 9.20 - the described differences can no longer be seen in the display of the Pie, Arc and Chord test cases - The output of the arcto test case has been improved, but still contains differences to a native Windows, as can be seen on the attached screenshot.
https://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #77287|ArcTo() wine screenshot |ArcTo() wine screenshot description|(Update |(Update)
https://bugs.winehq.org/show_bug.cgi?id=34579
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #69348|0 |1 is obsolete| |
https://bugs.winehq.org/show_bug.cgi?id=34579
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |NEW CC| |z.figura12@gmail.com Staged patchset|https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/gdi32-rotation |
--- Comment #27 from Zeb Figura z.figura12@gmail.com --- The remaining ArcTo() visual error is because we store dc->attr->cur_pos untransformed. This is probably incorrect in every case.