[Bug 32485] New: 1nsane: graphical issues when 'skid marks' enabled

http://bugs.winehq.org/show_bug.cgi?id=32485

Bug #: 32485
           Summary: 1nsane: graphical issues when 'skid marks' enabled
           Product: Wine
           Version: 1.5.19
          Platform: x86
               URL: http://www.fileplanet.com/50716/50000/fileinfo/Updated
                    -Insane-Demo
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: minor
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: 67230fc013da08965df156216b8d4553f289b088

Created attachment 42850
  --> http://bugs.winehq.org/attachment.cgi?id=42850
plain terminal output

1nsane is an off-road racing game released in 2001.
When the graphical option 'skid marks' enabled strange artefacts are flashing
across the screen. They are flashing so rapidly that I couldn't take a good
screenshot. Plain terminal output doesn't show anything interesting but I'm
attaching here anyway.

The problem is due to
67230fc013da08965df156216b8d4553f289b088 is the first bad commit
commit 67230fc013da08965df156216b8d4553f289b088
Author: Stefan Dösinger 
Date:   Tue Dec 4 09:36:16 2012 +0100

ddraw: Create a dynamic buffer if DDLOCK_DISCARDCONTENTS is used.

:040000 040000 8e5a8218997fca0441a81a9d71b667e3f0d1ce78
a3e9690f4987412c258de65f8870102aa9dab538 M    dlls

Reverting the patch fixes the problem.

Steps to reproduce the problem with the demo:
1. extract and install the demo.
2. start the demo with Game.exe. In the menu choose Single Player > Quick Race
> Start Race. Graphical option 'skid marks' is enabled by default so you should

see the visual glitches as soon as you start racing.

Nvidia 250 / driver 304.64
X.Org X Server 1.12.4

[Bug 32485] 1nsane: graphical issues when 'skid marks' enabled

http://bugs.winehq.org/show_bug.cgi?id=32485

--- Comment #1 from Stefan Dösinger  2012-12-20 09:51:02 CST ---
Created attachment 42867
  --> http://bugs.winehq.org/attachment.cgi?id=42867
ddraw: Don't discard buffers that haven't been used in draws

Can you give this patch a try? It fixes the problem for me, but I don't quite
like it.

The game apparently wants the buffer contents to remain intact when it locks a
buffer with DDLOCK_DISCARDCONTENTS - or at least in some cases. I noticed that
the game maps and unmaps a buffer repeatedly with this flag, without ever
drawing from it. In theory DISCARDCONTENTS is redundant in all but the first
lock after a draw, but the driver still discards the buffer contents. Ignoring
the flag and memsetting the buffer to some random value has the same effect as
setting the flag.

The other thing that's suspicious is that the game uses software vertex
processing on Windows, mostly because Windows enumerates Direct3DHAL before it
enumerates Direct3DTnLHAL. However, If I configure the game to use TnLHAL on
Windows, the track marks still work. I am not sure if the game reliably listens
to its device type setting.

[Bug 32485] 1nsane: graphical issues when 'skid marks' enabled

http://bugs.winehq.org/show_bug.cgi?id=32485

--- Comment #2 from GyB  2012-12-20 13:38:58 CST ---
(In reply to comment #1)
> Created attachment 42867 [details]
> ddraw: Don't discard buffers that haven't been used in draws
>
> Can you give this patch a try? It fixes the problem for me, but I don't quite
> like it.

The patch fixes the problem here as well.

[Bug 32485] 1nsane: graphical issues when 'skid marks' enabled

http://bugs.winehq.org/show_bug.cgi?id=32485

Julian Rüger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 32485] 1nsane: graphical issues when 'skid marks' enabled

http://bugs.winehq.org/show_bug.cgi?id=32485

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |d3520ef4653cb7bea035e08fc12
                   |                            |428da70470185
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #3 from Stefan Dösinger  2013-01-11 05:09:33 CST ---
Fixed by d3520ef4653cb7bea035e08fc12428da70470185.

[Bug 32485] 1nsane: graphical issues when 'skid marks' enabled

http://bugs.winehq.org/show_bug.cgi?id=32485

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2013-01-18 14:56:50 CST ---
Closing bugs fixed in 1.5.22.