[Bug 24308] New: Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

Summary: Fullscreen fails for MechWarrior 4 games (Only one D3D
                    device per DirectDraw object)
           Product: Wine
           Version: 1.3.2
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

For all MechWarrior 4 games, fullscreen fails with message

fixme:ddraw:d3d7_CreateDevice Only one Direct3D device per DirectDraw object
supported.

Obviously, the game falls back to window'ed mode, as
static HRESULT WINAPI d3d7_CreateDevice(IDirect3D7 *iface, REFCLSID riid,
        IDirectDrawSurface7 *surface, IDirect3DDevice7 **device)
returns
DDERR_INVALIDPARAMS

changing this behaviour (returning D3D_OK instead):
    if (ddraw->d3ddevice)
    {
        FIXME("Only one Direct3D device per DirectDraw object supported.\n");
        LeaveCriticalSection(&ddraw_cs);
        return D3D_OK;
//         return DDERR_INVALIDPARAMS;
    }

makes fullscreen work for these games.
Probably it's not "legal" to return D3D_OK in this case, but maybe there is a
real solution for this problem?

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

Georg Hennig  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]             |[e-mail]

--- Comment #1 from Wylda  2010-09-08 13:35:28 CDT ---

Thanks for bug report and findings, but no need for put yourself to cc.
(http://wiki.winehq.org/Bugs)

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from joaopa  2010-09-08 14:06:43 CDT ---
And please attach a console output with winedebug channels d3d7 and ddraw
enabled.

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #3 from Georg Hennig  2010-09-08 14:18:16 CDT ---
Created an attachment (id=30636)
 --> (http://bugs.winehq.org/attachment.cgi?id=30636)
trace with WINEDEBUG=+ddraw,+d3d7

Trace using free MechWarrior 4 Mektek release, run with
WINEDEBUG="+ddraw,+d3d7" wine MW4Mercs.exe -noautoconfig /gosnodialogs > output
2>&1

Note that many native dlls are used, namely those installed by
winetricks vcrun2005 directx9 directplay quartz

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #4 from Georg Hennig  2010-09-08 14:21:43 CDT ---
Forgot to add:
At the point the trace stopts, the program "hangs" with an "Fatal Error"
message saying

Nested exception! - Cause: 'EnterWindowMode'
Error: "FAILED (0x80070057 - WINERR_) - CreateDevice(BLADE from 0x69dadd8)" at
0x706095

And continues in window'ed mode after clicking ok.

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #5 from joaopa  2010-11-09 04:41:08 CST ---
> err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found 800x600x16 @60! (XRandR)

You must fix your Xorg conf file to support this fullscreen mode

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #6 from Georg Hennig  2010-11-09 06:09:40 CST ---
This fullscreen mode actually is supported in my xorg conf file, therefore
fullscreen mode works with the patch above at this resolution 800x600.

If I remember well, this error just means "800x600 does not exist at this
refresh rate, so wine's falling back to 800x600 at any refresh rate", which
works fine.

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #7 from joaopa  2011-07-28 07:08:10 CDT ---
still a bug in current wine?

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #8 from Georg Hennig  2011-12-03 06:04:52 CST ---
Fullscreen still does not work with wine 1.3.34.

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

http://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #9 from Georg Hennig  2012-01-01 06:46:45 CST ---
Fullscreen still does not work with wine 1.3.36.

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #10 from Austin English  ---
This is your friendly reminder that there has been no bug activity for 2 years.
Is this still an issue in current (1.7.16 or newer) wine?

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

Jeff D. Hanson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Jeff D. Hanson  ---
Still occurs with 1.7.34 and I'm seeing similar behavior with both MechWarrior
4: Vengeance and MechCommander 2 demos:

http://download.microsoft.com/download/MechWarrior/Trial/1.0/W9X2KMe/EN-US/M...

http://www.sarna.net/files/download/programs/games/mechcommander_2/demo/mc2t...

There are several "D3DERR_SURFACENOTINVIDMEM" error dialogs which may be
related.  I submitted bug #38059 for those.

I built Wine from git (1.7.36-...) but don't know how to apply the workaround
from comment #1.

Note that MW4 demo can operate at 32-bit by setting "bitdepth=32" in "[graphics
options]" in the options.ini file which is created after the first successful
launch.  Currently it needs the following to start without errors:

winetricks -q directplay dsound
MW4.exe -window /gosnovideo /gosnodialogs

Remove -window to trigger the error.

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #12 from Jeff D. Hanson  ---
To test and actual mission, "ShadowMode=1" needs to be set in options.ini else
the mech shadows will cause an abort.

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #13 from Bruno Jesus  ---
Confirming in wine 1.7.51.

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |https://archive.org/details
                   |                            |/Mechwarrior4VengeanceDemo

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from [e-mail] ---
(In reply to Bruno Jesus from comment #13)
> Confirming in wine 1.7.51.

Still an issue wine 1.9.6

[Bug 24308] Fullscreen fails for MechWarrior 4 games ( Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

Mike Ellery  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24308] Fullscreen fails for MechWarrior 4 games ( Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24308] Fullscreen fails for MechWarrior 4 games ( Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #15 from joaopa  ---
confirming with wine 3.11

[Bug 24308] Fullscreen fails for MechWarrior 4 games ( Only one D3D device per DirectDraw object)

https://bugs.winehq.org/show_bug.cgi?id=24308

pattietreutel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=24308

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from [e-mail] ---
This appears to still be an issue in Wine Staging 6.9

Surely it must be possible to do something to fix this in the mainline code,
given that such a simple patch fixes the problem?

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=24308

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Olivier F. R. Dierick  ---
*** Bug 40431 has been marked as a duplicate of this bug. ***

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=24308

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from Olivier F. R. Dierick  ---
*** Bug 36955 has been marked as a duplicate of this bug. ***

[Bug 24308] Fullscreen fails for MechWarrior 4 games (Only one D3D device per DirectDraw object)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=24308

--- Comment #19 from Béla Gyebrószki  ---
From what I see this was fixed by
https://gitlab.winehq.org/wine/wine/-/commit/9d95bd5f4b54a392d97f0b58db8f78d...

Please retest and confirm.