[Bug 27640] New: notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Summary: notepad and other editors do not render hindi typed
                    text properly
           Product: Wine
           Version: 1.3.23
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: usp10
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=35340)
 --> (http://bugs.winehq.org/attachment.cgi?id=35340)
the same txt (utf16) notepad file from video

Please see the video and the attachment; it happens only when typing; but
loading the document properly shows the characters.

Youtube video:
http://www.youtube.com/watch?v=PnllbZoJqVk

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, integration
         AssignedTo|[e-mail]        |[e-mail]

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

--- Comment #1 from Aric Stewart  2011-10-13 13:26:42 CDT ---
Created attachment 36891
  --> http://bugs.winehq.org/attachment.cgi?id=36891
usp-edit1.patch

Apply this patch first

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

--- Comment #2 from Aric Stewart  2011-10-13 13:26:59 CDT ---
Created attachment 36892
  --> http://bugs.winehq.org/attachment.cgi?id=36892
usp-edit2.patch

These two patches are the long running work I have been doing to improve
complex script support in the edit control.  Please apply them and try and see
if there is improvement.

thanks!
-aric

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

--- Comment #3 from Asif Ali Rizwaan  2011-10-13 19:46:40 CDT ---
Created attachment 36897
  --> http://bugs.winehq.org/attachment.cgi?id=36897
patched wine - bug with matra+characters - text document in the video

Notepad with patched (usp patch1 and patch2) wine 
http://www.youtube.com/watch?v=TwesTEMN1lM

notepad: normal and combined text is ok. but combined characters with notepad
is not.

wordpad: same old behavior, normal and matra text is ok, but combined is
causing cursor gap.

The patches seems to affect only notepad, and not wordpad.

wordpad with the pacthed wine git (patch1 and patch2)
http://www.youtube.com/watch?v=hwpABUN7eis

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

--- Comment #4 from Asif Ali Rizwaan  2011-10-13 19:47:31 CDT ---
Created attachment 36898
  --> http://bugs.winehq.org/attachment.cgi?id=36898
patched wine - bug with matra+characters - richtext document in the video

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

--- Comment #5 from Aric Stewart  2011-10-14 06:58:15 CDT ---
(In reply to comment #4)
> Created attachment 36898 [details]
> patched wine - bug with matra+characters - richtext document in the video

Yes,  WordPad is a RichEdit control and I have not started work on the RichEdit
controls yet.  Just the Edit Control.

So for now these patches will only affect Notepad.  Once we get them worked out
then It should be the next step to work on the RichEdit Control.

I see the issue with the mantras.  Overall is this an improvement or have we
just traded composed characters being off with mantras being off?

thanks!
-aric

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

--- Comment #6 from Asif Ali Rizwaan  2011-10-14 07:34:50 CDT ---
> (In reply to comment #5)
> I see the issue with the mantras.  Overall is this an improvement or have we
> just traded composed characters being off with mantras being off?
>
> thanks!
> -aric

I seems the latter, matras are being off.

before the patch:
I think that 'composed characters' gap happens due to 'halant' character. So,
It would be nice to - do the gap-removing with 'char+halant+char'combinations
only, as character *space* of halant (् ) stays/rendered in ligatures (द्व क्र
त्व etc.), hence there comes extra space. It was not happening with other
matras ि ी ु ू े ै ो ौ ॆ ॊ ॉ ॅ.

After patch:
only matras which are positioned on the left or the right sides of a character
(i.e., ा ि ी ो ौ ॊ ॉ) are causing the gap. Top and bottom matras are fine
(i.e., ु ू े ै ं ँ ॆ ॅ)

So, please choose the way whichever is easier for you. Thanks.

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

--- Comment #7 from Aric Stewart  2011-10-14 07:43:49 CDT ---
(In reply to comment #6)
> > (In reply to comment #5)
> > I see the issue with the mantras.  Overall is this an improvement or have we
> > just traded composed characters being off with mantras being off?
> >
> > thanks!
> > -aric
>
> I seems the latter, matras are being off.
>
> before the patch:
> I think that 'composed characters' gap happens due to 'halant' character. So,
> It would be nice to - do the gap-removing with 'char+halant+char'combinations
> only, as character *space* of halant (् ) stays/rendered in ligatures (द्व क्र
> त्व etc.), hence there comes extra space. It was not happening with other
> matras ि ी ु ू े ै ो ौ ॆ ॊ ॉ ॅ.
>
> After patch:
> only matras which are positioned on the left or the right sides of a character
> (i.e., ा ि ी ो ौ ॊ ॉ) are causing the gap. Top and bottom matras are fine
> (i.e., ु ू े ै ं ँ ॆ ॅ)
>
> So, please choose the way whichever is easier for you. Thanks.

Well the hope is to be able to fix both. :)
It is just my needing to get the cursor positioning correct for Indic
languages.  I believe Indic languages do not allow cursors to position inside
of composed glyphs (unlike arabic which does). I will work on correcting that.

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36891|0                           |1
        is obsolete|                            |
  Attachment #36892|0                           |1
        is obsolete|                            |

--- Comment #8 from Aric Stewart  2011-10-19 14:19:15 CDT ---
Created attachment 37015
  --> http://bugs.winehq.org/attachment.cgi?id=37015
edit.patch

Ok, I have done a bit of work with indic clusters and handling cursor
positioning.

You can test Notepad using just the one edit.patch

Hopefully that improves cursor positioning.

There is still work to do as I need to properly group whole syllables into
clusters but this should at least improve things.

This will not affect wordpad.  Just notepad.

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37015|0                           |1
        is obsolete|                            |

--- Comment #9 from Aric Stewart  2011-10-19 14:20:39 CDT ---
Created attachment 37017
  --> http://bugs.winehq.org/attachment.cgi?id=37017
edit.patch

Sorry, attached incorrect patch.

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37017|0                           |1
           is patch|                            |
  Attachment #37017|application/octet-stream    |text/plain
          mime type|                            |

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

--- Comment #10 from Asif Ali Rizwaan  2011-10-20 00:04:07 CDT ---
(In reply to comment #8)
> Created attachment 37015 [details]
> edit.patch
>
> Ok, I have done a bit of work with indic clusters and handling cursor
> positioning.
>
> You can test Notepad using just the one edit.patch
>
> Hopefully that improves cursor positioning.
>
> There is still work to do as I need to properly group whole syllables into
> clusters but this should at least improve things.
>
> This will not affect wordpad.  Just notepad.

Great work, Aric! It has fixed notepad and excel cursor related bug.

Excel 2003:
http://www.youtube.com/watch?v=VylISTHgzHc

Notepad:
http://www.youtube.com/watch?v=_FruYWyM8I0

Hope to see RichEdit Control getting fixed very soon :)

[Bug 27640] notepad and other editors do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

--- Comment #11 from Aric Stewart  2011-10-25 07:05:40 CDT ---
all these patches are now in wine.

Please test and if things are fixed close the bug.

thanks!
-aric

[Bug 27640] notepad and excel do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Asif Ali Rizwaan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|notepad and other editors   |notepad and excel do not
                   |do not render hindi typed   |render hindi typed text
                   |text properly               |properly

--- Comment #12 from Asif Ali Rizwaan  2011-10-25 15:33:03 CDT ---
Ok, wine-git works. For notepad and excel, this works. I'm changing the bug
title to notepad and excel only.

closing it. Thanks

[Bug 27640] notepad and excel do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Asif Ali Rizwaan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Asif Ali Rizwaan  2011-10-25 15:33:42 CDT ---
fixed.

[Bug 27640] notepad and excel do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  2011-11-04 14:15:46 CDT ---
Closing bugs fixed in 1.3.32.

[Bug 27640] notepad and excel do not render hindi typed text properly

http://bugs.winehq.org/show_bug.cgi?id=27640

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3b5e14a9b0a925052e2b1b71f76
                   |                            |a7f1eff6d84bf
                 CC|                            |[e-mail]