[Bug 57946] New: GreedFall needs maxAnisotropy values handling

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57946

Bug ID: 57946
           Summary: GreedFall needs maxAnisotropy values handling
           Product: vkd3d
           Version: 1.15
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: vkd3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Fails to launch on Nvidia. Driver 570.124.04

VUID-VkSamplerCreateInfo-anisotropyEnable-01071(ERROR / SPEC): msgNum:
1233543420 - Validation Error: [
VUID-VkSamplerCreateInfo-anisotropyEnable-01071 ] | MessageID = 0x498660fc |
vkCreateSampler(): pCreateInfo->maxAnisotropy is 0.000000 but must be in the
range of [1.0, 16.000000] (maxSamplerAnistropy).
The Vulkan spec states: If anisotropyEnable is VK_TRUE, maxAnisotropy must be
between 1.0 and VkPhysicalDeviceLimits::maxSamplerAnisotropy, inclusive
(https://docs.vulkan.org/spec/latest/chapters/samplers.html#VUID-VkSamplerCre...)
0140:err:msvcrt:_wassert (L"!status &&
"vkCreateSampler"",L"../wine/dlls/winevulkan/loader_thunks.c",3442)

1.15-86-g1417af2e

[Bug 57946] GreedFall needs maxAnisotropy values handling

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57946

--- Comment #1 from Henri Verbeet  ---
Created attachment 79127
  --> http://bugs.winehq.org/attachment.cgi?id=79127
patch

Does the attached patch help?

[Bug 57946] GreedFall needs maxAnisotropy values handling

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57946

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79127|0                           |1
        is obsolete|                            |

--- Comment #2 from Henri Verbeet  ---
Created attachment 79132
  --> http://bugs.winehq.org/attachment.cgi?id=79132
patch

I tried to reproduce this locally, but perhaps unsurprisingly, I was unable to
do so on Mesa/radv.

As far as I'm able to tell, this is a Direct3D 11 application though, so the
patch from the previous comment wouldn't make any difference. I do see the
application creating a sampler with a zero max_anisotropy value; the attached
patch should avoid that issue for wined3d.

[Bug 57946] GreedFall needs maxAnisotropy values handling

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57946

--- Comment #3 from Henri Verbeet  ---
Created attachment 79133
  --> http://bugs.winehq.org/attachment.cgi?id=79133
alternative patch

Alternatively, this patch doesn't enable anisotropy for a max_anisotropy value
of 0.

[Bug 57946] GreedFall needs maxAnisotropy values handling

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57946

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |e98df10a2905f5c937e2fd03833
                   |                            |b07977244208f
             Status|NEW                         |RESOLVED

--- Comment #4 from Henri Verbeet  ---
Should be fixed by commit e98df10a2905f5c937e2fd03833b07977244208f.

[Bug 57946] Multiple games need maxAnisotropy values handling (GreedFall, Mafia III: Definitive Edition)

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57946

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|GreedFall needs             |Multiple games need
                   |maxAnisotropy values        |maxAnisotropy values
                   |handling                    |handling (GreedFall, Mafia
                   |                            |III: Definitive Edition)
            Version|1.15                        |10.12
          Component|vkd3d                       |d3d
            Product|vkd3d                       |Wine