[Bug 9277] New: Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Summary: Folder selection doesn't work correctly since 0.9.42
           Product: Wine
           Version: 0.9.43.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: test
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When using Winzip, open a zip file and select Extract, and then in My Computer
select C:. The Program Files and Windows folders will appear, but you won't be
able to enter in any of them, and they'll be duplicated in the address bar if
you click on one of them.

This bug appeared in Wine 0.9.42 and does happen with any Windows app I tested.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #1 from Austin English   2007-08-12 07:10:07 ---
Please retry in wine 0.9.43, with a clean .wine directory. If it still occurs,
please post a link to the application version you are using, a backtrace of the
program, and the version of wine that last worked.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #2 from Loacoon   2007-08-12 07:30:54 ---
It's still happening with wine 0.9.43 and a clean .wine directory.

I can't link to an application version since it's happening with every
installer or application I tried so far. Also, I don't know what a backtrace is
or how it works, I'll see in the wiki to learn how to do that.

It last worked in Wine 0.9.41.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Austin English   2007-08-12 07:46:02 ---
Don't worry, I found what you're talking about in newest winzip (11.1). I'll
start the regression test.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #4 from Loacoon   2007-08-12 07:48:31 ---
Ok, thanks you.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                URL|                            |http://www.download.com/3405
                   |                            |-2250_4-
                   |                            |5155091.html?part=dl-WinZip
          Component|test                        |wine-shell32
           Keywords|                            |download, regression

--- Comment #5 from Austin English   2007-08-12 12:22:12 ---
f686cfab2feb9010efe82a932dc9f5904566c8ab is first bad commit
commit f686cfab2feb9010efe82a932dc9f5904566c8ab
Author: Dmitry Timoshkov 
Date:   Mon Jul 16 20:17:59 2007 +0900

shell32: Add a cache for queried shell folder interfaces.

:040000 040000 17ae18094b4a8283400659370010c3902a727a78
bee9f6fe67db3c9c4ce81302d5adbc8d9112a53d M      dlls

CC'ing author.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Joerg Schiermeier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |newsletter@Schiermeier-
                   |                            |Software.de

--- Comment #6 from Joerg Schiermeier   2007-08-15 16:18:46 ---
*** Bug 9310 has been marked as a duplicate of this bug. ***

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #7 from Joerg Schiermeier   2007-08-15 16:22:52 ---
Created an attachment (id=7611)
 --> (http://bugs.winehq.org/attachment.cgi?id=7611)
Error in wines file open/save dialog - wine v0.9.42 and above

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Karsten Elfenbein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Karsten Elfenbein   2007-08-19 09:19:50 ---
this bug affects manual patch install for EVE Online as well (can't browse to
the install folder as they show as empty= without "+" to expand sub folders)

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #9 from Dmitry Timoshkov   2007-08-19 11:50:57 ---
Is the bug reproduceable with native shell32.dll (preferrably from a win2k box
since it doesn't have not resolved dependencies)?

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #10 from Dmitry Timoshkov   2007-08-19 11:53:51 ---
How about native comctl32.dll (without any other native dlls)?

(Trying to figure out whether it's a comctl32 bug provoked by a change in
shell32, or a shel32 regression caused by my patch).

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #11 from Karsten Elfenbein   2007-08-21 16:23:41 ---
I tried it with native but apart from some icons with black background nothing
changed in the EVE testserver patch installer file

when running a +shell log I get some lines like
trace:shell:IShellFolder_fnGetDisplayNameOf -- (0x1373f8)->(L"C:\Program
Files\Program Files")

which doesn't look normal for me

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

manro  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from manro   2007-08-27 17:30:07 ---
I found same problem since wine ~ 0.9.42 on Gentoo, in every application when I
try to access to file through "my computer" in open/save dialog.

Here is log of regedit.exe when i trying to open "My computer"/C:/windows
folder, and then opening "My computer"/C:/windows/windows folder, that I see as
content of first level windows folder listing.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #13 from manro   2007-08-27 17:37:40 ---
Created an attachment (id=7843)
 --> (http://bugs.winehq.org/attachment.cgi?id=7843)
gzipped log of WINEDEBUG=+file wine c:\windows\regedit.exe &>/tmp/regedit.log

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Austin English   2007-08-31 11:03:09 ---
*** Bug 9515 has been marked as a duplicate of this bug. ***

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Joel Daniels  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #15 from Joel Daniels   2007-09-08 09:39:24 ---
Created an attachment (id=7999)
 --> (http://bugs.winehq.org/attachment.cgi?id=7999)
This patch (against 0.9.44) fixes the bug by reversing the patch which
introduced it.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #16 from Joel Daniels   2007-09-08 09:41:06 ---
The patch I just attached above temporarily fixes the bug for those who want to
use wine 0.9.44 by simply reversing the original patch which introduced the
bug.

It does not actually represent a good solution, but in case it helps any other
users I have posted it.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Mikolaj Zalewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Mikolaj Zalewski   2007-09-11 12:55:52 ---
The problem is that they may be many folders with the same GUID but different
PIDLs. The most common example are filesystem folders - they are also
constructed with SHELL32_CoCreateInitSF and that's why they don't work properly
anymore. I'll try to check how to fix it.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #18 from Mikolaj Zalewski   2007-09-11 15:42:37 ---
Created an attachment (id=8029)
 --> (http://bugs.winehq.org/attachment.cgi?id=8029)
patch

Could someone check if this patch helps? It changes the cache from GUID-based
to PIDL-based. As a PIDL changes even if the file mtime changes I don't try to
keep all the objects in the cache but only 32 most recently used ones.

The problem with the patch was that Photoshop CS calls this function very often
and even an ILCombine/ILFree seems to make a difference in speed. That's why
there is a unplesant 'if' at the beginning. I'll see if this can be written
somehow better.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #19 from Dmitry Timoshkov   2007-09-11 22:11:12 ---
I'm considering to simply revert my patch. It creates more problems than
it actually gives benefits. Instead we should spend time finding out why
our shell folder implementation is so much slower than a native one, in
particular ways to speed up dlls/shell32/shlfolder.c,SHELL32_BindToChild.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

--- Comment #20 from Dmitry Timoshkov   2007-09-12 01:08:53 ---
I sent a patch reverting commit f686cfab2feb9010efe82a932dc9f5904566c8ab.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #21 from Dmitry Timoshkov   2007-09-12 07:54:00 ---
The patch that reverts the offending commit has been committed.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

http://bugs.winehq.org/show_bug.cgi?id=9277

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #22 from Dmitry Timoshkov   2007-09-12 07:54:16 ---
Closing.

[Bug 9277] Folder selection doesn't work correctly since 0.9.42

https://bugs.winehq.org/show_bug.cgi?id=9277

Hildo Guillardi Júnior  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]