[Bug 19470] New: Wine shouldn't assume the default visual supports GLX

http://bugs.winehq.org/show_bug.cgi?id=19470

Summary: Wine shouldn't assume the default visual supports GLX
           Product: Wine
           Version: 1.1.26
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=22631)
 --> (http://bugs.winehq.org/attachment.cgi?id=22631)
Output from glxinfo command

Right now, when initializing OpenGL support, and determining the OpenGL
capabilities of the host system (in X11DRV_WineGL_InitOpenglInfo()), Wine makes
a very crucial assumption: that the default visual supports GLX. This is not
necessarily true, so therefore Wine should not make this assumption.

In the 2.4.0 release candidate from the Xquartz project, for example, the
default visual does not support GLX. The fact that it doesn't caused the
glXCreateContext() call in the mentioned function to fail.

In particular, that call to glXCreateContext() fails with the following
message:

X Error of failed request:  BadValue (integer parameter out of range for
operation)
   Major opcode of failed request:  0 ()
   Value in failed request:  0x22
   Serial number of failed request:  515
   Current serial number in output stream:  515

That value in the message happens to be the ID of the default visual on my
system. Under 2.4.0 RC1, that visual doesn't support GLX. (In the next 2.4.0
RC, it will, for reasons which become apparent in the next paragraph.) I've
attached the output from glxinfo under that version, so you can see for
yourself.

I filed a bug with Xquartz (http://xquartz.macosforge.org/trac/ticket/287).
They told me they would fix it (and they did, and the fix is going into the
next 2.4.0 RC), but they also warned me that the default visual for a given
display and screen doesn't have to support GLX, and that I should report this
to WineHQ.

[Bug 19470] Wine shouldn't assume the default visual supports GLX

http://bugs.winehq.org/show_bug.cgi?id=19470

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|winex11.drv                 |opengl

--- Comment #1 from Roderick Colenbrander   2009-07-29 12:32:54 ---
Thanks for the report I'll try to fix the issue in the near future.

Roderick

[Bug 19470] Wine shouldn't assume the default visual supports GLX

http://bugs.winehq.org/show_bug.cgi?id=19470

Charles Davis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Charles Davis   2009-08-03 17:58:58 ---
Your patch made it in. Excellent!

Resolving fixed.

[Bug 19470] Wine shouldn't assume the default visual supports GLX

http://bugs.winehq.org/show_bug.cgi?id=19470

--- Comment #3 from Nikolay Sivov   2009-08-03 20:28:52 ---
Hi, Charles. Please add commit id that fixed it next time.
Fixed by 390d3929f2b2a9641ecc8114cf94ae09fa851a15.

[Bug 19470] Wine shouldn't assume the default visual supports GLX

http://bugs.winehq.org/show_bug.cgi?id=19470

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard   2009-08-07 13:00:38 ---
Closing bugs fixed in 1.1.27.

[Bug 19470] Wine shouldn't assume the default visual supports GLX

http://bugs.winehq.org/show_bug.cgi?id=19470

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|Mac OS X 10.5               |Mac OS X