[Bug 50985] New: ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

Bug ID: 50985
           Summary: ns_name_skip is glibc specific, causes failure to
                    build on musl
           Product: Wine
           Version: 6.6
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: dnsapi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

6.6 introduced a reliance on glibc-specific calls in dlls/dnsapi/libresolv.c in
commit 5f44c46164a5c0c50fffdf6cda9980a74079e1ac.

Specifically, musl does not implement ns_name_skip, and the library fails at
link time.

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

--- Comment #1 from Hans Leidekker  ---
(In reply to Andrew Benson from comment #0)
> 6.6 introduced a reliance on glibc-specific calls in dlls/dnsapi/libresolv.c
> in commit 5f44c46164a5c0c50fffdf6cda9980a74079e1ac.

It's not glibc specific. macOS and Android also have this export.
> Specifically, musl does not implement ns_name_skip, and the library fails at
> link time.

musl does export ns_initparse, ns_parserr and ns_name_uncompress. It would be
nice if ns_name_skip could be added. Alternatively we could reimplement the
function.

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

--- Comment #2 from Hans Leidekker  ---
Created attachment 69818
  --> https://bugs.winehq.org/attachment.cgi?id=69818
Work around missing ns_name_skip

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

--- Comment #3 from Andrew Benson  ---
Created attachment 69819
  --> https://bugs.winehq.org/attachment.cgi?id=69819
Partial failure log

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

Craig Andrews  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

Ismael Luceno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

--- Comment #4 from Ismael Luceno  ---
It probably makes sense to add the missing function from the buildsystem using
AC_REPLACE_FUNCS. I'm not familiar with the policies of the project though,
does that make sense?

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

Alex Xu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Alex Xu  ---
since
https://source.winehq.org/git/wine.git/commitdiff/d193c164b78a77570960a6fea5...
i think this function is not used anymore, so this can be closed?

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |d193c164b78a77570960a6fea58
                   |                            |9a3ccb3f080b6

--- Comment #6 from Hans Leidekker  ---
(In reply to Alex Xu from comment #5)
> since
> https://source.winehq.org/git/wine.git/commitdiff/
> d193c164b78a77570960a6fea589a3ccb3f080b6 i think this function is not used
> anymore, so this can be closed?

Correct.

[Bug 50985] ns_name_skip is glibc specific, causes failure to build on musl

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50985

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 6.23.