http://bugs.winehq.org/show_bug.cgi?id=12319
Summary: Can't connect to Battle.net in Starcraft anymore Product: Wine Version: CVS/GIT Platform: PC-x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 AssignedTo: wine-bugs@winehq.org ReportedBy: ns03ja@brocku.ca CC: thestig@google.com
Created an attachment (id=11778) --> (http://bugs.winehq.org/attachment.cgi?id=11778) After attempting to login to Battle.net
While Starcraft's Battle.net interface in Wine is slightly less than perfect (see bug 2467 and bug 2082, for example), it has still been usable, and once you actually get in game, things are flawless. Quite recently, that changed, in that it's no longer possible to connect to Battle.net. Now when attempting to connect to Battle.net, after entering one's account information, the attached screen is displayed, claiming that Battle.net is not responding. Dismissing this dialog brings one back to the multiplayer menu (in typical Blizzard fashion, rapid repeated attempts to reconnect will simply fail silently, sending one directly back to the multiplayer menu again). This is not an intermittent error as the error message might suggest.
A git bisect reveals the following:
41ea8f0e8a6fab93fa08da16ecc24260dbad327c is first bad commit commit 41ea8f0e8a6fab93fa08da16ecc24260dbad327c Author: Lei Zhang thestig@google.com Date: Tue Mar 25 19:09:38 2008 -0700
user32: Tweak how the edit control handles WM_GETDLGCODE.
:040000 040000 5583dc91d4f658340fcab6169c5be12b18c5d862 114715be44f79ddf45a9c61a01b90ee624504c1a M dlls
http://bugs.winehq.org/show_bug.cgi?id=12319
Neil Skrypuch ns03ja@brocku.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #1 from Lei Zhang thestig@google.com 2008-04-01 09:07:56 --- Are you sure you did the regression test correctly? A change in user32 should not affect network operations.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #2 from Neil Skrypuch ns03ja@brocku.ca 2008-04-01 14:35:53 --- Yes, I agree it's odd that a change in user32 could cause something like this to happen, however I definitely did the regression test correctly. Just in case, I also tried with a1bc05e4c0eb017eda7636343af80d18b1f64d6c (the commit right before the one mentioned by the bisect), which was fine.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #3 from Austin English austinenglish@gmail.com 2008-04-01 14:49:57 --- (In reply to comment #2)
Yes, I agree it's odd that a change in user32 could cause something like this to happen, however I definitely did the regression test correctly. Just in case, I also tried with a1bc05e4c0eb017eda7636343af80d18b1f64d6c (the commit right before the one mentioned by the bisect), which was fine.
Still, very strange, can you try:
A) Compiling just before the bad commit, and retest (which you did, but try with a clean ~/.wine to be sure). B) Compiling at the bad commit and retest (again, with a clean ~/.wine) C) Reverting that commit on current git, and test with a clean ~/.wine
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #4 from Lei Zhang thestig@google.com 2008-04-01 15:51:22 --- Hmm, starcraft + battle.net works fine here with today's git.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #5 from Neil Skrypuch ns03ja@brocku.ca 2008-04-01 17:34:34 --- (In reply to comment #3)
Still, very strange, can you try:
A) Compiling just before the bad commit, and retest (which you did, but try with a clean ~/.wine to be sure). B) Compiling at the bad commit and retest (again, with a clean ~/.wine) C) Reverting that commit on current git, and test with a clean ~/.wine
Ok, I tried again with fresh ~/.wine directories. The thrilling results:
A) Works. B) Doesn't work. C) Works. (git version 0a8d2ba37a59531ae7a58c3d693e65dbe901a72a, there were some conflicts in the revert, but only in the tests...)
One thing of significance that I did notice with A vs B is that the tabindexes were wrong. When Starcraft asked for my CD key and name during the install, in A a tab from the name textbox sent me to the first CD key textbox (as it should), but with B, I was sent to the second CD key textbox. Similarly, when at the login screen, tabbing from the account input in A sends me to the password textbox (as it should), but in B, it goes somewhere else (I'm not sure where, I couldn't see, but it wasn't the password box). In both cases A and C behave the same. I'm not sure if this is related or not, if not I'll file it as a separate bug.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #6 from Lei Zhang thestig@google.com 2008-04-01 18:15:53 --- Yes, I see the tabbing problem. That probably is caused by my patch. I just don't understand what it has to do with you not being able to connect to battle.net.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #7 from Neil Skrypuch ns03ja@brocku.ca 2008-04-01 18:51:07 --- (In reply to comment #6)
Yes, I see the tabbing problem. That probably is caused by my patch. I just don't understand what it has to do with you not being able to connect to battle.net.
I don't either, but it definitely does, somehow, cause this (at least for me).
Starcraft does a lot of exotic things with dialog boxes and similar (this is where the long-standing bugs regarding battle.net display stem from), so it doesn't seem implausible that a change in user32 regarding edit controls could somehow break the login screen. What I suspect is happening is that the controls don't behave exactly as Starcraft expects them to, so they just bail out with a standard error message, Starcraft may not even get the chance to try and connect to Battle.net.
Does that make any sense?
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #8 from Lei Zhang thestig@google.com 2008-04-01 19:11:51 --- Battle.net works for me though. I'm seeing some graphics corruption, so I clicked on all the dialog boxes with the mouse.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #9 from Lei Zhang thestig@google.com 2008-04-01 22:44:48 --- Created an attachment (id=11796) --> (http://bugs.winehq.org/attachment.cgi?id=11796) patch to fix tab behavior
Does this patch help? It restores the previous tabbing behavior.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #10 from Neil Skrypuch ns03ja@brocku.ca 2008-04-02 00:18:37 --- (In reply to comment #9)
Created an attachment (id=11796)
--> (http://bugs.winehq.org/attachment.cgi?id=11796) [details]
patch to fix tab behavior
Does this patch help? It restores the previous tabbing behavior.
Yes, that patch fixes login, with one caveat... It also makes the enter key do nothing in the main lobby (ie, I can't say anything there), but it's fine in the game lobby and in game.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #11 from Lei Zhang thestig@google.com 2008-04-02 01:31:09 --- Created an attachment (id=11798) --> (http://bugs.winehq.org/attachment.cgi?id=11798) patch to fix enter key problem
Does this fix the enter key problem in comment 10? Apply this on top of the attachment 11796.
http://bugs.winehq.org/show_bug.cgi?id=12319
Kolbjørn Fredheim coolbeer1980@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |coolbeer1980@yahoo.com
--- Comment #12 from Kolbjørn Fredheim coolbeer1980@yahoo.com 2008-04-02 04:38:01 --- I have a similar issue with Anarchy Online, although it's only a minor one there. On login, if you press enter instead of pushing "Login" a box will come up stating "You must select a charactername before playing! [OK]", this is before checking if the password is correct, or actually logging in to the account.
I have never seen this box in the 2.5 years I've been playing Anarchy, so I can only speculate it's trying to select a character without actually having one selected in the drop-down box on the next "page". Wich it wount get to if the password is wrong though.
I bisected it down to the same commit, therefore it's most probably the same issue aswell. I tried the patches, but no difference with AO atleast.
http://bugs.winehq.org/show_bug.cgi?id=12319
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #13 from Lei Zhang thestig@google.com 2008-04-02 08:47:34 --- (In reply to comment #12)
I have a similar issue with Anarchy Online, although it's only a minor one there. On login, if you press enter instead of pushing "Login" a box will come up stating "You must select a charactername before playing! [OK]", this is before checking if the password is correct, or actually logging in to the account.
Ok, so to reproduce - go to the login screen, you need to type in a user name, a password, and then press enter?
http://bugs.winehq.org/show_bug.cgi?id=12319
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@palringo.com
--- Comment #14 from Lei Zhang thestig@google.com 2008-04-02 09:55:00 --- *** Bug 12329 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=12319
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #11798|0 |1 is obsolete| |
--- Comment #15 from Lei Zhang thestig@google.com 2008-04-02 10:25:31 --- Created an attachment (id=11806) --> (http://bugs.winehq.org/attachment.cgi?id=11806) patch to fix enter key problem (try 2)
Please give this patch a try for the problems with pressing enter.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #16 from Neil Skrypuch ns03ja@brocku.ca 2008-04-02 13:48:57 --- (In reply to comment #15)
Created an attachment (id=11806)
--> (http://bugs.winehq.org/attachment.cgi?id=11806) [details]
patch to fix enter key problem (try 2)
Please give this patch a try for the problems with pressing enter.
This patch appears to fix the enter issue.
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #17 from Lei Zhang thestig@google.com 2008-04-02 14:31:15 --- Patches sent:
http://www.winehq.org/pipermail/wine-patches/2008-April/052640.html http://www.winehq.org/pipermail/wine-patches/2008-April/052645.html http://www.winehq.org/pipermail/wine-patches/2008-April/052646.html
http://bugs.winehq.org/show_bug.cgi?id=12319
--- Comment #18 from Kolbjørn Fredheim coolbeer1980@yahoo.com 2008-04-02 18:25:35 --- Patching with the sent in patches does appear to have fixed the problem in Anarchy Online.
http://bugs.winehq.org/show_bug.cgi?id=12319
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #19 from Lei Zhang thestig@google.com 2008-04-03 09:54:48 --- patches committed.
http://bugs.winehq.org/show_bug.cgi?id=12319
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org 2008-04-04 10:06:43 --- Closing bugs fixed in 0.9.59.
http://bugs.winehq.org/show_bug.cgi?id=12319
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified
-
wine-bugs＠winehq.org