[Bug 10300] New: Regression: KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

Summary: Regression: KotOR has a very low framerate
           Product: Wine
           Version: 0.9.48.
          Platform: PC
               URL: http://www.bioware.com/games/knights_old_republic/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: wine-opengl
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

KotOR used to run very fast, but now it only draws one frame every few seconds.

Regression testing shows:

462a3c3d744da6b9ae2193947da8245c37baaa1f is first bad commit
commit 462a3c3d744da6b9ae2193947da8245c37baaa1f
Author: Roderick Colenbrander 
Date:   Wed Aug 1 23:20:54 2007 +0200

wgl: wglChooosePixelFormatARB returns the total number of matching
pixelformats and not the number of pixelformats stored in the buffer.

This didn't work due to bugs in wglChoosePixelFormatARB but also due
    to strange behavior of glXChooseFBConfig. Some of its default values
    are not zero or GLX_DONT_CARE which cause some formats not to appear.

:040000 040000 014afa73c0abdc4220b0f0c3e6378ca60091bf9c
7278c49d64f8243c4252c71ae517c53ce04279d4 M      dlls

Is the cause for this.

[Bug 10300] Regression: KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

killertux  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |regression

[Bug 10300] Regression: KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

killertux  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]        |

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Regression: KotOR has a very|KotOR has a very low
                   |low framerate               |framerate

--- Comment #1 from Austin English   2007-11-03 19:37:27 ---
cc'ing author

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #2 from Roderick Colenbrander   2007-11-04 03:48:11 ---
Wine's opengl is limited in the number of pixel formats. I have no idea what
Kotor is doing but it can't select a different pixel format (it can only for
pbuffers). Please attach a +wgl log of running it with and without the patch.

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #3 from Luke Bratch   2007-11-04 06:43:30 ---
Created an attachment (id=8954)
 --> (http://bugs.winehq.org/attachment.cgi?id=8954)
+wgl trace with the patch

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #4 from Luke Bratch   2007-11-04 06:45:20 ---
Created an attachment (id=8955)
 --> (http://bugs.winehq.org/attachment.cgi?id=8955)
+wgl trace without the patch

The ultra low framerate issue doens't happen until actually in the game - ie.
the menu is exactly the same high framerate, it starts going slow around 95%
through the loading process.

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #5 from Roderick Colenbrander   2007-11-04 09:04:12 ---
Actually the problem you are seeing is in essence not a regression but on the
other hand it is.

The game uses pbuffers for some rendering some parts. Without the patch it
actually failed to create a pbuffer (due to wine's pixel format limitations).
Since the patch it is finding a pixel format and actually uses a pbuffer. But
for some reason it is finding a very, very bad pixel format which causes the
performance problems (it is using a 128-bit pixel format).

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #6 from Luke Bratch   2007-11-05 17:20:09 ---
Thanks Roderick.

Is there any other traces I can provide to help, or shall I just leave this bug
until something changes with Wine's pixel formats?

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #7 from Roderick Colenbrander   2007-11-05 17:35:01 ---
Leave it open. Perhaps I could add some patch which prevents it from selecting
the nvidia float format but I need to check how it behaves on windows.

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #8 from Roderick Colenbrander   2007-12-16 10:17:10 ---
These three patches will should fix the problem:
http://www.winehq.org/pipermail/wine-patches/2007-December/047988.html
http://www.winehq.org/pipermail/wine-patches/2007-December/047990.html
http://www.winehq.org/pipermail/wine-patches/2007-December/047992.html

Roderick

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #9 from Luke Bratch   2007-12-16 11:08:58 ---
Thanks, they fix it completely.

I'll close this when (if) they get committed.

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

Luke Bratch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Luke Bratch   2008-01-12 05:57:37 ---
This is fixed, sorry for the delay in closing.

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #11 from Roderick Colenbrander   2008-01-12 06:00:33 ---
Oh strange that is fixed already as my three patches aren't in yet ;)

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #12 from Luke Bratch   2008-01-12 06:08:34 ---
Yes I thought that was strange, I just assumed some other patch must have fixed
it between then and now...

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Dan Kegel   2008-01-28 06:14:05 ---
Closing all RESOLVED FIXED bugs older than 0.9.54.

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

--- Comment #14 from Luke Bratch   2008-01-28 17:57:56 ---
I'm not sure if this really is fixed, it seems like it could have been changes
to my system (graphics card or drivers) rather than the bug in Wine being
fixed.

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #15 from Roderick Colenbrander   2008-01-29 01:56:09 ---
This bug isn't fixed. It can only be fixed once my x11 client window patches
are in.

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Roderick Colenbrander   2008-02-25 11:03:01 ---
I talked to Luke about this bug on irc. Thanks to the lifting of the pixel
format limitation the issue doesn't occur anymore and it is a lot faster.

[Bug 10300] KotOR has a very low framerate

http://bugs.winehq.org/show_bug.cgi?id=10300

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #17 from Alexandre Julliard   2008-03-07 11:28:31 ---
Closing bugs fixed in 0.9.57.