[Bug 17269] New: WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Summary: WNetGetUser missing in Win16
           Product: Wine
           Version: 1.1.14
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I am trying to get an application running under wine developed with Superbase,
an old Win16 Rapid-application-delvelopment database. Nearly everything is
working quite well but this program relies on getting the name of the currently
logged in user by calling the Win16 function WNetGetUser16. This is a stub in
wine. I'm not capable to code this myself, but could anybody do so? I guess it
should not be that complicated. There should be the same function in Win32.
Maybe link them both together?

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |win16

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Dan Kegel   2009-02-06 07:22:10 ---
Can you build wine from source?
It ought to be very easy to tweak our stub to return a 
fake username.  I can send you a patch if you can build from source.
That would let you find out whether you need more WNet functions.

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #2 from Harvey   2009-02-06 07:32:42 ---
(In reply to comment #1)
> Can you build wine from source?

I am using arch linux. It should be possible to build a custom wine package.
> It ought to be very easy to tweak our stub to return a 
> fake username.  I can send you a patch if you can build from source.
> That would let you find out whether you need more WNet functions.

That would be great. Sure I am willing to test this one.

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Harvey  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Harvey   2009-02-17 04:20:38 ---
To put it clear: Yes I can compile from source if necessary.

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #4 from Andrew Nguyen   2009-03-03 03:34:14 ---
Created an attachment (id=19764)
 --> (http://bugs.winehq.org/attachment.cgi?id=19764)
Forward user.exe.WNetGetUser16 to mpr.dll.WNetGetUserA

Try this patch and see if your program works properly with it.

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Harvey  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Harvey   2009-03-03 13:27:18 ---
I applied the patch against 1.1.16 and it works like expected. Now I get my
username back when I read out the Superbase.UserName property, thus allowing me
to use my login procedure. Great! Now I can test the rest of the program. One
other bug is the dialog size (http://bugs.winehq.org/show_bug.cgi?id=17323)

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #6 from Vitaliy Margolen   2009-03-03 13:47:34 ---
Not fixed until patch is committed.

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #7 from Harvey   2009-03-03 14:15:18 ---
Sorry. Beginners mistake due to overwhelming happiness ;-)

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #8 from Andrew Nguyen   2009-03-23 04:24:50 ---
I've submitted a revised patch:

http://www.winehq.org/pipermail/wine-patches/2009-March/070948.html

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #9 from Dan Kegel   2009-03-23 05:05:26 ---
If that doesn't get accepted, you could try submitting
a test to win16test.googlecode.com and referring to
it next time you post the patch.

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #10 from Harvey   2009-09-15 16:35:29 ---
still can't find that patch in wine, WNetGetUser16 still is broken. What has
happened?

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #11 from Harvey   2009-10-02 04:42:49 ---
still present in current wine 1.1.30

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #12 from Stefan Leichter   2009-10-07 16:10:39 ---
Created an attachment (id=23975)
 --> (http://bugs.winehq.org/attachment.cgi?id=23975)
modified version of the previous patch

Please retest with this patch

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #13 from Harvey   2009-10-27 12:55:02 ---
(In reply to comment #12)
> Please retest with this patch

Sorry for the delayed answer but I am experiencing problems in compiling from
source which I have to solve before I can test the patch. I will report back
later, though.

Harvey

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #14 from Harvey   2009-10-29 14:38:21 ---
retested with wine-git as of today (2009-10-29). This patch is working for me.

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #15 from Harvey   2009-12-07 04:59:17 ---
Still present in wine 1.1.34

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #16 from Stefan Leichter   2009-12-07 12:24:33 ---
Patch is delayed until user.exe is separated from user32.dll. 
See http://www.winehq.org/pipermail/wine-devel/2009-October/079386.html

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Stefan Leichter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23975|0                           |1
        is obsolete|                            |

--- Comment #17 from Stefan Leichter   2010-01-09 06:14:41 ---
Created an attachment (id=25620)
 --> (http://bugs.winehq.org/attachment.cgi?id=25620)
new version of the patch after the dll separation

@Harvey

please retest with the new patch

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #18 from Harvey   2010-01-13 04:45:44 ---
Created an attachment (id=25705)
 --> (http://bugs.winehq.org/attachment.cgi?id=25705)
gcc output while compiling user.exe16

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #19 from Harvey   2010-01-13 04:47:18 ---
Stefan,

patched wine-git of today, gcc won't compile. See attachment.

Harvey

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Stefan Leichter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25620|0                           |1
        is obsolete|                            |

--- Comment #20 from Stefan Leichter   2010-01-13 13:11:11 ---
Created an attachment (id=25714)
 --> (http://bugs.winehq.org/attachment.cgi?id=25714)
next version of the patch

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #21 from Harvey   2010-01-14 05:30:01 ---
> next version of the patch

checked out wine-git of today: Works!

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #22 from Dmitry Timoshkov   2010-01-14 09:25:09 ---
Reported fixed.

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #23 from Nikolay Sivov   2010-01-14 09:28:18 ---
(In reply to comment #22)
> Reported fixed.

It's not implemented in git.

(In reply to comment #21)
> > next version of the patch
>
> checked out wine-git of today: Works!

You mean last Stefan's patch over git?

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #24 from Harvey   2010-01-14 09:42:45 ---
> It's not implemented in git.

True.
> > checked out wine-git of today: Works!
>
> You mean last Stefan's patch over git?

Sorry if my words were misleading. To be clear:
I applied the patch against wine-git and tested it. It works as expected. This
does not mean that the bug is fixed. The patch was not not implemented in git
by now. Stefan has to commit the patch now.

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Stefan Leichter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #25 from Stefan Leichter   2010-01-14 14:12:14 ---
patch send:
http://www.winehq.org/pipermail/wine-patches/2010-January/083756.html

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

--- Comment #26 from Stefan Leichter   2010-01-18 11:10:13 ---
Patch committed:
http://source.winehq.org/git/wine.git/?a=commit;h=5ef5ead15fbebc52b799e1b5e5...

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Harvey  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #27 from Harvey   2010-01-23 09:21:44 ---
working in wine 1.1.37. Yahoooooo! thanks to all, especially Stefan!

[Bug 17269] WNetGetUser missing in Win16

http://bugs.winehq.org/show_bug.cgi?id=17269

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #28 from Alexandre Julliard   2010-02-05 11:38:48 ---
Closing bugs fixed in 1.1.38.