https://bugs.winehq.org/show_bug.cgi?id=44965
Bug ID: 44965 Summary: Visual Studio xxxx Product: Wine Version: 3.3 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: critical Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: matthieu.brucher@gmail.com Distribution: ---
It seems that since wine 1.7 (yes, we don't upgrade wine very often, especially when it is working!), visual studio output is not respected anymore. Before, when cl.exe failed and displayed an error or a warning message, we would get the name of the error and then the location. When testing Wine 3.3, it seems that we don't get the location and subsequent error messages anymore.
This seems to happen with VS2013 and VS2017 at least.
https://bugs.winehq.org/show_bug.cgi?id=44965
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal Keywords| |regression
--- Comment #1 from Austin English austinenglish@gmail.com --- Not critical. Please run a regression test: https://wiki.winehq.org/RegressionTesting
https://bugs.winehq.org/show_bug.cgi?id=44965
--- Comment #2 from Matthieu Brucher matthieu.brucher@gmail.com --- Sorry, but this is not possible as I'm not allowed by my company to download a repository like that. And yes, this is critical for people that use VS through wine!
https://bugs.winehq.org/show_bug.cgi?id=44965
--- Comment #3 from Austin English austinenglish@gmail.com --- (In reply to Matthieu Brucher from comment #2)
Sorry, but this is not possible as I'm not allowed by my company to download a repository like that. And yes, this is critical for people that use VS through wine!
That may be; but given that this is the first report, it may not be very many people..
Not everyone has Visual Studio, so this bug report will likely be stalled until someone can run the regression test.
As an aside (not your fault of course), it's pretty silly if your company runs open source software but doesn't allow downloading open source code. If the problem is the firewall blocking the git protocol, you can download over HTTP/HTTPS.
https://bugs.winehq.org/show_bug.cgi?id=44965
--- Comment #4 from Matthieu Brucher matthieu.brucher@gmail.com --- OK, I'll try to find a way then :/ The issue is also that I have to test this VSéà&" which I don't have at home :(
And yes, I agree with you last comment...
https://bugs.winehq.org/show_bug.cgi?id=44965
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Visual Studio xxxx |Microsoft Visual Studio | |2013, 2017: compiler output | |(cl.exe) is no longer | |properly shown in output | |pane (missing file | |location, subsequent error | |messages) CC| |focht@gmx.net
--- Comment #5 from Anastasius Focht focht@gmx.net --- Hello folks,
please read how to properly report bugs: https://wiki.winehq.org/Bugs
A summary line "Visual Studio xxxx" is not useful at all. Refining the summary based on the input.
Regards
https://bugs.winehq.org/show_bug.cgi?id=44965
tokktokk fdsfgs@krutt.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs@krutt.org
https://bugs.winehq.org/show_bug.cgi?id=44965
--- Comment #6 from Matthieu Brucher matthieu.brucher@gmail.com --- With the help of my boss, we figured out that the issue is LOAD_LIBRARY_AS_DATAFILE_EXCLUSIVE and LOAD_LIBRARY_AS_IMAGE_RESOURCE management (commits e55101715cee244ef1857d9a975f87a9d6e3fac0, e1d8c176efdd04fb2a0f99426e1ad9962589b9ec and 8d82ab4ae7e3375e3e100f2bfaa0b6bf1466877d). The issue arise because all the localized strings from cl come from clui.dll (error messages, and even the main banner). It seems that with these patches, the strings that cl tried to load are always empty, pointing to an issue in the way these two flags are used. To reproduce the error, it is as easy as installing VS2017 (community edition for instance) and compile a file with just #error. The current wine would show:
test.cpp test.cpp(2) : fatal error C1189:
When the error message should be: Microsoft (R) C/C++ Optimizing Compiler Version 18.00.31101 for x86 Copyright (C) Microsoft Corporation. All rights reserved.
test.cpp test.cpp(2) : fatal error C1189: #error :
https://bugs.winehq.org/show_bug.cgi?id=44965
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Probably a duplicate of 44659 then. You should retest with Wine >= 3.4.
https://bugs.winehq.org/show_bug.cgi?id=44965
--- Comment #8 from Matthieu Brucher matthieu.brucher@gmail.com --- Great! I'll try the patch, as I can't get wine 3.4 right now.
https://bugs.winehq.org/show_bug.cgi?id=44965
--- Comment #9 from Matthieu Brucher matthieu.brucher@gmail.com --- Indeed, I confirmed that your patch fixed the issue, thanks a lot!
https://bugs.winehq.org/show_bug.cgi?id=44965
Matthieu Brucher matthieu.brucher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE
--- Comment #10 from Matthieu Brucher matthieu.brucher@gmail.com --- Marking as duplicate.
*** This bug has been marked as a duplicate of bug 44659 ***
https://bugs.winehq.org/show_bug.cgi?id=44965
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de Status|RESOLVED |CLOSED
--- Comment #11 from André H. nerv@dawncrow.de --- closing dup