[Bug 38869] New: Multiple games (Torchlight 1-2, Evil Genius) have rendering issues with open source drivers when GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=38869

Bug ID: 38869
           Summary: Multiple games (Torchlight 1-2, Evil Genius) have
                    rendering issues with open source drivers when GLSL
                    enabled
           Product: Wine
           Version: 1.7.46
          Hardware: x86
               URL: http://www.fileplanet.com/145023/140000/fileinfo/Evil-
                    Genius-Demo
                OS: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Upstream bug report:
https://bugs.freedesktop.org/show_bug.cgi?id=91232

The bug represents itself as shiny, flashing boxes on surfaces like character
models and objects in multiple games. The proposed patch from the upstream bug
report apparently fixes the problem, yet Mesa devs have the suspicion that the
error is originating from Wine's GLSL compiler.
All those games "set gl_FrontColor but not gl_FrontSecondaryColor in the vertex
shader and then they use gl_SecondaryColor in the fragment shader...this is
undefined" (sorry if misinterpreting, I'm no technician)

The games "magically" work with Nvidia blob 340.76, and they render properly in
Wine with ARB shaders.The issue was reproduced on i965/hsw too, and doesn't
occur with llvmpipe.

Terminal output doesn't show anything unusual, this is from Torchlight:
> fixme:d3d:debug_d3dformat Unrecognized 0x434f5441 (as fourcc: ATOC) WINED3DFORMAT!
> fixme:d3d:wined3d_get_format Can't find format unrecognized (0x434f5441) in the format lookup table
> fixme:d3d_texture:wined3d_texture_set_autogen_filter_type texture 0x16dcb468, filter_type WINED3D_TEXF_ANISOTROPIC stub!
> fixme:d3d_texture:wined3d_texture_generate_mipmaps texture 0x16dcb468 stub!
> fixme:d3d9:Direct3DShaderValidatorCreate9 stub
> fixme:d3d:wined3d_device_decref Device released with resources still bound, acceptable but unexpected.
> fixme:d3d:wined3d_device_decref Leftover resource 0x200e90 with type WINED3D_RTYPE_SURFACE (0x1).
> fixme:d3d:wined3d_device_decref Leftover resource 0x200cd8 with type WINED3D_RTYPE_TEXTURE (0x3).

Please let me know if you need debug logs, the problem is reproducible in
Torchlight demo on Steam (models are corrupted on the title screen):
http://store.steampowered.com/app/41500/

Alternatively you can try Evil Genius demo, download link is in the url field
above.

wine-1.7.46-193-g8b566b1
VGA compatible controller: NVIDIA Corporation G92 [GeForce GTS 250] (rev a2)
nouveau + mesa from git

[Bug 38869] Multiple games (Torchlight 1-2, Evil Genius) have rendering issues with open source drivers when GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=38869

--- Comment #1 from Henri Verbeet  ---
Yeah, this is something we should handle.

[Bug 38869] Multiple games (Torchlight 1-2, Evil Genius) have rendering issues with open source drivers when GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=38869

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Matteo Bruni  ---
Actually I am fixing this with the patches to avoid using builtin varyings on
core profile. I needed this because otherwise OS X core profile errors out at
link time for varyings read by the fragment shader and not written by the
vertex shader.
Probably I should separate the fix out from those patches and send it before
the rest. I'll look into that.

I also have a test for uninitialized varyings but I just realized that I'm not
checking the alpha component (because getPixelColor()). I have to fix that.

[Bug 38869] Multiple games (Torchlight 1-2, Evil Genius) have rendering issues with open source drivers when GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=38869

--- Comment #3 from Matteo Bruni  ---
This should be fixed with 97ee9451edae82154b289cb57b46ef13aedd58b8 and previous
patches, at last. Let me know if it's not the case.

[Bug 38869] Multiple games (Torchlight 1-2, Evil Genius) have rendering issues with open source drivers when GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=38869

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |97ee9451edae82154b289cb57b4
                   |                            |6ef13aedd58b8
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Béla Gyebrószki  ---
(In reply to Matteo Bruni from comment #3)
> This should be fixed with 97ee9451edae82154b289cb57b46ef13aedd58b8 and
> previous patches, at last. Let me know if it's not the case.

All those games in the bug title (and a few others that I knew of) render
properly now, thank you Matteo.

wine-1.7.52-190-gd548639
OpenGL vendor string: nouveau
OpenGL renderer string: Gallium 0.4 on NV92
OpenGL core profile version string: 3.3 (Core Profile) Mesa 11.1.0-devel

[Bug 38869] Multiple games (Torchlight 1-2, Evil Genius) have rendering issues with open source drivers when GLSL enabled

https://bugs.winehq.org/show_bug.cgi?id=38869

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.53.