[Bug 42798] New: MsiGetPatchInfoEx returns incorrect values for UNINSTALLABLE, PATCHSTATE properties

https://bugs.winehq.org/show_bug.cgi?id=42798

Bug ID: 42798
           Summary: MsiGetPatchInfoEx returns incorrect values for
                    UNINSTALLABLE, PATCHSTATE properties
           Product: Wine
           Version: 2.5
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ArchLinux

On Windows, MsiGetPatchInfoEx for:

INSTALLPROPERTY_UNINSTALLABLE and
INSTALLPROPERTY_PATCHSTATE

returns a number converted to a string consisting of ascii digits (0x30 -
0x39).

On Wine, this function returns raw DWORD registry value.

For example, if "Uninstallable" property has a DWORD value 0 in registry,
Windows' MsiGetPatchInfoEx returns '0' (ascii digit 0x30), but Wine's
implementation returns a null byte (0x00).

If necessary, I can send some C code demonstrating the bug.

[Bug 42798] MsiGetPatchInfoEx returns incorrect values for UNINSTALLABLE, PATCHSTATE properties

https://bugs.winehq.org/show_bug.cgi?id=42798

--- Comment #1 from Hans Leidekker  ---
(In reply to pgkos.bugzilla from comment #0)
> For example, if "Uninstallable" property has a DWORD value 0 in registry,
> Windows' MsiGetPatchInfoEx returns '0' (ascii digit 0x30), but Wine's
> implementation returns a null byte (0x00).
>
> If necessary, I can send some C code demonstrating the bug.

That would be nice. Note that we already have tests for MsiGetPatchInfoEx in
dlls/msi/tests/patch.c. It shouldn't be hard to add some.

[Bug 42798] MsiGetPatchInfoEx returns incorrect values for UNINSTALLABLE, PATCHSTATE properties

https://bugs.winehq.org/show_bug.cgi?id=42798

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f3adb4a17a1428b9f9a14c92486
                   |                            |5dc3bd45ea508
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Hans Leidekker  ---
Should be fixed by f3adb4a17a1428b9f9a14c924865dc3bd45ea508.

[Bug 42798] MsiGetPatchInfoEx returns incorrect values for UNINSTALLABLE, PATCHSTATE properties

https://bugs.winehq.org/show_bug.cgi?id=42798

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 2.7.

[Bug 42798] MsiGetPatchInfoEx returns incorrect values for UNINSTALLABLE, PATCHSTATE properties

https://bugs.winehq.org/show_bug.cgi?id=42798

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x

[Bug 42798] MsiGetPatchInfoEx returns incorrect values for UNINSTALLABLE, PATCHSTATE properties

https://bugs.winehq.org/show_bug.cgi?id=42798

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #4 from Michael Stefaniuc  ---
Removing the 2.0.x milestone from bugs included in 2.0.2.