https://bugs.winehq.org/show_bug.cgi?id=51159
Bug ID: 51159 Summary: test_NLSVersion() fails on Windows 10 >= 2004 in kernel32:locale Product: Wine Version: 6.8 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com Distribution: ---
test_NLSVersion() fails on Windows 10 >= 2004 in kernel32:locale:
locale.c:6900: Test failed: IsValidNLSVersion succeeded
This is the test where dwNLSVersion is decreased compared to its initial version:
info.dwNLSVersion -= 0x200; ret = pIsValidNLSVersion( COMPARE_STRING, L"en-US", &info ); ok( !ret, "IsValidNLSVersion succeeded\n" );
Traces show that Windows 8.1 to Windows 10 1809 have NLSVersion=6020f, while Windows 10 >= 2004 has NLSVersion=60305.
Maybe the test fails because the older Windows accept anything in the 602xx range and 60206 (60305+1-0x100) falls in that range? What was the point of that test?
This test was introduced by the commit below:
commit 84cca2baae23c6afa0c8070f5009fdcfa218e039 Author: Alexandre Julliard julliard@winehq.org Date: Fri Mar 20 14:43:45 2020 +0100
kernelbase: Implement IsValidNLSVersion().
Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=51159
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |84cca2baae23c6afa0c8070f500 | |9fdcfa218e039 Keywords| |source, testcase
https://bugs.winehq.org/show_bug.cgi?id=51159
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |1431702f5a0085fabdb8e22651d | |ce18defd07148
--- Comment #1 from François Gouget fgouget@codeweavers.com --- This is fixed by the commit below:
commit 1431702f5a0085fabdb8e22651dce18defd07148 Author: Alexandre Julliard julliard@winehq.org AuthorDate: Thu Dec 16 17:04:46 2021 +0100
kernel32/tests: Fix some test failures on Windows.
Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=51159
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #2 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.0-rc3.