[Bug 18647] New: Custom textbox/combobox fields in a listview

http://bugs.winehq.org/show_bug.cgi?id=18647

Summary: Custom textbox/combobox fields in a listview
           Product: Wine
           Version: 1.1.22
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hi,

The use of a custom listview control (e.g. xlistctrl) with user drawn controls
like editable text fields and comboboxes there are various drawing bugs and you
can't properly 'enter' the control. I mean that in case of a combobox you can't
select custom values and in case of a text field it isn't always editable.

An example of a control which shows the problem is at
http://www.codeproject.com/KB/list/xlistctrl.aspx

Regards,
Roderick Colenbrander

[Bug 18647] Custom textbox/combobox fields in a listview

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #1 from Roderick Colenbrander   2009-05-28 13:53:49 ---
Created an attachment (id=21386)
 --> (http://bugs.winehq.org/attachment.cgi?id=21386)
Test case illustrating (including source) demonstrating the problem

Adding a test case to illustrate the issues. The combobox seems to work a bit
now but the text field isn't always editable and it appears at the wrong
location.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Custom textbox/combobox     |Custom textbox/combobox
                   |fields in a listview        |fields in a listview don't
                   |                            |work

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #2 from Nikolay Sivov   2009-05-29 09:27:30 ---
Just for reference - demo app for XListCtrl should look a bit better with today
git after this commits:

http://source.winehq.org/git/wine.git/?a=commit;h=dd24e5de8c3a8e1241b8c3dca8...
http://source.winehq.org/git/wine.git/?a=commit;h=3cd15e5db5b9b89abbc3d5a7a1...

Edits and combos still don't work.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #3 from Roderick Colenbrander   2009-06-04 13:40:03 ---
Thanks for the great work. I recently tried the xlistcontrol demo (the
codeproject one) and it already works quite a bit better. The demo I attached
didn't work yet because it uses only the edit / comboboxes which as you
mentioned don't work properly. On the latest Wine it seems to crash Wine. I
haven't debugged the issue yet, so I'm not sure what caused the regression.

Roderick

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #4 from Nikolay Sivov   2009-06-04 16:31:48 ---
(In reply to comment #3)
> The demo I attached
> didn't work yet because it uses only the edit / comboboxes which as you
> mentioned don't work properly. On the latest Wine it seems to crash Wine. I
> haven't debugged the issue yet, so I'm not sure what caused the regression.

I'll try to find out, started bisecting already.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #5 from Nikolay Sivov   2009-06-05 05:13:55 ---
(In reply to comment #3)
> I haven't debugged the issue yet, so I'm not sure what caused the regression.
>
> Roderick

Thanks for report, patch sent to remove this change:

http://www.winehq.org/pipermail/wine-patches/2009-June/073865.html

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #6 from Nikolay Sivov   2009-06-05 09:08:34 ---
(In reply to comment #5)
> http://www.winehq.org/pipermail/wine-patches/2009-June/073865.html

http://source.winehq.org/git/wine.git/?a=commit;h=d5319303f18a1f1643612b69d3...

Shouldn't crash anymore. I'll try to find time at weekend to continue with
this.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #7 from Nikolay Sivov   2009-06-06 06:56:08 ---
Created an attachment (id=21598)
 --> (http://bugs.winehq.org/attachment.cgi?id=21598)
Patch set to position edit box.

Hi, Roderick.

Attached patches (on top of 1.1.23) solve edit box position issue.
Problem was in missed position notification caused by moving edit box on
creation but no after LVN_BEGINLABELEDIT notification.

Next step is to fix filling with COLOR_WINDOW color.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #8 from Roderick Colenbrander   2009-06-06 08:22:18 ---
(In reply to comment #7)
> Created an attachment (id=21598)

--> (http://bugs.winehq.org/attachment.cgi?id=21598) [details]
> Patch set to position edit box.
>
> Hi, Roderick.
>
> Attached patches (on top of 1.1.23) solve edit box position issue.
> Problem was in missed position notification caused by moving edit box on
> creation but no after LVN_BEGINLABELEDIT notification.
>
> Next step is to fix filling with COLOR_WINDOW color.

I just tried the patch and it program indeed works quite a bit better. It is
still hard (you have to double click a few times) to enter for instance the
edit box. I guess it has somehow to do with highlighting a row which prevents
some events on getting received by the edit box or so?

Roderick

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #9 from Nikolay Sivov   2009-06-06 08:29:41 ---
(In reply to comment #8)
> I just tried the patch and it program indeed works quite a bit better. It is
> still hard (you have to double click a few times) to enter for instance the
> edit box.

No, actually it's enough to select a row and a single click on subitem to
create edit.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #10 from Nikolay Sivov   2009-06-06 09:00:13 ---
(In reply to comment #9)
> (In reply to comment #8)
> > I just tried the patch and it program indeed works quite a bit better. It is
> > still hard (you have to double click a few times) to enter for instance the
> > edit box.
>
> No, actually it's enough to select a row and a single click on subitem to
> create edit.

I mean attached demo, not from codeproject.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #11 from Roderick Colenbrander   2009-06-06 09:06:04 ---
Yeah it seems to work after all (was double clicking and not single clicking
properly). In the full app (I can ask on monday) for some reason the expanded
combobox list is not shown at the right y-coordinate (it is shown lets say 1 or
2 rows too low).

Roderick

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21598|0                           |1
        is obsolete|                            |

--- Comment #12 from Nikolay Sivov   2009-06-08 11:06:40 ---
(From update of attachment 21598)
Committed (main commit):
http://source.winehq.org/git/wine.git/?a=commit;h=ae0d36304368556de2a9bc8091...

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #13 from Nikolay Sivov   2010-05-07 08:22:23 ---
So what are the remaining problems here? I'm able to select something from
combos and edit values.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #14 from Roderick Colenbrander   2010-05-07 09:12:36 ---
I don't have Windows by hand right now but as far as I remember the behavior on
Windows is that when you click on the 'text field' while the line doesn't have
focus, the text field becomes editable. On Wine, the first click on the text
field selects the row and the second makes the text field editable.

A second problem in the sample seems to be that after you have edited the text
field, the text in the first column disappears. When you select the row again
(which forces a refresh) it appears again.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Jerome Leclanche  2011-04-01 09:49:39 CDT ---
Are there still issues present? Seems everything has been committed.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #16 from Nikolay Sivov  2011-04-01 09:51:22 CDT ---
(In reply to comment #15)
> Are there still issues present? Seems everything has been committed.

Test application is attached.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Bruno Jesus  2011-11-19 16:19:48 CST ---
There are still a few issues in this bug. I've tested in 1.3.33 and XP.

1 - Wine requires 2 clicks to get to the edit box in column 1.
Windows requires a single click, if line is not selected it will be selected
and the edit box will be created after 1 second. Wine requires to first select
the line and then the second click shows the edit box.

2 - Wine does not redraw the column zero while editing column 1.
Wine erases the column zero contents while the edit box from column 1 is
visible. Windows highlights the column zero and does not erase it's text.

3 - Windows allows editting the column one value if any spot in the column is
clicked.
Wine requires you to click over the text. If you click out of the text the edit
box will be created and then destroyed instantly.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

--- Comment #18 from Bruno Jesus  2013-03-09 17:16:58 CST ---
Still like my previous comment in wine 1.5.25.

[Bug 18647] Custom textbox/combobox fields in a listview don't work

http://bugs.winehq.org/show_bug.cgi?id=18647

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 18647] Custom textbox/combobox fields in a listview don't work

https://bugs.winehq.org/show_bug.cgi?id=18647

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 18647] Custom textbox/combobox fields in a listview don't work

https://bugs.winehq.org/show_bug.cgi?id=18647

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Fabian Maurer  ---
Issues from comment 17 are still present in wine-3.0-rc5.

Also, found another issue:

4 - When line 1 is selected, and the dropbox-arrow in colum 3 is clicked, it
shows the dropdown for a split-second and then hides it again, while on windows
it keeps displaying it.

Should we split this bug into separate reports, for each issue one?