[Bug 33742] New: [UPlay]Does not works correctly since the latest update

http://bugs.winehq.org/show_bug.cgi?id=33742

Bug #: 33742
           Summary: [UPlay]Does not works correctly since the latest
                    update
           Product: Wine
           Version: 1.5.31
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Hi,

There was an Uplay update the 4th June and since this date, UPlay does not
works correctly.

When there isn't problem, like on my Windows partition for example, after to
launch UPlay :
1-A first window appears named "UPlay : Update of UPlay". At this step, UPlay
check if an update is available or not.
2-Then, the second window appears to log in to open UPlay.

Before the update, these 2 steps work without problem. Yesterday, when i launch
UPlay, i had the update download but after the installation when i relaunch
UPlay, i stay at the first step, like if Uplay can't pass the update check to
pass to the login step.

I tried UPlay on Debian Wheezy/Sid and Archlinux 64Bits, on these 3 systems i
have the same problem.

It's possible to reproduce this problem, download UPlayInstaller here
(http://static3.cdn.ubi.com/orbit/launcher_installer/UplayInstaller.exe)
It's not important if you haven't UPlay account, install and launch it and you
have the problem.

Thanks,
Max

[Bug 33742] [UPlay]Does not works correctly since the latest update

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #1 from Berillions  2013-06-07 05:51:52 CDT ---
Created attachment 44680
  --> http://bugs.winehq.org/attachment.cgi?id=44680
+winsock log

I don't know if the problem can come from "winsock" but if i launch Uplay with
"WINEDEBUG=+winsock", i have more message like :

trace:winsock:WS_select read 0x7ae4e7a8, write (nil), excp 0x7ae4e8ac timeout
0x7ae4e774

I attach the complete log.

[Bug 33742] [UPlay]Does not works correctly since the latest update

http://bugs.winehq.org/show_bug.cgi?id=33742

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Qian Hong  2013-06-07 07:12:33 CDT ---
Hi Berillions, what is the last Wine version works with UPlay?

Could you please do a regression test?
http://wiki.winehq.org/RegressionTesting

Thanks a lot!

[Bug 33742] [UPlay]Does not works correctly since the latest update

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #3 from Berillions  2013-06-07 09:26:50 CDT ---
(In reply to comment #2)
> Hi Berillions, what is the last Wine version works with UPlay?
>
> Could you please do a regression test?
> http://wiki.winehq.org/RegressionTesting
>
> Thanks a lot!

Hi Qian,

For me it's not a regression because :
- UPlay 3.0.0 worked without problem with wine 1.5.31 and older.
- When i tried UPlay 3.0.1 with wine 1.5.31/*.30/*.29 and *.28, i have the same
problem = I can't pass the update check...

So, the problem come from the new version of UPlay which does not work with
Wine, i think.

In the output console when i launch the app without WINEDEBUG options, i have
these messages :
berillions@debian64:~/.wine2/drive_c/Program Files/Ubisoft/Ubisoft Game
Launcher$ /home/berillions/Desktop/Wine32/home/wine-1.5.31/wine Uplay.exe 
fixme:urlmon:DownloadBSC_OnProgress Unsupported status 3
fixme:wininet:InternetLockRequestFile STUB
fixme:storage:create_storagefile Storage share mode not implemented.
fixme:iphlpapi:NotifyAddrChange (Handle 0xfde900, overlapped 0xfde90c): stub
wine: configuration in '/home/berillions/.wine2' has been updated.
p11-kit: couldn't load module:
/usr/lib/i386-linux-gnu/pkcs11/gnome-keyring-pkcs11.so:
/usr/lib/i386-linux-gnu/pkcs11/gnome-keyring-pkcs11.so: Ne peut ouvrir le
fichier d'objet partagé: Aucun fichier ou dossier de ce type
fixme:heap:HeapSetInformation (nil) 1 (nil) 0
fixme:winsock:WSAEnumNameSpaceProvidersA (0x5b0a230 0x5b1df74) Stub!
fixme:winsock:WSALookupServiceBeginW (0x1517e69c 0x00000ff0 0x1517e6e4) Stub!
[0607/162448:ERROR:network_change_notifier_win.cc(160)] WSALookupServiceBegin
failed with: 8
fixme:iphlpapi:NotifyAddrChange (Handle 0x1517e574, overlapped 0x6108dc8): stub
fixme:winsock:WSALookupServiceBeginW (0x1517e6dc 0x00000ff0 0x1517e724) Stub!
[0607/162448:ERROR:network_change_notifier_win.cc(160)] WSALookupServiceBegin
failed with: 8
fixme:ntdll:NtLockFile I/O completion on lock not implemented yet

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[UPlay]Does not works       |UPlay 3.0.1 does not work
                   |correctly since the latest  |
                   |update                      |

--- Comment #4 from Rosanne DiMesio  2013-06-07 09:32:26 CDT ---
Confirming and revising the summary to make it clearer that this is not a
regression in Wine, but a new version of UPlay that does not work.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Rosanne DiMesio  2013-06-07 09:32:42 CDT ---
Really confirming.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://static3.cdn.ubi.com/
                   |                            |orbit/launcher_installer/Up
                   |                            |layInstaller.exe
                 CC|                            |[e-mail]

--- Comment #6 from Dan Kegel  2013-06-07 09:55:01 CDT ---
I saw a similar crash with current wine in a fresh wineprefix;
the crash happens early, before any window shows up.
Right before the crash, +relay shows

003b:Call KERNEL32.OutputDebugStringA(15175f90
"C:\P4ws\massgate-MAIN\massgate\uplay_pc\3.0\live\shared\libs\ui\mg\ui\FontCollection.cpp(33)
: ASSERT: Could not add font to font collection\n") ret=0088f353

so the null-pointer write may have been how their assert makes its displeasure
known.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |crypt32

--- Comment #7 from Qian Hong  2013-06-07 10:13:19 CDT ---
Thank for the info.

Backtrace on update checking shows call to crypt32 functions, with winetricks
-q crypt32 the application complains missing function entry point of
CryptStringToBinaryW. However, if I replace winetricks' crypt32.dll to WinXP's
crypt32.dll, I can get UPlay finishing the update checking.

Setting component to crypt32.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #8 from Qian Hong  2013-06-07 10:17:54 CDT ---
Created attachment 44686
  --> http://bugs.winehq.org/attachment.cgi?id=44686
Log: +tid,+crypt trace

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #9 from Berillions  2013-06-07 10:24:42 CDT ---
(In reply to comment #8)
> Created attachment 44686 [details]
> Log: +tid,+crypt trace

If i understand, the problem come from a function not implement in the crypt32
dll of wine ?

To resolv the problem, i must to find a crypt32.dll from WinXP so ?

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #10 from Qian Hong  2013-06-07 10:32:24 CDT ---
(In reply to comment #9)
> (In reply to comment #8)
> > Created attachment 44686 [details]
> > Log: +tid,+crypt trace
>
> If i understand, the problem come from a function not implement in the crypt32
> dll of wine ?
>
> To resolv the problem, i must to find a crypt32.dll from WinXP so ?

Not a function not implemented, but some crypt32 function maybe buggy.
You can find a native crypt32 as a temporary workaround if you have a licensed
Windows, however we hope this bug fix in Wine someday so no native dll override
is needed :)

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #11 from Berillions  2013-06-07 10:48:30 CDT ---
(In reply to comment #6)
> I saw a similar crash with current wine in a fresh wineprefix;
> the crash happens early, before any window shows up.
> Right before the crash, +relay shows
>
> 003b:Call KERNEL32.OutputDebugStringA(15175f90
> "C:\P4ws\massgate-MAIN\massgate\uplay_pc\3.0\live\shared\libs\ui\mg\ui\FontCollection.cpp(33)
> : ASSERT: Could not add font to font collection\n") ret=0088f353
>
> so the null-pointer write may have been how their assert makes its displeasure
> known.

Hi Dan,

For your crash, i already see somechere "FontCollection.cpp" => See my bug
report 33673, install gdiplus and UPlay works.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

Manu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Manu  2013-06-15 16:19:37 CDT ---
I added both native crypt32.dll as well as I installed gdiplus (first gdiplus)
- and I'm still stuck at the updating screen.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #13 from Berillions  2013-06-15 16:26:49 CDT ---
(In reply to comment #12)
> I added both native crypt32.dll as well as I installed gdiplus (first gdiplus)
> - and I'm still stuck at the updating screen.

1- Install crypt32 thanks to winetricks
2- Replace systems32/crypt32.dll by real crypt32.dll from Windows XP (You can
send me a MP)

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #14 from Manu  2013-06-15 18:01:49 CDT ---
(In reply to comment #13)
> (In reply to comment #12)
> > I added both native crypt32.dll as well as I installed gdiplus (first gdiplus)
> > - and I'm still stuck at the updating screen.
>
> 1- Install crypt32 thanks to winetricks
> 2- Replace systems32/crypt32.dll by real crypt32.dll from Windows XP (You can
> send me a MP)

I did exactly that - but I'll reinstall the game into a new wineprefix soon to
test if that fixes is.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #15 from Dan Kegel  2013-06-19 09:21:44 CDT ---
For what it's worth: winetricks-20130617 and later download the right
crypt32 (from xp) now.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from [e-mail] 2013-06-21 07:55:21 CDT ---
Hi,
I have the same issue, also after installing native gdiplus and crypt32. I'm
trying to launch Might & Magic Heroes 6. Running Arch on x64 with wine 1.6rc2
and winetricks-20130617.
Cheers,
 Jelle.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #17 from Berillions  2013-06-21 09:34:44 CDT ---
(In reply to comment #16)
> Hi,
> I have the same issue, also after installing native gdiplus and crypt32. I'm
> trying to launch Might & Magic Heroes 6. Running Arch on x64 with wine 1.6rc2
> and winetricks-20130617.
> Cheers,
>  Jelle.

You must to set crypt32/gdiplus to native only for Uplay.exe in winecfg not for
all applications. I created a patch to add the UPlay installation available
into winetricks. I'm waiting if Dan accept my patch.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #18 from [e-mail] 2013-06-21 09:46:02 CDT ---
Hi Berillions,

I believe I have done that... I found the patch online and have manually
replicated it by setting crypt32/gdiplus to native for Uplay.exe only. I still
get the same crash:

wine: Unhandled page fault on write access to 0x00000000 at address 0x8996f2
(thread 0066), starting debugger...

I tried both launching the game or launching Uplay.exe standalone. Any idea
what I could be doing wrong?

Thanks,
 Jelle.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #19 from Berillions  2013-06-21 11:03:08 CDT ---
(In reply to comment #18)
> I believe I have done that... I found the patch online and have manually
> replicated it by setting crypt32/gdiplus to native for Uplay.exe only. I still
> get the same crash:
>
> wine: Unhandled page fault on write access to 0x00000000 at address 0x8996f2
> (thread 0066), starting debugger...

You did not forget to delete the dlls for all applications ?
It's very strange because i installed more 10 times UPlay with these workaround
and i never had problems with my games.

When you set crypt32 to native for Uplay, you set a Win version for this exe ?
Don't set "Uses global parameters"

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #20 from Austin English  2013-06-21 13:27:47 CDT ---
(In reply to comment #19)
> (In reply to comment #18)
> > I believe I have done that... I found the patch online and have manually
> > replicated it by setting crypt32/gdiplus to native for Uplay.exe only. I still
> > get the same crash:
> >
> > wine: Unhandled page fault on write access to 0x00000000 at address 0x8996f2
> > (thread 0066), starting debugger...
>
> You did not forget to delete the dlls for all applications ?
> It's very strange because i installed more 10 times UPlay with these workaround
> and i never had problems with my games.
>
> When you set crypt32 to native for Uplay, you set a Win version for this exe ?
> Don't set "Uses global parameters"

Please use the forums/appdb for support questions like this.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

Paul The Tall  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from Paul The Tall  2013-06-25 04:33:59 CDT ---
(In reply to comment #18)
> Hi Berillions,
>
> I believe I have done that... I found the patch online and have manually
> replicated it by setting crypt32/gdiplus to native for Uplay.exe only. I still
> get the same crash:
>
> wine: Unhandled page fault on write access to 0x00000000 at address 0x8996f2
> (thread 0066), starting debugger...
>
> I tried both launching the game or launching Uplay.exe standalone. Any idea
> what I could be doing wrong?
>
> Thanks,
>  Jelle.

Awesome, uplay launches and now also it updates the game properly, but now it
fails to launch....we are so close....

err:winediag:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make
sure that ntlm_auth >= 3.0.25 is in your path. Usually, you can find it in the
winbind package of your distribution.
fixme:heap:HeapSetInformation 0x0 1 0x0 0
fixme:winsock:WSAEnumNameSpaceProvidersA (0x5b0a2a0 0x5b1dfe4) Stub!
fixme:file:MoveFileWithProgressW MOVEFILE_WRITE_THROUGH unimplemented
fixme:ras:RasEnumConnectionsW (0x157250,0x5b1f298,0xf830004),stub!
fixme:ras:RasEnumConnectionsW RAS support is not implemented! Configure program
to use LAN connection/winsock instead!
fixme:winsock:WSALookupServiceBeginW (0x1517f2fc 0x00000ff0 0x1517f344) Stub!
[0625/112959:ERROR:network_change_notifier_win.cc(160)] WSALookupServiceBegin
failed with: 8
fixme:iphlpapi:NotifyAddrChange (Handle 0x1517f1d4, overlapped 0x625cd08): stub
fixme:winsock:WSALookupServiceBeginW (0x1517f33c 0x00000ff0 0x1517f384) Stub!
[0625/112959:ERROR:network_change_notifier_win.cc(160)] WSALookupServiceBegin
failed with: 8
fixme:win:EnumDisplayDevicesW ((null),0,0x5b1f0c8,0x00000000), stub!
fixme:ntdll:NtLockFile I/O completion on lock not implemented yet
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:ole:NdrCorrelationInitialize (0x22a86d28, 0x22a86914, 1024, 0x0): stub
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:ole:NdrCorrelationInitialize (0x22a86d28, 0x22a86914, 1024, 0x0): stub
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:ole:NdrCorrelationInitialize (0x22a86d28, 0x22a86914, 1024, 0x0): stub
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.
fixme:toolhelp:CreateToolhelp32Snapshot Unimplemented: heap list snapshot
fixme:toolhelp:Heap32ListFirst : stub
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:ole:NdrCorrelationInitialize (0x22a86d28, 0x22a86914, 1024, 0x0): stub
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.
[0625/113020:INFO:CONSOLE(0)] "Uncaught ReferenceError: uplayMessage is not
defined," source: (0)
[0625/113020:INFO:CONSOLE(0)] "Uncaught ReferenceError: uplayMessage is not
defined," source: (0)
2013-06-25 11:30:27 [  99] [INFO  ]  : msg=Create Orbit session object
2013-06-25 11:30:27 [ 102] [DEBUG ]  : argv: "C:\Program Files\Ubisoft\Tom
Clancy's H.A.W.X. 2\HAWX2.exe"
2013-06-25 11:30:27 [  99] [INFO  ]  : msg=Orbit session created. Start Ubisoft
Launcher
2013-06-25 11:30:27 [  99] [INFO  ]  : msg=Ubi Launcher started
fixme:heap:HeapSetInformation 0x0 1 0x0 0
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.
fixme:ntdll:server_ioctl_file Unsupported ioctl 110004 (device=11 access=0
func=1 method=0)
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.
2013-06-25 11:33:23 [  76] [INFO  ]  : msg=Create Orbit session object
2013-06-25 11:33:23 [  76] [INFO  ]  : msg=Orbit session created. Start Ubisoft
Launcher
2013-06-25 11:33:23 [  93] [DEBUG ]  : argv: "C:\Program Files\Ubisoft\Tom
Clancy's H.A.W.X. 2\HAWX2.exe"
2013-06-25 11:33:23 [  76] [INFO  ]  : msg=Ubi Launcher started
fixme:heap:HeapSetInformation 0x0 1 0x0 0
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:ole:NdrCorrelationInitialize (0x22a86d28, 0x22a86914, 1024, 0x0): stub
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.
fixme:ntdll:server_ioctl_file Unsupported ioctl 110004 (device=11 access=0
func=1 method=0)
fixme:winsock:WSAIoctl ignoring keepalive interval and timeout
fixme:secur32:schan_imp_get_max_message_size Returning 1 << 14.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

Thomas Luquet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

Yuri Shishenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #22 from Yuri Shishenko  2013-07-18 09:19:19 CDT ---
Uplay was updated to 3.1.0 and now it doesn't crashes if crypt32 is not
overridden. However, it cannot connect to network -- tries to establish proxy
connection. So it still needs native crypt32.

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #23 from [e-mail] 2013-07-28 20:17:46 CDT ---
Hi

Uplay works on my case with assasins creed revelations (STEAM Version)
(28/07/2013)

But its neccesary crypt32.dll as native and also necessary on binary uplay
directory this dlls: libcef.dll and msasn1.dll

i hope helpfull with needed

[Bug 33742] UPlay 3.0.1 does not work

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #24 from [e-mail] 2013-07-28 22:20:02 CDT ---
and same method works with prince of persia forgotten sands

[Bug 33742] UPlay 3.0.1 needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UPlay 3.0.1 does not work   |UPlay 3.0.1 needs native
                   |                            |crypt32

--- Comment #25 from Dan Kegel  2013-07-29 09:40:19 CDT ---
Let's make this bug just about the crypt32 problem.

Please open a new bug for the asn1 problem.
Please mention which uplay games (real ones, not web ones) you've used that
do require 'winetricks asn1', and which ones don't.  Also be sure to mention
what version of wine you're using.

libcef.dll is part of many apps (probably uplay, steam, and various games),
and is not part of Windows or Wine, so that's at the very least a different
bug, and possibly invalid.

[Bug 33742] UPlay 3.0.1 needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #26 from Dan Kegel  2013-07-29 09:41:10 CDT ---
(Sorry, that's "winetricks msasn1".)

[Bug 33742] UPlay 3.0.1 needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #27 from Dan Kegel  2013-07-29 21:42:34 CDT ---
('winetricks uplay dotnet40' is enough to let you launch and play Sims
Medieval, so msasn1 is probably a game dependency, not a uplay dependency.)

[Bug 33742] UPlay 3.0.1 needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #28 from [e-mail] 2013-07-29 22:14:57 CDT ---
yes you re right Dan Kegel, im open games with terminal for show errors and
then appear libcef.dll and msasn1.dll as not found, but im only add for solve
this dependency

[Bug 33742] UPlay 3.0.1 needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Jaime Rave  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |32288

[Bug 33742] UPlay 3.0.1 needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Adam Bolte  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Berillions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UPlay 3.0.1 needs native    |UPlay 3.x/4.x needs native
                   |crypt32                     |crypt32

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #29 from [e-mail] ---
(In reply to comment #21)
> (In reply to comment #18)
> > Hi Berillions,
> >
> > I believe I have done that... I found the patch online and have manually
> > replicated it by setting crypt32/gdiplus to native for Uplay.exe only. I still
> > get the same crash:
> >
> > wine: Unhandled page fault on write access to 0x00000000 at address 0x8996f2
> > (thread 0066), starting debugger...
> >
> > I tried both launching the game or launching Uplay.exe standalone. Any idea
> > what I could be doing wrong?
> >
> > Thanks,
> >  Jelle.
>
> Awesome, uplay launches and now also it updates the game properly, but now
> it fails to launch....we are so close....

Hi

A few days ago I installed Anno 2070 Deep Sea and took the native crypt32.dll
from Win XP. It worked so far.
It crashed at the Game start because of the UPlay overlay with a console output
similar to yours. You can disable the Overlay in  your UPlay Settings.
I discovered the overlay needs something from wintrust (which has some
relations to crypt32 I guess) and crashes there. Disable the wintrust.dll to
avoid the game crash.

I hope this will get you a step forward.

Is the problem with wintrust connected to the crypt32 bug or should I open a
new bug?

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

nE0sIghT  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #30 from Anastasius Focht  ---
Hello folks,

confirming the SSL cert validation problem.

Most issues here are completely unrelated, please avoid messing up the bug with
different things.

Without 'crypt32.dll' override, 'Uplay.exe' hangs in a loop:

--- snip ----
Wine-dbg>bt 0x6a
Backtrace:
=>0 0x7e11821b CertGetIssuerCertificateFromStore+0xa(hCertStore=0x1941c8,
pSubjectContext=0x1972e4, pPrevIssuerContext=(nil), pdwFlags=0x6c6666c)
[/home/focht/projects/wine/wine.repo/src/dlls/crypt32/cert.c:1863] in crypt32
(0x06c66720)
  1 0x00b404c1 in uplay (+0x7404c0) (0x06c66720)
  2 0x00b3e12e in uplay (+0x73e12d) (0x06c66794)
  3 0x00b3eff3 in uplay (+0x73eff2) (0x06c6e5a8)
  4 0x00b3f4ab in uplay (+0x73f4aa) (0x06c6e600)
  5 0x00b3c3c4 in uplay (+0x73c3c3) (0x06c6e6d4)
  6 0x00b3cb4a in uplay (+0x73cb49) (0x06c6e76c)
  7 0x00b34aae in uplay (+0x734aad) (0x06c6e9d0)
  8 0x00b3376a in uplay (+0x733769) (0x06c6e9e8)
  9 0x00b1e862 in uplay (+0x71e861) (0x06c6ea58)
  10 0x7bc86780 call_thread_func_wrapper+0xb() in ntdll (0x06c6ea68)
  11 0x7bc867c9 call_thread_func+0x3e(entry=0xb1e7a0, arg=0x6249730,
frame=0x6c6eb68)
[/home/focht/projects/wine/wine.repo/src/dlls/ntdll/signal_i386.c:2630] in
ntdll (0x06c6eb48)
  12 0x7bc8675e call_thread_entry_point+0x11() in ntdll (0x06c6eb68)
--- snip ---

Relevant part of trace log:

--- snip ---
...
005d:Call KERNEL32.CreateProcessW(00000000,0033e5a8 L"C:\Program
Files\Ubisoft\Ubisoft Game Launcher\Uplay.exe -gamelauncher_wait_handle 228
-upc_uplay_id 802 -upc_game_version 1 -upc_exe_path
QzpcUHJvZ3JhbSBGaWxlc1xTdGVhbVxTdGVhbUFwcHNcY29tbW9uXENoaWxkIG9mIExpZ2h0IERlbW9cQ2hpbGRvZkxpZ2h0LmV4ZQ==
-upc_working_directory
QzpcUHJvZ3JhbSBGaWxlc1xTdGVhbV"...,00000000,00000000,00000000,00000410,00000000,00132ea0
L"C:\Program Files\Ubisoft\Ubisoft Game Launcher\",0033dc60,0033dc50)
ret=7e8f51e2 
...
005f:Call KERNEL32.__wine_kernel_init() ret=7bc5a4b2
...
005d:Ret  KERNEL32.CreateProcessW() retval=00000001 ret=7e8f51e2
...
006f:Call
secur32.InitializeSecurityContextA(0ad28fd0,067e46a4,00000000,0001801c,00000000,00000000,07406800,00000000,00000000,0740680c,07406848,074067f8)
ret=00ab646a
...
006f:Ret  secur32.InitializeSecurityContextA() retval=00000000 ret=00ab646a
...
006f:Call secur32.QueryContextAttributesA(067e46a4,00000053,07406734)
ret=00ab55b2
...
006f:Ret  secur32.QueryContextAttributesA() retval=00000000 ret=00ab55b2
...
006f:Call crypt32.CertDuplicateCertificateContext(001b1cec) ret=00ab78f4
006f:trace:crypt:CertDuplicateCertificateContext (0x1b1cec)
006f:Ret  crypt32.CertDuplicateCertificateContext() retval=001b1cec
ret=00ab78f4
...
<loop start>
...
006f:Call
crypt32.CertGetIssuerCertificateFromStore(001acb00,001afc1c,00000000,0740666c)
ret=00ab7981
006f:trace:crypt:CertGetIssuerCertificateFromStore (0x1acb00, 0x1afc1c, (nil),
00000000)
006f:trace:crypt:CertFindCertificateInStore (0x1acb00, 00010001, 00000000,
000c0000, 0x1afc1c, (nil))
006f:trace:crypt:CertFindExtension "2.5.29.1" 3 0x1b2f78
006f:trace:crypt:CertFindExtension "2.5.29.35" 3 0x1b2f78
006f:trace:crypt:CryptDecodeObjectEx (0x00010001, #001f, 0x1b2fd8, 24,
0x00008001, (nil), 0x74064e0, 0x74064fc)
...
006f:trace:crypt:CryptDecodeObjectEx returning 1
006f:trace:crypt:CertEnumCertificatesInStore (0x1acb00, (nil))
006f:trace:crypt:MemStore_enumCert (0x1acb00, (nil))
006f:trace:crypt:CertGetCertificateContextProperty (0x1afc1c, 20, (nil),
0x7406450)
006f:trace:crypt:CertContext_GetProperty (0x1afc00, 20, (nil), 0x7406450)
006f:trace:crypt:ContextPropertyList_FindProperty (0x1afc38, 20, 0x7406378)
006f:trace:crypt:CertContext_GetProperty returning 1
006f:trace:crypt:CertGetCertificateContextProperty returning 1
...
006f:trace:crypt:CertGetCertificateContextProperty (0x1afc1c, 20, 0x1b3070,
0x7406450)
006f:trace:crypt:CertContext_GetProperty (0x1afc00, 20, 0x1b3070, 0x7406450)
006f:trace:crypt:ContextPropertyList_FindProperty (0x1afc38, 20, 0x7406378)
006f:trace:crypt:CertContext_GetProperty returning 1
006f:trace:crypt:CertGetCertificateContextProperty returning 1
...
006f:trace:crypt:CertFindCertificateInStore returning 0x1afc1c
006f:trace:crypt:CertGetIssuerCertificateFromStore returning 0x1afc1c
006f:Ret  crypt32.CertGetIssuerCertificateFromStore() retval=001afc1c
ret=00ab7981
006f:Call crypt32.CertFreeCertificateContext(001afc1c) ret=00ab798a
006f:trace:crypt:CertFreeCertificateContext (0x1afc1c)
006f:Ret  crypt32.CertFreeCertificateContext() retval=00000001 ret=00ab798a
...
<loop end, repeats endlessly> 
--- snip ---

The app code specifically checks with 'GetLastError' for 'CRYPT_E_SELF_SIGNED'
after return from 'CertGetIssuerCertificateFromStore' (root certificate in
hierarchy must always be self-signed).
It doesn't look at 'pdwFlags' out parameter at all hence it's not a condition
to exit the loop.

MSDN:
http://msdn.microsoft.com/en-us/library/windows/desktop/aa376085%28v=vs.85%2...

--- quote ---
CRYPT_E_SELF_SIGNED

The issuer certificate is the same as the subject certificate. It is a
self-signed root certificate.
--- quote ---

It should probably check for that and set the error code accordingly (also
returning NULL).

I did a small test and it allowed 'UPlay' to succeed without any overrides (SSL
established -> update check/download and login successful).

$ wine --version
wine-1.7.19-154-g80a29e2

Regards

[Bug 33742] UPlay 3.x/4.x needs native crypt32

https://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #31 from Anastasius Focht  ---
*** Bug 33817 has been marked as a duplicate of this bug. ***

[Bug 33742] UPlay 3.x/4.x needs native crypt32

https://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #32 from Bruno Jesus  ---
Created attachment 48878
  --> https://bugs.winehq.org/attachment.cgi?id=48878
hack

Based on Anastasius analysis this hack does the trick for me, but I don't have
any idea if this was really what he was talking about.

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Tim Van den Langenbergh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #33 from Tim Van den Langenbergh  ---
Good evening, all,

I've tried running it both with and without the crypt32 override, yet UPlay
crashes within like 2 seconds of running, I'm running wine-1.7.21 fresh from
the Arch repositories.

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #34 from [e-mail] ---
(In reply to Tim Van den Langenbergh from comment #33)
> Good evening, all,
>
> I've tried running it both with and without the crypt32 override, yet UPlay
> crashes within like 2 seconds of running, I'm running wine-1.7.21 fresh from
> the Arch repositories.

On my case works good

https://www.youtube.com/watch?v=astN9ZdruX4

with wine 1.7.21 with this specs

Nvidia Drivers 340.17
Linux Mint 16 KDE Edition 32Bit - Kernel 3.11.0.12 PAE
CPU: INTEL Pentium G3220 (Haswell 22nm) 3.0Ghz (Dual-Core) Stock Clock
MEM: 8GB DDR3 1333 (2x4) Patriot value (128 bit dual channel: 21.3 gb/s)
GPU: Zotac Nvidia Geforce GT630 (GK208 28nm: 384 Shaders / 8 ROPS) Zone Edition
Passive Cooling 2GB DDR3 1800Mhz 64Bit (14.4Gb/s)
BOARD: MSI H81M E33

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #35 from Béla Gyebrószki  ---
(In reply to Bruno Jesus from comment #32)
> Created attachment 48878 [details]
> hack
>
> Based on Anastasius analysis this hack does the trick for me, but I don't
> have any idea if this was really what he was talking about.

With this patch applied Uplay starts fine for me.

wine-1.7.21-75-g0a4c786
UPlay version 4.6.1

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #36 from Juan Lang  ---
(In reply to Bruno Jesus from comment #32)
> Based on Anastasius analysis this hack does the trick for me, but I don't
> have any idea if this was really what he was talking about.

Bruno, this patch looks plausible to me. It only needs a test case to show that
it's correct. Maybe you could give that a go? I can try to take it on at some
point, but my time for working on Wine has been severely limited of late, plus
I don't want to take credit for the work you and AF have already done. Thanks!

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

--- Comment #37 from Bruno Jesus  ---
(In reply to Juan Lang from comment #36)
> Bruno, this patch looks plausible to me. It only needs a test case to show
> that it's correct. Maybe you could give that a go? I can try to take it on
> at some point, but my time for working on Wine has been severely limited of
> late, plus I don't want to take credit for the work you and AF have already
> done. Thanks!

Given the fact that I have no idea of what I've done I'm not able to create a
test. I was blindly following AF notes. For example, I don't know how to create
a root certificate and add it to the tests. And also how to add non-root
certificates and ensure the old functionality was not affected. I think you can
do it much faster than I so I would be happy if you take the patch.

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #38 from Juan Lang  ---
Adding myself so pings here remind me to work on this.

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Robert Munteanu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 33742] UPlay 3.x/4.x needs native crypt32

http://bugs.winehq.org/show_bug.cgi?id=33742

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |7a40fdbf8cb68df269c1a1c47f6
                   |                            |cc276ba1929e8
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #39 from Bruno Jesus  ---
Patch commited:
http://source.winehq.org/git/wine.git/?a=commit;h=7a40fdbf8cb68df269c1a1c47f...

Thanks for AF for the analysis, Béla for the test and Juan Lang for the
assistance.

[Bug 33742] UPlay 3.x/4.x needs native crypt32

https://bugs.winehq.org/show_bug.cgi?id=33742

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #40 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.23.