https://bugs.winehq.org/show_bug.cgi?id=46822
Bug ID: 46822 Summary: Edit control in ADL search dialog gets initially not drawn in DC++ 0.868, regression Product: Wine Version: 4.0 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs@winehq.org Reporter: dee3shee7aeno4@mailinator.com Distribution: ---
Created attachment 63845 --> https://bugs.winehq.org/attachment.cgi?id=63845 wine-4.3-229-g6d82b2f1ad-with-dadea2d11d78c73ce918d0c130db6dd32d06e6ee-reverted.png
In DC++ 0.868, not connected to a hub, menu View - ADL search - right click in the upper area - New ...
The created dialog does not draw the Search String edit control properly.
A git bisect led here: dadea2d11d78c73ce918d0c130db6dd32d06e6ee is the first bad commit Author: Nikolay Sivov nsivov@codeweavers.com Date: Fri Feb 16 14:19:00 2018 +0300 comctl32/edit: Force update on focus change.
That commit was a fix against bug #40002. Wine 3.2 is the first release containing that commit.
Reverting that commit on top of current git makes the edit control being drawn correctly.
Download: https://sourceforge.net/projects/dcplusplus/files/DC%2B%2B%200.868/
https://bugs.winehq.org/show_bug.cgi?id=46822
--- Comment #1 from dee3shee7aeno4 dee3shee7aeno4@mailinator.com --- Created attachment 63846 --> https://bugs.winehq.org/attachment.cgi?id=63846 wine-4.3-229-g6d82b2f1ad.png
https://bugs.winehq.org/show_bug.cgi?id=46822
dee3shee7aeno4 dee3shee7aeno4@mailinator.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |dadea2d11d78c73ce918d0c130d | |b6dd32d06e6ee Distribution|--- |Debian URL| |https://sourceforge.net/pro | |jects/dcplusplus/files/DC%2 | |B%2B%200.868/
https://bugs.winehq.org/show_bug.cgi?id=46822
dee3shee7aeno4 dee3shee7aeno4@mailinator.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bunglehead@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=46822
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com --- Thanks, confirming.
https://bugs.winehq.org/show_bug.cgi?id=46822
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|bunglehead@gmail.com |
https://bugs.winehq.org/show_bug.cgi?id=46822
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #3 from Fabian Maurer dark.shadow4@web.de --- Created attachment 64045 --> https://bugs.winehq.org/attachment.cgi?id=64045 Patch to revert the commit
Since the commit doesn't revert cleanly, I added a patch to revert the commit in question - for testing.
https://bugs.winehq.org/show_bug.cgi?id=46822
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=46822
Leandro Nini drfiemost@email.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |drfiemost@email.it
https://bugs.winehq.org/show_bug.cgi?id=46822
--- Comment #4 from Nikolay Sivov bunglehead@gmail.com --- I don't understand why this happens. I works again if I remove RDW_UPDATENOW from WM_SETFOCUS handler. There is nothing special about those Edit controls, focusing request comes from dialog logic, specifically from DEFDLG_SetFocus().
https://bugs.winehq.org/show_bug.cgi?id=46822
Julian Rüger jr98@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jr98@gmx.net
https://bugs.winehq.org/show_bug.cgi?id=46822
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com --- This appears to be fixed now, with https://source.winehq.org/git/wine.git/commit/a336b43a93ce7e0db813a6dac329b8.... Please retest with current Wine, it works for me for both themed and unthemed cases.
https://bugs.winehq.org/show_bug.cgi?id=46822
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com --- I'm going to mark this fixed, since it worked fine last time I tried.
https://bugs.winehq.org/show_bug.cgi?id=46822
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |a336b43a93ce7e0db813a6dac32 | |9b8aa1b5ccd9f
https://bugs.winehq.org/show_bug.cgi?id=46822
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.20.
https://bugs.winehq.org/show_bug.cgi?id=46822
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |7.0.x
https://bugs.winehq.org/show_bug.cgi?id=46822
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|7.0.x |---
--- Comment #8 from Michael Stefaniuc mstefani@winehq.org --- Removing the 7.0.x milestone from bug fixes included in 7.0.2.