[Bug 11824] New: handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

Summary: handling trailing space in .reg files
           Product: Wine
           Version: 0.9.56.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hi,

I wonder whether it's too much to ask to be bug-compatible with MS-Windows.
The attached .reg file contains several trailing spaces.

Actually, there are 2 issues here:
1. wine regedit wineregbug.reg yields an error.
regedit: ERROR, invalid hex value
regedit: ERROR Key HKEY_CURRENT_USER\Software\WineRegBugSpace\FooBar not
created. Value: Language, Data: dword:00000001
Caused by trailing space after "Language"=dword:00000001

2. "SaveDir"="" " is created in user.reg where ="" is expected, disregarding
the trailing space.

The same file, ran through regedit on MS-Windows 95 causes no error, and the
entries are created as expected, esp. "SaveDir"="".

I'm sorry that I did not write in my notes which application had such a .reg
file which caused me to observe and investigate these behaviours.

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

--- Comment #1 from Jörg Höhle   2008-03-03 10:46:42 ---
Created an attachment (id=11091)
 --> (http://bugs.winehq.org/attachment.cgi?id=11091)
wineregbug.reg creates registry entries differing from regedit on MS-Windows
95.

.reg file declared application/octet-stream to preserve CRLF

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

--- Comment #2 from Austin English   2008-06-12 13:15:29 ---
Is this still an issue in current (1.0-rc4 or newer) wine?

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

--- Comment #3 from Jörg Höhle   2008-09-16 06:55:12 ---
FWIW, MS-Windows 2000 also creates the entries, like w95, without error.
Test with current wine-1.1.4 still outstanding

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

--- Comment #4 from Jörg Höhle   2008-09-17 04:54:08 ---
It is still an issue in wine-1.1.4, as everybody can assess, using the
attachment in comment #1.

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

Andrey Turkin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Andrey Turkin   2008-10-01 15:08:19 ---
Patch to skip blanks at start, end around '=' was just committed to GIT; please
re-test with current GIT tree

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Nikolay Sivov   2009-01-07 01:41:11 ---
(In reply to comment #5)
> Patch to skip blanks at start, end around '=' was just committed to GIT; please
> re-test with current GIT tree

Works without any errors on 1.1.12. Entries are created as expected.

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

--- Comment #7 from Jörg Höhle   2009-01-19 07:31:58 ---
Confirmed with 1.1.13. AJ would say: "Closing bugs fixed in 1.1.13." (or so it
seams, earlier)

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

--- Comment #8 from Andrey Turkin   2009-01-19 07:39:19 ---
> Confirmed with 1.1.13. AJ would say: "Closing bugs fixed in 1.1.13." (or so it
> seams, earlier)

Please set RESOLVED FIXED status then

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Jörg Höhle   2009-01-19 08:33:48 ---
Closing bugs fixed in 1.1.13 (earlier indeed).

It'd be nice if there were a more complete guideline than
http://wiki.winehq.org/Bugs or wiki page about who is supposed to perform what
status changes in the bugtracker, e.g.
 - don't ever change the original submitted version
 - when to mark something as closed (I thought AJ would do so prior to release)
 - what the policy for marking as duplicate is (empirically I've observed that
whenever two regressions are discovered to originate in the same commit, one
issue is marked as a duplicate of the other one).
 - how to change the subject line when other applications are found to be
affected by the same issue
 - ...

[Bug 11824] handling trailing space in .reg files

http://bugs.winehq.org/show_bug.cgi?id=11824

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Vitaliy Margolen   2009-01-19 14:56:19 ---
Just close it.