[Bug 15734] New: Bugsplat software crash reporter crashes

http://bugs.winehq.org/show_bug.cgi?id=15734

Summary: Bugsplat software crash reporter crashes
           Product: Wine
           Version: 1.1.6
          Platform: Other
               URL: http://bugsplatsoftware.com/
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When run normally, bugsplat's BsSndRpt.exe crashes with

Unhandled exception: page fault on read access to 0x74616469 in 32-bit code
(0x7e9476d1).
Backtrace:
=>1 HttpOpenRequestA+0x2a1(hHttpSession=0x2, lpszVerb="POST",
lpszObjectName="/ws/ReportRejectionServices.php", lpszVersion
="HTTP/1.0", lpszReferrer="", lpszAcceptTypes=0x7e13d4d8, dwFlags=71303232,
dwContext=0) [dlls/wininet/http.c:1024] in wininet 
...
HttpOpenRequestA+0x2a1 [wininet/http.c:1024] in wininet: cmpb      
$0x0,0x0(%edx)
1024                if (((ULONG_PTR)*types >> 16) && **types)

Running with WINEDEBUG=+winhttp, it of course doesn't crash, and I see

trace:wininet:HttpOpenRequestA (0x2, "POST", "/ws/ReportRejectionServices.php",
"HTTP/1.0", "", 0x7e1454d8, 04400040, 00000000)

Funny that the dwFlags argument, and evidently *lpszAcceptTypes,
are garbage in the crash case...?

(Not sure if BsSndRpt.exe in this case is the example one from Bugsplat
or not, this is in a non-public app.  I'll try to find out.)

[Bug 15734] Bugsplat software crash reporter crashes

http://bugs.winehq.org/show_bug.cgi?id=15734

--- Comment #1 from Hans Leidekker   2008-10-23 15:07:32 ---
Created an attachment (id=16828)
 --> (http://bugs.winehq.org/attachment.cgi?id=16828)
wininet: Add an exception handler in HttpOpenRequestA to protect against
invalid accept type pointers.

This app passes an invalid pointer with the high word set, so we do
need an exception handler. Here's a patch.

[Bug 15734] Bugsplat software crash reporter crashes

http://bugs.winehq.org/show_bug.cgi?id=15734

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 15734] Bugsplat software crash reporter crashes

http://bugs.winehq.org/show_bug.cgi?id=15734

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Hans Leidekker   2008-10-24 12:31:48 ---
Committed as bd805297090da797cff0c6fac3098a00e2ce801e.

[Bug 15734] Bugsplat software crash reporter crashes

http://bugs.winehq.org/show_bug.cgi?id=15734

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Hans Leidekker   2008-10-24 12:32:52 ---
And in release 1.1.7.

[Bug 15734] Bugsplat software crash reporter crashes

http://bugs.winehq.org/show_bug.cgi?id=15734

--- Comment #4 from Dan Kegel   2008-10-24 13:06:52 ---
Thanks!