[Bug 53893] New: ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53893

Bug ID: 53893
           Summary: ws2_32:sock - test_WSASocket() gets an unexpected raw
                    protocol name in French on Windows
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: winsock
          Assignee: [e-mail]
          Reporter: [e-mail]

ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French
on Windows:

sock.c:2952: Test failed: got szProtocol L"TCP/IP MSAFD [RAW/IP]".

See: https://test.winehq.org/data/patterns.html#ws2_32:sock

The test only gets this protocol name when running in a French local which
means it may actually be translated (though it's not obvious looking at it).

Could this mean that the "Some Win7 machines" case is also because of
translations?

This failure started with the commit below:

commit 4c67e0fb7917025646725d2b6133e0778802afe1
Author: Paul Gofman 
Date:   Tue Jul 5 11:33:51 2022 -0500

ws2_32: Add ipv4 raw socket protocol info.

Signed-off-by: Paul Gofman

[Bug 53893] ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53893

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source,
                   |                            |testcase
                 CC|                            |[e-mail]
    Regression SHA1|                            |4c67e0fb7917025646725d2b613
                   |                            |3e0778802afe1

[Bug 53893] ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53893

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Zeb Figura  ---
Yeah, the English name is "MSAFD Tcpip [RAW/IP]". I guess it was necessary to
make that a postpositive adjective??

[Bug 53893] ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53893

--- Comment #2 from François Gouget  ---
The "MSAFD-Tcpip [RAW/IP]" value is not related to Windows 7. w10pro64-de has
the same. It's just the German translation.

So we have:

de:         MSAFD-Tcpip [RAW/IP]
fr:         TCP/IP MSAFD [RAW/IP]
All others: MSAFD Tcpip [RAW/IP]

[Bug 53893] ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53893

--- Comment #3 from Paul Gofman  ---
When adding this test I had no idea that those protocol names are localized. I
don't think we want to test these localized strings or support their
localization until something depends on that. I sent MR 1287 which just removes
the test and drops a comment instead.

[Bug 53893] ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53893

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2d5de1d911bb847ec8d5dfad456
                   |                            |9454e152ae834
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from François Gouget  ---
This is fixed. Thanks Paul!

commit 2d5de1d911bb847ec8d5dfad4569454e152ae834
Author: Paul Gofman 
Date:   Mon Nov 7 21:01:26 2022 -0600

ws2_32/tests: Don't test protocol name in test_WSASocket().

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53893

[Bug 53893] ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53893

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 7.21.